Reminder: /stats.json is deprecated

2015-04-08 Thread Alex Rukletsov
Folks, if you build tooling around Mesos, please be advised that in current 0.22 Mesos release /stats.json endpoint is deprecated in favour of /metrics/snapshot and will be removed in Mesos 0.23 release. If you rely on /stats.json, please update your code to use the new endpoint instead. Related

Re: Question on Docker Containerizer

2015-04-08 Thread Alex Rukletsov
Stephen, FWIK, every containerizer supports two launch strategies: with custom executor and with the default mesos-executor. Docker containerizer is no exception. To use your own executor, specify ExecutorInfo instead of CommandInfo in your TaskInfo. Also make sure you provide ContainerInfo in

Re: Suggestion: Mesos 0.22.1 point release

2015-04-08 Thread Adam Bordelon
Hi Adam, Yes, once we have finalized the scope of the point release, Niklas will send out an announcement of Mesos 0.22.1-rc1 (release candidate) which we would love you to test any way you can. The email will contain instructions for building the release candidate and voting in the thread. See

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

2015-04-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31444/#review79361 --- Patch looks great! Reviews applied: [32978, 32891, 31444] All

Review Request 32975: MESOS-1790 Adds chown option to CommandInfo.URI

2015-04-08 Thread Jim Klucar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32975/ --- Review request for mesos. Bugs: MESOS-1790

Re: Review Request 32975: MESOS-1790 Adds chown option to CommandInfo.URI

2015-04-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32975/#review79352 --- Patch looks great! Reviews applied: [32975] All tests passed. -

Re: Review Request 32150: Enable the master to handle reservation operations.

2015-04-08 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32150/ --- (Updated April 8, 2015, 5:04 p.m.) Review request for mesos, Alexander

Re: Review Request 29748: Added tests for dynamic reservation.

2015-04-08 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29748/ --- (Updated April 8, 2015, 5:05 p.m.) Review request for mesos, Alexander

Review Request 32967: [MESOS-2565] Cleaned upstyle and comments in modules

2015-04-08 Thread Aditi Dixit
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32967/ --- Review request for mesos. Bugs: MESOS-2565

Re: Review Request 31666: Piped hashmapSlaveID, Resources from master through to allocator.

2015-04-08 Thread Alexander Rukletsov
On March 6, 2015, 10:57 p.m., Alexander Rukletsov wrote: src/master/allocator/allocator.hpp, line 67 https://reviews.apache.org/r/31666/diff/2/?file=883424#file883424line67 In `updateAllocation()` and `recoverResources()` we pass both `SlaveID` and `FrameworkID` as function

Re: Review Request 32967: Cleaned upstyle and comments in modules.

2015-04-08 Thread Aditi Dixit
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32967/ --- (Updated April 8, 2015, 1:35 p.m.) Review request for mesos, Alexander

Re: Review Request 32967: [MESOS-2565] Cleaned upstyle and comments in modules

2015-04-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32967/#review79335 --- Please check my comment to https://reviews.apache.org/r/32608/.

Re: Review Request 32967: Cleaned upstyle and comments in modules.

2015-04-08 Thread Aditi Dixit
On April 8, 2015, 1:20 p.m., Alexander Rukletsov wrote: Please check my comment to https://reviews.apache.org/r/32608/. Also, please add Kapil Arya karya, myself alex-mesos and a committer to the list of reviewers. Would adding any committer be ok? Or should I email and ask a

Re: Review Request 31667: Piped hashmapSlaveID, Resources from allocator through to sorter.

2015-04-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31667/#review79345 --- Ship it! src/master/allocator/mesos/hierarchical.hpp

Re: Review Request 31665: Updated master::Framework::usedResources and master::Framework::offerResources from Resources to hashmapSlaveID, Resources.

2015-04-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31665/#review79333 --- Ship it! Minor nits, otherwise looks good to me!

Re: Review Request 32967: [MESOS-2565] Cleaned upstyle and comments in modules

2015-04-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32967/#review79339 --- Patch looks great! Reviews applied: [32967] All tests passed. -

Participating in Container Days Boston 2015 (June 5-6)?

2015-04-08 Thread Andrew Phillips
Hi Mesos devs I'm one of the volunteers currently organizing ContainerDays Boston [1, 2], a community (un)conference taking place on June 5-6th focused on containers and dynamic infrastructure in general - devopsdays for containers, more or less. Specifically, we're trying to provide a

[GitHub] mesos pull request: Proposing addition of missing hashCode functio...

2015-04-08 Thread pharshal
Github user pharshal commented on the pull request: https://github.com/apache/mesos/pull/39#issuecomment-90903233 Travis failure is unrelated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

2015-04-08 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31444/ --- (Updated April 8, 2015, 8:24 a.m.) Review request for mesos, Chi Zhang,

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

2015-04-08 Thread Ian Downes
On March 20, 2015, 5:21 p.m., Chi Zhang wrote: src/slave/containerizer/mesos/launch.cpp, line 296 https://reviews.apache.org/r/31444/diff/2/?file=898403#file898403line296 From my testing, you only need to make-slave on the newRoot for the pivot_root to work. Is the

Re: Review Request 32967: Cleaned upstyle and comments in modules.

2015-04-08 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32967/#review79348 --- Ship it! Ship It! - Kapil Arya On April 8, 2015, 9:35 a.m.,

Review Request 32978: Add os::stat::inode to stout.

2015-04-08 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32978/ --- Review request for mesos, Chi Zhang, Jie Yu, and Paul Brett. Repository: mesos

Re: Review Request 31914: cgroups: added memsw_usage_in_bytes.

2015-04-08 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31914/#review79357 --- Ship it! Ship It! - Ian Downes On April 1, 2015, 3:27 p.m., Chi

Re: Question on Docker Containerizer

2015-04-08 Thread Adam Bordelon
Hi Thomas, You might be looking for a custom (external) containerizer. The containerizer is what creates the container that the executor is run in, so you should not have an executor launching another containerizer. If you want to modify/control the docker run commands (besides specifying

Review Request 32983: Fixed a bug regarding setting work_dir for a local cluster.

2015-04-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32983/ --- Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos

Review Request 32984: Added an example framework for testing persistent volumes.

2015-04-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32984/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-2404

Re: Review Request 32501: Removed REQUEST call from scheduler.proto.

2015-04-08 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32501/#review79392 --- src/scheduler/scheduler.cpp

Re: Review Request 32398: Persist the reservation state on the slave.

2015-04-08 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32398/ --- (Updated April 8, 2015, 6:38 p.m.) Review request for mesos and Alexander

Review Request 32982: Added reservation user guide.

2015-04-08 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/ --- Review request for mesos, Alexander Rukletsov and Timothy Chen. Bugs:

Re: Review Request 32756: [4/5] Added a memory statistics test for active anonymous memory.

2015-04-08 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32756/#review79390 --- src/tests/cgroups_tests.cpp

Re: Review Request 31012: [1/5] Added memory statisics test fixure and a test for RSS.

2015-04-08 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31012/#review79387 --- src/tests/cgroups_tests.cpp

Re: Review Request 32754: [2/5] Added a memory statistics test for page cache.

2015-04-08 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32754/#review79388 --- src/tests/cgroups_tests.cpp

Re: Review Request 32757: [5/5] Added a memory statistics test for writeback.

2015-04-08 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32757/#review79394 --- src/tests/cgroups_tests.cpp

Re: Review Request 32755: [3/5] Added a memory statistics test for memory-mapped file.

2015-04-08 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32755/#review79389 --- src/tests/cgroups_tests.cpp

Re: Review Request 32955: Simplified ROOT_CGROUPS_Listen test.

2015-04-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32955/#review79395 --- Ship it! Great cleanup! src/tests/cgroups_tests.cpp

Re: Review Request 32955: Simplified ROOT_CGROUPS_Listen test.

2015-04-08 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32955/#review79400 --- Ship it! src/tests/cgroups_tests.cpp

Re: Review Request 32139: Add 'Resource::ReservationInfo' protobuf message.

2015-04-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32139/#review79404 --- Ship it! Ship It! - Jie Yu On April 7, 2015, 9:52 p.m., Michael

Re: Review Request 32956: Simplified MemUsage test.

2015-04-08 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32956/#review79401 --- Ship it! src/tests/isolator_tests.cpp

Re: Review Request 32984: Added an example framework for testing persistent volumes.

2015-04-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32984/ --- (Updated April 8, 2015, 7:08 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 32699: Set death signal for the perf subprocess.

2015-04-08 Thread Ian Downes
On April 2, 2015, 10:24 a.m., Ian Downes wrote: src/linux/perf.cpp, line 188 https://reviews.apache.org/r/32699/diff/1/?file=911392#file911392line188 I thought about this again, and it won't be sufficient for perf: we use perf with a child sleep process to control the sample

Re: Review Request 32843: Updated KILL to include SlaveID.

2015-04-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32843/#review79373 --- I'm still not sure whether it's necessary to provide `SlaveID` in

Re: Review Request 32501: Removed REQUEST call from scheduler.proto.

2015-04-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32501/#review79354 --- Ship it! - Alexander Rukletsov On March 31, 2015, 12:06 a.m.,

Re: Review Request 32502: Updated RECONCILE call to always specifiy slave id.

2015-04-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32502/#review79358 --- include/mesos/mesos.proto

Re: Review Request 32509: Documented the scheduler Event/Call protobufs.

2015-04-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32509/#review79383 --- LGTM, not a native speaker though, hence no ShipIt.

Re: Review Request 32504: Removed MasterInfo from REGISTER and REREGISTER scheduler calls.

2015-04-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32504/#review79368 --- Ship it! - Alexander Rukletsov On March 31, 2015, 12:08 a.m.,

Re: Review Request 32845: Renamed UNREGISTER call to UNSUBSCRIBE.

2015-04-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32845/#review79381 --- src/master/master.cpp

Re: Review Request 32505: Added SHUTDOWN scheduler call.

2015-04-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32505/#review79369 --- src/master/master.cpp

Re: Review Request 32844: Added SUBSCRIBE call and SUBSCRIBED event.

2015-04-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32844/#review79378 --- Ship it! Looks good to me, mind update the design doc?

Re: Review Request 32506: Added output stream operators for scheduler Calls and Events.

2015-04-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32506/#review79376 --- Ship it! include/mesos/type_utils.hpp

Re: Review Request 32500: Removed LAUNCH call from scheduler.proto.

2015-04-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32500/#review79351 --- include/mesos/scheduler/scheduler.proto

Re: Review Request 32984: Added an example framework for testing persistent volumes.

2015-04-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32984/#review79413 --- Patch looks great! Reviews applied: [32983, 32984] All tests

Re: Review Request 32664: Add port mapping isolator statistics tests

2015-04-08 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32664/#review79409 --- A few major concerns here before I do a proper review: 1. Did you

Re: Review Request 32398: Persist the reservation state on the slave.

2015-04-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32398/#review79417 --- Bad patch! Reviews applied: [32139, 32140, 32149, 32150, 29748,

Build failed in Jenkins: mesos-reviewbot #5042

2015-04-08 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/5042/ -- [URLTrigger] A change within the response URL invocation (log) Building remotely on ubuntu-2 (docker Ubuntu ubuntu) in workspace https://builds.apache.org/job/mesos-reviewbot/ws/ git rev-parse

Review Request 32995: Split up documentation for reporting bugs and submitting patches.

2015-04-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32995/ --- Review request for mesos, Benjamin Hindman and Vinod Kone. Repository: mesos

Re: Review Request 32398: Persist the reservation state on the slave.

2015-04-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32398/#review79445 --- Ship it! Nice tests! src/common/resources.cpp

Re: Review Request 32998: Split committer's guide into code reviewing and committing documents.

2015-04-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32998/#review79457 --- Thanks for doing this! I know most of this was just splitting the

Review Request 32997: Removed stale 'Code Internals' document.

2015-04-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32997/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 32999: Added a document for engineering principles and practices.

2015-04-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32999/#review79463 --- Patch looks great! Reviews applied: [32995, 32996, 32997, 32998,

Re: Review Request 32999: Added a document for engineering principles and practices.

2015-04-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32999/#review79461 --- Ship it! Love it! There are probably more values we can add, but

Jenkins build is back to normal : mesos-reviewbot #5045

2015-04-08 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/5045/

Re: Review Request 32982: Added reservation user guide.

2015-04-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/#review79436 --- Patch looks great! Reviews applied: [32982] All tests passed. -

Review Request 32996: Updated roadmap document to link to 'Epic' tickets.

2015-04-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32996/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 32999: Added a document for engineering principles and practices.

2015-04-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32999/ --- Review request for mesos, Adam B, Benjamin Hindman, Jie Yu, Niklas Nielsen, and

Re: Review Request 30961: Enabled label decorator to override.

2015-04-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30961/#review79454 --- Ship it! LGTM. Where's the JIRA/patch for updating the upgrades

Re: Review Request 32975: MESOS-1790 Adds chown option to CommandInfo.URI

2015-04-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32975/#review79433 --- include/mesos/mesos.proto

Review Request 32998: Split committer's guide into code reviewing and committing documents.

2015-04-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32998/ --- Review request for mesos, Adam B, Benjamin Hindman, Jie Yu, Niklas Nielsen, and

Re: Review Request 32149: Enable 'Resources::apply' to handle reservation operations.

2015-04-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32149/#review79430 --- src/common/resources.cpp

Re: Review Request 32504: Removed MasterInfo from REGISTER and REREGISTER scheduler calls.

2015-04-08 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32504/#review79452 --- src/scheduler/scheduler.cpp

Re: Review Request 31915: MemIsolator: Improved some statistics naming. (MESOS-2104)

2015-04-08 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31915/#review79424 --- Ship it! Looks good. Before we can commit this, can you please

Re: Review Request 31480: Fix check for lseek error.

2015-04-08 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31480/#review79432 --- Ship it! src/slave/state.cpp

Build failed in Jenkins: mesos-reviewbot #5044

2015-04-08 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/5044/ -- [URLTrigger] A change within the response URL invocation (log) Building remotely on H10 (Ubuntu ubuntu) in workspace https://builds.apache.org/job/mesos-reviewbot/ws/ git rev-parse

Re: Review Request 32140: Enable 'Resources' to handle 'Resource::ReservationInfo'.

2015-04-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32140/#review79410 --- src/common/resources.cpp

Build failed in Jenkins: mesos-reviewbot #5043

2015-04-08 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/5043/ -- [URLTrigger] A change within the response URL invocation (log) Building remotely on H10 (Ubuntu ubuntu) in workspace https://builds.apache.org/job/mesos-reviewbot/ws/ git rev-parse