Re: Contribution Request

2016-01-15 Thread Artem Harutyunyan
Done. Welcome to Mesos community! On Fri, Jan 15, 2016 at 9:26 AM, Disha Singh wrote: > Please add me to the list of Mesos contributors. I would like to submit a > code review for the following JIRA: >

Re: Contribution Request

2016-01-15 Thread Disha Singh
MESOS-4386 says : <<>>> How should I move ahead with resolving it ? Does it simply mean changing the word "authenticate" to authenticate frameworks ? I am a newbie .Please help. :) On Fri, Jan 15, 2016 at 11:07 PM, Artem Harutyunyan wrote: > Done. Welcome to

Re: Contribution Request

2016-01-15 Thread Vinod Kone
done On Fri, Jan 15, 2016 at 8:35 AM, Jiří Šimša wrote: > Please add me to the list of Mesos contributors. I would like to submit a > code review for the following JIRA > . > > Best, > > -- > Jiří Šimša >

Contribution Request

2016-01-15 Thread Disha Singh
Please add me to the list of Mesos contributors. I would like to submit a code review for the following JIRA:

Contribution Request

2016-01-15 Thread Jiří Šimša
Please add me to the list of Mesos contributors. I would like to submit a code review for the following JIRA . Best, -- Jiří Šimša

Re: Contribution Request

2016-01-15 Thread Disha Singh
Yes,It does. If you could tell me where these flags are and where I should add them . I tried to figure it out in the git repository : https://github.com/apache/mesos But unfortunately could not. On Fri, Jan 15, 2016 at 11:45 PM, Vinod Kone wrote: > Hi Disha, > > Thanks

Re: Contribution Request

2016-01-15 Thread Artem Harutyunyan
Hi Disha, Did you get a chance to take a look at http://mesos.apache.org/documentation/latest/submitting-a-patch/? Cheers, Artem. On Fri, Jan 15, 2016 at 10:35 AM, Disha Singh wrote: > Yes,It does. If you could tell me where these flags are and where I should > add

Re: Contribution Request

2016-01-15 Thread Abhishek Dasgupta
Hi Disha, Welcome to mesos community. First of all, if you want to work on MESOS-4386, you need to assign yourself the ticket. So go through all the necessary steps of http://mesos.apache.org/documentation/latest/submitting-a-patch/ for that. I think, if you check this source file

Re: Contribution Request

2016-01-15 Thread Disha Singh
Yes Artem, I did look at the link .I'm only looking for an issue which I can resolve so that I can start working with the patch. I also read about "shepherd". I wonder when I can be assigned one. Also , I think it's easy to resolve : < https://issues.apache.org/jira/browse/MESOS-4336> but I can't

Re: Contribution Request

2016-01-15 Thread Vinod Kone
Hi Disha, Thanks for asking. We cannot just rename the `authenticate` flag to `authenticate_frameworks` because that will break users who are already setting that flag, when they upgrade to the new version (that has this change). We always strive to do backwards compatible changes. The first

Re: Contribution Request

2016-01-15 Thread Vinod Kone
We really need to swap steps 4 (well the assigning part) and 6 in the "submitting a patch " link. I would love for new users to first find a shepherd, discuss the problem/solution *before* assigning the ticket to themselves. On

Re: Contribution Request

2016-01-15 Thread Vaibhav Khanduja
Current process makes sure bad code does not get in … though not sure of this swap ... On Fri, Jan 15, 2016 at 11:12 AM, Vinod Kone wrote: > We really need to swap steps 4 (well the assigning part) and 6 in the > "submitting > a patch

Re: Contribution Request

2016-01-15 Thread Disha Singh
The documentation says "find a shepherd" but in the "create an issue" option on JIRA one can click on any user he feels like. I am not understanding the process actually. Please help. I created an issue taking an idea from the suggestion above:

Re: Contribution Request

2016-01-15 Thread Vaibhav Khanduja
As per process, you need to get a shepherd. Easiest way to send an email to dev community requesting commiters .. On Fri, Jan 15, 2016 at 12:36 PM, Disha Singh wrote: > The documentation says "find a shepherd" but in the "create an issue" > option on JIRA one can

Re: Operator HTTP endpoints

2016-01-15 Thread Benjamin Mahler
The distinction between being related to the request vs. how the request should be processed seems arguable, do you feel that we'll be able to make the distinction easily? One thought.. if there are top-level Request objects: message QuotaRequest { optional bool force; required QuotaInfo

Re: Contribution Request

2016-01-15 Thread Jiří Šimša
Thanks Vinod. Would you mind being a shepherd for this code review? Thank you. Best, -- Jiří Šimša On Fri, Jan 15, 2016 at 8:52 AM, Vinod Kone wrote: > done > > On Fri, Jan 15, 2016 at 8:35 AM, Jiří Šimša wrote: > > > Please add me to the list of

Re: Contribution Request

2016-01-15 Thread Vinod Kone
Seems simple enough. Sure. On Fri, Jan 15, 2016 at 2:33 PM, Jiří Šimša wrote: > Thanks Vinod. Would you mind being a shepherd for this code review? Thank > you. > > Best, > > -- > Jiří Šimša > > On Fri, Jan 15, 2016 at 8:52 AM, Vinod Kone wrote: > >

Re: Contribution Request

2016-01-15 Thread Jiří Šimša
Thank you. Here is the code review . -- Jiří Šimša On Fri, Jan 15, 2016 at 3:27 PM, Vinod Kone wrote: > Seems simple enough. Sure. > > On Fri, Jan 15, 2016 at 2:33 PM, Jiří Šimša wrote: > > > Thanks Vinod.