Re: mesos git commit: Added `DEFAULT_ROLE` constant to persistent volume tests.

2016-09-22 Thread Greg Mann
Good point, I think `DEFAULT_TEST_ROLE` would be better. I was indeed hoping to make use of this in other tests, but we could keep them local to the tests for now, and move it later if it becomes a common pattern. Greg On Thu, Sep 22, 2016 at 10:13 AM, Neil Conway wrote:

Re: mesos git commit: Added `DEFAULT_ROLE` constant to persistent volume tests.

2016-09-22 Thread Neil Conway
I'm not sure this is a good idea: the "default role" is actually "*". That is also the default value for the "role" fields in the protobufs. Perhaps we should name this new constant something like DEFAULT_TEST_ROLE? I wonder also if we should keep the definition local to

Re: Question about the deprecated policy after 1.0

2016-09-22 Thread Yan Xu
Thanks @haosdent. Sorry there's been offline chats and I was waiting for that to circle back to the list. Comments inlined. Besides this particular issue I think we all agree that we can improve the versioning doc to avoid confusion in the future. I'll send a RR for that but let's focus on