[GitHub] mesos pull request #300: Fixed a typo in fetcher.cpp.

2018-07-06 Thread carlonelong
GitHub user carlonelong opened a pull request: https://github.com/apache/mesos/pull/300 Fixed a typo in fetcher.cpp. Change-Id: I48a5dc471acc6e1759dfedc3f25420e60c2f3f88 You can merge this pull request into a Git repository by running: $ git pull

Re: Normalization of metric keys

2018-07-06 Thread Benjamin Mahler
Do we also want: 3. Has an unambiguous decoding. Replacing '/' with '#%$' means I don't know if the user actually supplied '#%$' or '/'. But using something like percent-encoding would have property 3. On Fri, Jul 6, 2018 at 10:25 AM, Greg Mann wrote: > Thanks for the reply Ben! > > Yea I

Re: [Proposal] Replicated log storage compaction

2018-07-06 Thread Benjamin Mahler
I was chatting with Ilya on slack and I'll re-post here: * Like Jie, I was hoping for a toggle (maybe it should start default off until we have production experience? sounds like Ilya has already experience with it running in test clusters so far) * I was asking whether this would be considered

Re: [Proposal] Replicated log storage compaction

2018-07-06 Thread Vinod Kone
I don't know about the replicated log, but the proposal seems find to me. Jie/BenM, do you guys have an opinion? On Mon, Jul 2, 2018 at 10:57 PM Santhosh Kumar Shanmugham wrote: > +1. Aurora will hugely benefit from this change. > > On Mon, Jul 2, 2018 at 4:49 PM Ilya Pronin > wrote: > > > Hi

Re: Normalization of metric keys

2018-07-06 Thread Greg Mann
Thanks for the reply Ben! Yea I suspect the lack of normalization there was not intentional, and it means that you can no longer reliably split on '/' unless you apply some external controls to user input. Yep, this is bad :) One thing we should consider when normalizing metadata embedded in