[GitHub] mesos pull request #296: Add xiao wei.

2018-07-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/mesos/pull/296 ---

Re: RFC: update C++ style to require the "override" keyword

2018-07-09 Thread Greg Mann
+1 On Mon, Jul 9, 2018 at 3:38 PM, Andrew Schwartzmeyer < and...@schwartzmeyer.com> wrote: > +1 > > > On 07/09/2018 8:32 am, Till Toenshoff wrote: > >> +1 — that feature as saved us from nasty issues already when working >> on internal modules. >> >> On Jul 9, 2018, at 8:43 AM, Zhitao Li wrote:

Re: RFC: update C++ style to require the "override" keyword

2018-07-09 Thread Andrew Schwartzmeyer
+1 On 07/09/2018 8:32 am, Till Toenshoff wrote: +1 — that feature as saved us from nasty issues already when working on internal modules. On Jul 9, 2018, at 8:43 AM, Zhitao Li wrote: +1 On Sun, Jul 8, 2018 at 10:55 PM Benjamin Bannier < benjamin.bann...@mesosphere.io> wrote: Hi James,

Re: RFC: update C++ style to require the "override" keyword

2018-07-09 Thread Benjamin Bannier
Hi, >> Note that since our style guide _is_ the Google style guide plus some >> additions, we shouldn't need to update anything in our style guide; the >> Google >> style guide seems to have started requiring this from February this year and >> our code base just got out of sync > > I'd prefer

Re: [VOTE] Release Apache Mesos 1.3.3 (rc1)

2018-07-09 Thread Michael Park
I'm considering simply abandoning the 1.3.3 release and bringing the 1.3.x branch to end of life. If anyone really wants a 1.3.3, I'm certainly willing to finish the release portion of this but I don't have time to dig into the CI issue that Vinod pointed out. If someone feels compelled to

Re: Normalization of metric keys

2018-07-09 Thread Greg Mann
Good idea; I think percent-encoding sounds great. Unless there are any objections, I'll go with that approach. On Fri, Jul 6, 2018 at 5:32 PM, Benjamin Mahler wrote: > Do we also want: > > 3. Has an unambiguous decoding. > > Replacing '/' with '#%$' means I don't know if the user actually

[GitHub] mesos issue #300: Fixed a typo in fetcher.cpp.

2018-07-09 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/mesos/pull/300 Thanks @carlonelong ---

[GitHub] mesos pull request #300: Fixed a typo in fetcher.cpp.

2018-07-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/mesos/pull/300 ---

Re: RFC: update C++ style to require the "override" keyword

2018-07-09 Thread James Peach
> On Jul 8, 2018, at 10:55 PM, Benjamin Bannier > wrote: > > Hi James, > >> I’d like to propose that we update our style to require that the >> “override” keyword always be used when overriding virtual functions >> (including destructors). The proposed text is below. I’ll also prepare >> a

Re: RFC: update C++ style to require the "override" keyword

2018-07-09 Thread Till Toenshoff
+1 — that feature as saved us from nasty issues already when working on internal modules. > On Jul 9, 2018, at 8:43 AM, Zhitao Li wrote: > > +1 > > On Sun, Jul 8, 2018 at 10:55 PM Benjamin Bannier < > benjamin.bann...@mesosphere.io> wrote: > >> Hi James, >> >>> I’d like to propose that we

Register now for ApacheCon and save $250

2018-07-09 Thread Rich Bowen
Greetings, Apache software enthusiasts! (You’re getting this because you’re on one or more dev@ or users@ lists for some Apache Software Foundation project.) ApacheCon North America, in Montreal, is now just 80 days away, and early bird prices end in just two weeks - on July 21. Prices will

Re: RFC: update C++ style to require the "override" keyword

2018-07-09 Thread Zhitao Li
+1 On Sun, Jul 8, 2018 at 10:55 PM Benjamin Bannier < benjamin.bann...@mesosphere.io> wrote: > Hi James, > > > I’d like to propose that we update our style to require that the > > “override” keyword always be used when overriding virtual functions > > (including destructors). The proposed text