Re: Moving the website repo from svn to git

2017-06-01 Thread Benjamin Mahler
odk...@apache.org> wrote: > On Thu, Jun 1, 2017 at 2:24 PM, Benjamin Mahler <bmah...@apache.org> > wrote: > > > Curious to know more about what 2) looks like. > > > > > We would be maintaining a remote branch called "asf-site", similar to how >

Re: [VOTE] Release Apache Mesos 1.3.0 (rc3)

2017-06-01 Thread Benjamin Mahler
+1 (binding) Looks like ExamplesTest.DynamicReservationFramework is flaky, unfortunately wasn't able to get the logs for a failed run. On Thu, Jun 1, 2017 at 2:03 PM, Benjamin Mahler <bmah...@apache.org> wrote: > Not a blocker, but noticed the parallel test runner isn't bundled in the

Re: RFC: Partition Awareness

2017-06-01 Thread Benjamin Mahler
If I understood correctly, the proposal is to not kill the tasks for non-partition aware frameworks? That seems like a pretty big change for frameworks that are not partition aware and expect the old killing semantics. It seems like we should just directly fix the issue, do you have a sense of

Re: [VOTE] Release Apache Mesos 1.3.0 (rc3)

2017-06-01 Thread Benjamin Mahler
Not a blocker, but noticed the parallel test runner isn't bundled in the release, if you configure with '--enable-parallel-test-execution': /Users/bmahler/Downloads/mesos-1.3.0/support/mesos-gtest-runner.py --sequential=*ROOT_* ./stout-tests /bin/sh:

Re: Moving Mesos builds reqs from GCC 4.8.1+ to GCC 4.9.0+

2017-05-30 Thread Benjamin Mahler
There's a spreadsheet linked in https://issues.apache.org/jira/browse/MESOS-2604 that captures which OSes we can support based on compiler version: https://docs.google.com/spreadsheets/d/1Ji8p3p_1JqUsMxE31mJqqztHf7LDx7mGMXh253azWpU/edit#gid=0 Also, do we have already have a minimum clang version

Re: Isolating metrics collection from master/agent slowness

2017-05-26 Thread Benjamin Mahler
This is great, I would love to see the metrics collection be low latency. Here is the response I gave last time, with the 4 options I think we should tackle: https://www.mail-archive.com/dev@mesos.apache.org/msg37113.html IMHO we should defer looking into the 5th option of sampling/caching

Re: Plan for upgrading protobuf==3.2.0 in Mesos

2017-05-26 Thread Benjamin Mahler
Thanks Zhitao and Anand! I've been looking forward to using arena allocation to improve performance. On Fri, May 26, 2017 at 6:01 PM, Qian Zhang wrote: > Thanks Anand and Zhitao! > > So I think we can remove the code like below, and switch to use the native > maps supported

Re: GPU Users -- Deprecation of GPU_RESOURCES capability

2017-05-26 Thread Benjamin Mahler
com> wrote: > Hi Benjamin, > > Thanks for getting back. Do you have an issue already filed for > the "reservations to multiple roles" story, or is it folded under another > JIRA story? > > > > On Fri, May 26, 2017 at 12:44 AM, Benjamin Mahler <bmah...@apac

Re: GPU Users -- Deprecation of GPU_RESOURCES capability

2017-05-26 Thread Benjamin Mahler
Thanks for the feedback! There have been some discussions for allowing reservations to multiple roles (or more generally, role expressions), which is essentially what you've suggested Zhitao. (However, note that what is provided by the GPU capability filtering is not quite this, it's actually

Re: Welcome Gilbert Song as a new committer and PMC member!

2017-05-26 Thread Benjamin Mahler
Thanks for all of your contributions to the project so far! It's been great having you in the community On Wed, May 24, 2017 at 10:32 AM, Jie Yu wrote: > Hi folks, > > I' happy to announce that the PMC has voted Gilbert Song as a new > committer and member of PMC for the

Re: [RESULT][VOTE] Release Apache Mesos 1.0.4 (rc2)

2017-05-25 Thread Benjamin Mahler
s] >> > <https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Rel >> ease/32/BUILDTOOL=autotools,COMPILER=gcc,CONFIGURATION=-- >> verbose,ENVIRONMENT=GLOG_v=1%20MESOS_VERBOSE=1,OS=ubuntu% >> 3A14.04,label_exp=(docker%7C%7CHadoop)&&(!ubuntu-us1)&&(!ub

Re: [RESULT][VOTE] Release Apache Mesos 1.1.2 (rc2)

2017-05-25 Thread Benjamin Mahler
I just was targeting a cherry pick and noticed the release isn't closed on JIRA (see 'Releasing the Version on JIRA' section of the release guide). I closed it and added a 1.1.3 version for folks to target for bug fixes. On Fri, May 19, 2017 at 5:36 AM, Alex Rukletsov wrote:

Re: [VOTE] Release Apache Mesos 1.0.4 (rc2)

2017-05-02 Thread Benjamin Mahler
+1 make check passes on macOS 10.12.4 with clang On Tue, May 2, 2017 at 12:04 PM, Vinod Kone wrote: > Hi all, > > > Please vote on releasing the following candidate as Apache Mesos 1.0.4. > > > 1.0.4 includes the following: > >

Re: documenting test expactations

2017-05-01 Thread Benjamin Mahler
Do you have some examples? Thinking through my own experience debugging tests, I tend to only get value out of EXPECT messages when they are providing information that I can't get access to from the line number / actual vs expected printing. (e.g. the value of a variable). If the EXPECT message

Re: Parallel test runner added

2017-04-28 Thread Benjamin Mahler
d you be able to present this as a demo somehow? maybe via a > screencast? > > MPark > > On Thu, Oct 13, 2016 at 6:33 PM, Benjamin Mahler <bmah...@apache.org> > wrote: > > > Great to see this Benjamin! > > > > Looking forward to seeing the parallel tes

Re: CPU affinity

2017-04-28 Thread Benjamin Mahler
Thanks for bringing this up Dmitry, I would also be happy to participate. Off the top of my head the following high level approaches have been brought up: (1) Categorize jobs into classes. E.g. LATENCY_SENSITIVE, THROUGHPUT_ORIENTED, etc. Essentially capturing the distinction between online vs

Re: RFC: constraining UPIDs in libprocess messages

2017-04-25 Thread Benjamin Mahler
optionally useful on top of IP enforcement? (3) What will libprocess do when it finds the IP doesn't match? Drop and log? On Thu, Apr 20, 2017 at 9:16 AM, James Peach <jor...@gmail.com> wrote: > > > On Apr 19, 2017, at 5:24 PM, Benjamin Mahler <bmah...@apache.org> wrote: >

Re: RFC: constraining UPIDs in libprocess messages

2017-04-19 Thread Benjamin Mahler
It's not obvious to me what all of the implications are. I feel we need a more comprehensive proposal here, can you do a small write up that shows you've thought through all the implications? E.g. how does this affect the use of proxies, multihomed hosts, our testing facilities for message

Re: Re : Re: protbuf to json not compatible

2017-03-27 Thread Benjamin Mahler
jects to do. On Sat, Mar 25, 2017 at 12:40 AM, Olivier Sallou <olivier.sal...@irisa.fr> wrote: > > - Benjamin Mahler <bmah...@apache.org> a écrit : > > James, I'm curious, do you know specifically what the incompatibility is? > > > > Olivier, if

Technical Debt

2017-03-24 Thread Benjamin Mahler
Hi devs, TLDR: I created a document with the help of other committers and contributors to collect technical debt items, categorized by the benefit we get if we fix them. If you'd like to contribute to any of these areas, please reach out! Also feel free to make suggestions / comments on the doc:

Re: protbuf to json not compatible

2017-03-24 Thread Benjamin Mahler
Tomek I think that patch also needs to address accepting strings for floating point fields: float, double. IMO, to avoid confusion, we want to get as close as possible to the proto3 specified mapping, which allows string inputs for all types of numeric fields:

Re: protbuf to json not compatible

2017-03-24 Thread Benjamin Mahler
James, I'm curious, do you know specifically what the incompatibility is? Olivier, if you're dealing with protobuf already and trying to send it to mesos, there's no need to use JSON. Unless you have a requirement to do so? There are some outstanding issues with our JSON<->Protobuf conversion,

Re: protbuf to json not compatible

2017-03-23 Thread Benjamin Mahler
+anand, vinod On Thu, Mar 23, 2017 at 2:09 AM, Tomek Janiszewski wrote: > I have a similar problem with protobuf and json. In my case numbers were > incorrectly unmarshaled. Here is an issue > https://issues.apache.org/jira/browse/MESOS-970 and review >

Re: protbuf to json not compatible

2017-03-23 Thread Benjamin Mahler
+gilbert On Thu, Mar 23, 2017 at 1:54 AM, Olivier Sallou wrote: > Hi, > > when transforming a protobug message to json with MessageToJson, the > json is not compatible with the json format expected by Mesos master. > > For example, for volumes it generates > > >

Re: MESOS-7233: Looking for shepherd

2017-03-16 Thread Benjamin Mahler
Thanks Tomek, I'm not very familiar with the code but I dug in and couldn't figure out how this is a backwards compatible change to make. Left a comment on the review. On Sat, Mar 11, 2017 at 2:24 AM, Tomek Janiszewski wrote: > Hi > > I'm looking for shepherd for MESOS-7233 —

Welcome Kevin Klues as a Mesos Committer and PMC member!

2017-03-01 Thread Benjamin Mahler
Hi all, Please welcome Kevin Klues as the newest committer and PMC member of the Apache Mesos project. Kevin has been an active contributor in the project for over a year, and in this time he made a number of contributions to the project: Nvidia GPU support [1], the containerization side of POD

Re: Preventing more than one framework to register as a particular role

2017-02-22 Thread Benjamin Mahler
To be a bit more clear, you can ensure that only one security principal can register frameworks under a particular role via the 'register_frameworks' ACLs: http://mesos.apache.org/documentation/latest/authorization/ Externally to mesos you would need to ensure that each security principal only

Re: Note about ".proto" files from Mesos 1.3.0+

2017-02-17 Thread Benjamin Mahler
Have you looked into requiring a 3.x protobuf compiler? The 3.x series compiler provides performance improvements via arenas for "syntax = proto2" IIUC: https://developers.google.com/protocol-buffers/docs/reference/arenas I filed a specific use case here:

Re: How to consistent handle default values for message types

2017-02-13 Thread Benjamin Mahler
The way I think about this is that if the field is semantically required then there can be a default. If not, then the optionality has meaning. For example, if there is always a notion of filtering, then having a default filter makes sense. But if the absence of a filter means no filtering occurs,

Re: Build failed in Jenkins: Mesos-Buildbot » autotools,gcc,--verbose,GLOG_v=1 MESOS_VERBOSE=1,ubuntu:14.04,(docker||Hadoop)&&(!ubuntu-us1)&&(!ubuntu-eu2) #3220

2017-02-04 Thread Benjamin Mahler
+neil Is this test flaky? I wasn't able to grab the logs since jenkins appears to be non-responsive at the moment. [ FAILED ] RegistrarTest.PruneUnreachable On Sat, Feb 4, 2017 at 3:03 AM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See

Re: mesos cpuset isolator has a resource estimator

2017-01-26 Thread Benjamin Mahler
Re: modules communicating in process I believe https://github.com/mesosphere/serenity communicates between its resource estimator and QoS controller modules. Might be helpful to look at how this project does it. On Sun, Jan 8, 2017 at 7:42 PM, ct clmsn wrote: > i've added a

Re: Welcome Neil Conway as Mesos Committer and PMC member!

2017-01-22 Thread Benjamin Mahler
Congrats and welcome! On Fri, Jan 20, 2017 at 11:03 PM, Vinod Kone wrote: > Hi folks, > > Please welcome Neil Conway as the newest committer and PMC member of the > Apache Mesos project. > > Neil has been an active contributor to Mesos for more than a year now. As > part

Re: Disallowing pre-1.0 Mesos agents

2017-01-20 Thread Benjamin Mahler
+1 Thanks for taking on the explicit rejection, much needed safety improvement. If we state that a Mesos 1.3.0 master will not support pre-1.0 agents, it seems to carry an implication that we supported 1.2 and 1.1 having pre-1.0 agents. While it might work, we should clarify for users per vinod's

[Design Doc] [RFC] Hierarchical Roles

2017-01-19 Thread Benjamin Mahler
As promised when publishing the multi-role framework design doc, here is the design doc for hierarchical roles. Design Doc: https://docs.google.com/document/d/1Ie2-6O400ayNXtRqipHq6_ CCQ4wOoLWzoqql3b0Y6HU/edit?usp=sharing JIRA Epic: https://issues.apache.org/jira/browse/MESOS-6375 Take a look

Re: [5/5] mesos git commit: Used `loop` in implementation of io::read and io::write.

2017-01-09 Thread Benjamin Mahler
Looks like there are some warnings for some of the loop changes: ../../../3rdparty/libprocess/src/io.cpp: In lambda function: ../../../3rdparty/libprocess/src/io.cpp:75:9: warning: control reaches end of non-void function [-Wreturn-type] }(); ^ mv -f .deps/libprocess_la-io.Tpo

Re: Metrics collection affected when libprocess queue builds up

2017-01-06 Thread Benjamin Mahler
and gauge change, and will fix them. Can you shepherd these? > > I'll do another pass of other gauge usage in allocator to see whether there > is easy low hanging fruits. > > Thanks. > > On Wed, Jan 4, 2017 at 6:28 PM, Benjamin Mahler <bmah...@apache.org> > wrote: > &

Re: 答复: Optimize libprocess performance

2017-01-05 Thread Benjamin Mahler
the network is not the > bottleneck, so the RPC layer is too heavy. > > -邮件原件- > 发件人: Benjamin Mahler [mailto:bmah...@apache.org] > 发送时间: 2017年1月5日 9:26 > 收件人: dev > 抄送: u...@mesos.apache.org > 主题: Re: Optimize libprocess performance > > Which area

Re: Metrics collection affected when libprocess queue builds up

2017-01-04 Thread Benjamin Mahler
r know which metrics are > dropped due to timeout? > > Also, it is not documented in > http://mesos.apache.org/documentation/latest/monitoring/. Should we send a > patch to update it? > > On Tue, Dec 27, 2016 at 6:12 PM, Benjamin Mahler <bmah...@apache.org> > wrote:

Re: Optimize libprocess performance

2017-01-04 Thread Benjamin Mahler
Which areas does the performance not meet your needs? There are a lot of aspects to libprocess that can be optimized, so it would be good to focus on each of your particular use cases via benchmarks, this allows us to have a shared way to profile and measure improvements. Copy elimination is one

Re: Metrics collection affected when libprocess queue builds up

2016-12-27 Thread Benjamin Mahler
The /metrics endpoint exposes a timeout parameter if you want to receive a response with all of the metrics that were available within the timeout, e.g. /metrics/snapshot.json?timeout=10secs I'd recommend using this when collecting metrics so that you can maintain visibility when a particular

Re: [VOTE] Release Apache Mesos 0.28.3 (rc1)

2016-12-01 Thread Benjamin Mahler
+1 (binding) On Wed, Nov 30, 2016 at 2:53 PM, Greg Mann wrote: > +1 (non-binding) > > Did `sudo make check` on CentOS 7. Aside from several > LinuxFilesystemIsolatorTests and two other flaky > tests, CgroupsAnyHierarchyWithFreezerTest.ROOT_CGROUPS_ > DestroyTracedProcess >

Re: Building on OS X 10.12

2016-12-01 Thread Benjamin Mahler
Here is the update: https://reviews.apache.org/r/54262/ On Thu, Dec 1, 2016 at 12:36 PM, Vinod Kone <vinodk...@apache.org> wrote: > Thanks! > > On Thu, Dec 1, 2016 at 12:34 PM, Benjamin Mahler <bmah...@apache.org> > wrote: > > > I ran into some compilation issue

Building on OS X 10.12

2016-12-01 Thread Benjamin Mahler
I ran into some compilation issues after upgrading to OS X 10.12.1, and was able to build successfully with Jie's help. The first thing was that I encountered a lot of these deprecation warnings: ../../../3rdparty/libprocess/../stout/include/stout/os/posix/su.hpp:241:9: warning: 'syscall' is

Re: [GitHub] mesos issue #190: Ensure curl is present on Ubuntu

2016-11-30 Thread Benjamin Mahler
Right now this fails at container launch time rather than initialization of the agent, seems like a bug? Also it would be great to avoid surfacing a stack trace for this. On Wed, Nov 30, 2016 at 5:58 AM, Alex Rukletsov wrote: > Curl is also a prerequisite for mesos-native

Re: [11/13] mesos git commit: Wired the libprocess code to use the streaming decoder.

2016-11-22 Thread Benjamin Mahler
The continuation needs to go through the process manager once again to obtain a reference to the process that we'd like to deliver the message to. One thing we could have done to avoid capturing 'this' is to grab the ProcessReference early and pass it through to the continuation. Unfortunately the

Re: [2/2] mesos git commit: Added MESOS-6142 to CHANGELOG for 1.1.1.

2016-11-09 Thread Benjamin Mahler
We wouldn't normally create the 1.1.x branch before 1.1.0 is released. If 1.1.0 doesn't go through this branch needs to be rebased and force pushed? On Tue, Nov 8, 2016 at 1:56 PM, wrote: > Added MESOS-6142 to CHANGELOG for 1.1.1. > > > Project:

Re: Test failures in Apache Jenkins

2016-11-03 Thread Benjamin Mahler
Hm.. these links are all broken, were you linking to jenkins logs directly? They get garbage collected rather quickly. On Mon, Oct 31, 2016 at 1:47 AM, Alex Rukletsov wrote: > Folks, > > I observe a lot of flaky tests in Apache Jenkins. They seem rather random > and not

Re: On increasing visibility into experimental features.

2016-11-03 Thread Benjamin Mahler
This sounds good to me. A couple thoughts. (1) Can we first define the meaning of "experimental" vs "stable" so that it's clear to users and ourselves? This definition should encompass when we want to call a feature experimental vs just building it and immediately calling it stable. For example,

[Design Doc] [RFC] Multi-Role Frameworks

2016-11-02 Thread Benjamin Mahler
We would like to revive the effort to better support multi-tenant frameworks by allowing frameworks to receive offers for multiple roles. An initial draft of an updated design doc based on the original design by Benjamin Bannier is available for review. Would love to get feedback on this, feel

Re: Design for Restartable Tasks

2016-10-26 Thread Benjamin Mahler
Thanks for publishing this! Saw some tickets being created and was wondering where this email was.. :) The higher level thing that strikes me is that I think the notion of a task restart policy should be managed by the executor (i.e. the executor restarts the task based on the policy). This is

Re: Features missing in the webui

2016-10-21 Thread Benjamin Mahler
to the UI. > Maintenance of nodes will be presented in a table. Code is on github but > need some tweaks and tests with large maintenance json. I'll prepare patch > shortly (when github DDoS will be over). > https://issues.apache.org/jira/browse/MESOS-6443 > > pt., 21.10.2016 o 20:30 użytk

Re: encounter “Decoder error while receiving” error when using libprocess send, receive api

2016-10-17 Thread Benjamin Mahler
Hi Su Teng, Glad to hear you're making use of libprocess, be aware that we currently bundle it in the mesos repository and development occurs within the mesos project at the current time. This issue sounds like https://issues.apache.org/jira/browse/MESOS-5943 Are you obtaining libprocess from

Re: Parallel test runner added

2016-10-13 Thread Benjamin Mahler
Great to see this Benjamin! Looking forward to seeing the parallel test runner turn green, I'll help file tickets under the epic (I see there are a lot of test failures for me). Once we clear the issues and turn it green, shall we make this the default? I would be in favor of that. Ben On Thu,

Re: Need a shepherd for MESOS-5384

2016-10-11 Thread Benjamin Mahler
Sorry for the delay Kris, I replied on the ticket. On Sat, Sep 3, 2016 at 6:09 AM, Kris Paprocki < kris.paprocki.mesos.mail...@gmail.com> wrote: > Can someone help to shepherd this ticket? > > Thanks and best regards, > > Chris >

Re: mesos issue #5464: Added a completed executors history configure flag in Agent.

2016-10-11 Thread Benjamin Mahler
Hi Lijun, Apologies that this slipped through the cracks! I've gone over the patch and committed it. Nice patch, thanks! Thanks to those who reviewed it as well. Ben On Wed, Aug 31, 2016 at 8:39 PM, Lijun Tang wrote: > Hi Team, > > Can I get a committer to take a look

Re: mesos per task monitoring/metrics

2016-08-23 Thread Benjamin Mahler
+jie Hi Olivier, Could you tell us what you're trying to do at a high level? I'm not familiar with cAdvisor, are you trying to generate a link to the cAdvisor page for a particular container? Ben On Tue, Aug 23, 2016 at 7:53 AM, Olivier Sallou wrote: > > > On

Re: Looking for shepherd for MESOS-4638

2016-08-19 Thread Benjamin Mahler
For posterity, and for those keeping track of shepherd requests, Yan shepherded. Thanks Yan! On Thursday, August 11, 2016, Zhitao Li wrote: > Our modules requires conditional compile because we need to make sure we > can cross version boundary during upgrade cycles, so

Re: Need a shepherd for the PR to add the etcd-based Mesos master detactor in mesos-go

2016-08-16 Thread Benjamin Mahler
Hi Yongqiao, mesos-go is developed outside the Apache Mesos project. Ben On Mon, Aug 15, 2016 at 11:59 PM, Yongqiao Wang wrote: > Hi Folks, > > As we know, etcd-based Mesos master contender module is > developing now, in order to let some Mesos framework wrote with GO

Re: 1.0.1 release

2016-08-09 Thread Benjamin Mahler
All of the issues I've been shepherding have been fixed. The only one I see remaining is this one, but doesn't look like a blocking issue: https://issues.apache.org/jira/browse/MESOS-5985 Anything else that needs to go in? On Mon, Aug 1, 2016 at 4:19 PM, Vinod Kone wrote:

Re: Shepherd for MESOS-5929

2016-08-05 Thread Benjamin Mahler
I pushed your patch, thanks! On Fri, Aug 5, 2016 at 12:28 PM, Charles Allen < charles.al...@metamarkets.com> wrote: > https://reviews.apache.org/r/50862/ which is a proposed fix for MESOS-5929 > needs a shepherd. Is anyone able to do that? >

Re: Rate-limiting agent removal w/ PARTITION_AWARE

2016-07-28 Thread Benjamin Mahler
It seems to me that these particular flags are not applicable for PARTITION_AWARE frameworks, since there is no removal occurring. For old frameworks, they still act as if removal is occurring and so these flags provide the backwards compatibility by rate limiting the shutting down of

Re: [VOTE] Release Apache Mesos 1.0.0 (rc4)

2016-07-26 Thread Benjamin Mahler
+1 (binding) OS X 10.11.6 ./configure --disable-python --disable-java make check On Tue, Jul 26, 2016 at 10:24 AM, Greg Mann wrote: > +1 (non-binding) > > * Ran `sudo make distcheck` successfully on CentOS 7.1 with only one test > failure: ExamplesTest.PythonFramework fails

Fwd: Review Request 49943: Made vector reserve some spaces for allocator benchmark test.

2016-07-18 Thread Benjamin Mahler
iang Yan Xu On July 14th, 2016, 8:14 p.m. PDT, Guangya Liu wrote: Review request for mesos, Benjamin Mahler, Jie Yu, and Jiang Yan Xu. By Guangya Liu. *Updated July 14, 2016, 8:14 p.m.* *Repository: * mesos Description Updated HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave to call vect

Helper Functions and Code Readability

2016-07-15 Thread Benjamin Mahler
I was reviewing code and noticed the following helper in the allocator benchmarks [1]: // This returns a `Labels` that has 12 key-value pairs, which should // be more than we expect most frameworks to use in practice. We // ensure that the first 11 key-value pairs are equal, which

Fwd: [jira] [Created] (MESOS-5817) Port libprocess process_tests.cpp

2016-07-11 Thread Benjamin Mahler
This doesn't look like a "Bug" (there are a bunch of other tickets that are misclassified). Please be sure to set the appropriate "issue type". :) Can you go through your tickets and update the types? -- Forwarded message -- From: Alex Clemmer (JIRA) Date: Fri,

Re: Patch for website

2016-07-11 Thread Benjamin Mahler
I just ran a website update, you should see it now if you force a refresh. On Mon, Jul 11, 2016 at 2:26 PM, Tomek Janiszewski wrote: > Page need to be manually generated and published. > > pon., 11.07.2016, 22:59 użytkownik Rich Bowen napisał: > > > > > >

Re: MESOS-5731 Add metric types to GetMetrics v1 api

2016-07-11 Thread Benjamin Mahler
Have you considered introducing 'histograms' rather than 'timers'? Our Timers are just a special case of a histogram. For example, you could have a histogram of response sizes. On Fri, Jul 8, 2016 at 3:32 PM, Tuan-Anh Hoang-Vu wrote: > Hi all, > > I've finished implementing

Re: [GitHub] mesos pull request #130: Avoid 'Permission denied' error with 'sudo cat >'

2016-07-07 Thread Benjamin Mahler
+Kevin Kevin, this looks like a change to your patch below, does his change look good to you? commit dae2c0667c1be913d08cff57717764c6ce7a45d9 Author: Kevin Klues Date: Thu Dec 17 06:21:02 2015 +0100 Wrote cmd to create WANdiscoSVN file for centos. Previously we

Re: Request to add myself to Mesos contributors

2016-07-07 Thread Benjamin Mahler
Welcome! Can you tell us more about how you're using Mesos? I've added you as a contributor in JIRA. Please send a PR or review request to get yourself added to the list of contributors: https://github.com/apache/mesos/blob/master/docs/contributors.yaml On Wed, Jul 6, 2016 at 2:31 PM, Sabarish

Re: MESOS-4694

2016-07-06 Thread Benjamin Mahler
+implementer and shepherd of SUPPRESS Is there any reason we didn't already just "deactivate" frameworks that were suppressing offers? That seems to be the natural implementation, performance aside, because the meaning of "deactivated" is: not being sent any offers. The patch you posted seems to

Re: Review Request 49223: Enhance value parsing.

2016-07-06 Thread Benjamin Mahler
os ReviewBot > > On July 6th, 2016, 2:40 a.m. UTC, Klaus Ma wrote: > Review request for mesos and Benjamin Mahler. > By Klaus Ma. > > *Updated July 6, 2016, 2:40 a.m.* > *Bugs: * MESOS-5739 <https://issues.apache.org/jira/browse/MESOS-5739> > *Repository: * mesos > Descr

Re: Overloading and function names

2016-07-06 Thread Benjamin Mahler
.@gmail.com> wrote: > On Sun, Jul 3, 2016 at 9:10 PM, Benjamin Mahler <bmah...@apache.org> > wrote: > > To clarify, are you ok with the removeSlave example? It seems to fit your > > criteria. > > I think `removeSlave` is poorly named, for similar reasons -- I just >

Re: Overloading and function names

2016-07-03 Thread Benjamin Mahler
To clarify, are you ok with the removeSlave example? It seems to fit your criteria. Usually with this kind of email we need concrete suggestions for improvement. First though I wanted to improve some issues around naming and the descriptions you've used in the update example to avoid conflating

Re: Pull request [apache/mesos] Added self to contributors.

2016-07-01 Thread Benjamin Mahler
Pushed by AlexR. It would be nice if the PR bot replied to these if they are closed. On Thu, Jun 30, 2016 at 8:46 PM, wrote: > Added self to contributors. > By yanyanhu > Added Yanyan Hu to contributors list. > June 30, 2016 at 08:42PM > via GitHub http://ift.tt/299dAft >

Re: Two important tickets for improving documentation

2016-06-30 Thread Benjamin Mahler
Looks like Vinod will shepherd, thanks Vinod! On Tue, Jun 28, 2016 at 4:38 PM, Timothy Anderegg < timothy.ander...@gmail.com> wrote: > I picked it up as part of the website working group, but don't have a > shepherd yet. > > On Tue, Jun 28, 2016, 7:06 PM Benjamin Mahler &

Re: Pull request [apache/mesos] docs: frameworks list: use correct URL for storm-mesos framework

2016-06-30 Thread Benjamin Mahler
Pushed. On Thu, Jun 30, 2016 at 4:46 PM, wrote: > docs: frameworks list: use correct URL for storm-mesos framework > By erikdw > June 30, 2016 at 04:33PM > via GitHub http://ift.tt/2992b37 >

Re: Pull request [apache/mesos] Add Cook to frameworks.md

2016-06-30 Thread Benjamin Mahler
Pushed. On Thu, Jun 30, 2016 at 4:46 PM, wrote: > Add Cook to frameworks.md > By dgrnbrg > This adds the Cook framework to the framework list. > June 30, 2016 at 04:39PM > via GitHub http://ift.tt/2992mew >

Re: Two important tickets for improving documentation

2016-06-28 Thread Benjamin Mahler
last issues to resolve. > > On Mon, Jun 27, 2016, 11:20 PM Benjamin Mahler <bmah...@apache.org> wrote: > > > Just wanted to highlight two tickets that would be of great help to the > > community. > > > > (1) The first is to publish documentation on the website for ea

Two important tickets for improving documentation

2016-06-27 Thread Benjamin Mahler
Just wanted to highlight two tickets that would be of great help to the community. (1) The first is to publish documentation on the website for each release. We currently publish periodically off of master, and so it's a pain for users because the documentation does not reflect the version they

Re: Extend HTTP Endpoint to allow querying for metric types

2016-06-27 Thread Benjamin Mahler
ils about the metrics system, but the collection client > required me to specify metric type, probably for optimization purpose. It > accepts 3 different types: counter, gauge and timer > > On Mon, Jun 27, 2016 at 5:09 PM, Benjamin Mahler <bmah...@apache.org> > wrote: > >

Re: Extend HTTP Endpoint to allow querying for metric types

2016-06-27 Thread Benjamin Mahler
It's worth doing because it has come up before [1] [2]. For our own education, in your case why is the metrics collection system interested in the type? Is it for optimization? Which metrics collection system are you using? What are the types that the metrics collection system understands? The

Re: [VOTE] Release Apache Mesos 0.26.2 (rc1)

2016-06-22 Thread Benjamin Mahler
+1 (binding) Make check on OS X 10.11.5. On Mon, Jun 20, 2016 at 5:10 PM, Kapil Arya wrote: > +1 (binding) Internal CI build. > > Here is a link to the deb/rpm packages: > > http://open.mesosphere.com/downloads/mesos-rc/#apache-mesos-0.26.2-rc1 > > > > On Mon, Jun 20, 2016

Re: Mesos CLI

2016-06-21 Thread Benjamin Mahler
+1 for keeping it in the repo. We can establish maintainers for the CLI to ensure that it can maintain a reasonable update cadence. Note that we haven't done this well for the webui and CLI, so we need to make sure we do it better this time around. If the architecture allows for easy integration

GPU Support: Library Injection

2016-06-21 Thread Benjamin Mahler
Moving this to a new thread (see some context below). It may be worth exploring adding a generic mechanism for doing label-based injection of volumes: if a container is tagged with a particular label, we will inject a particular volume into the container. For Nvidia GPU containers, the operator

Re: Multiple framework DRF tuning

2016-06-16 Thread Benjamin Mahler
t;dev@mesos.apache.org>; meghdoot > bhattacharya <meghdoo...@yahoo.com> > *Cc:* Benjamin Mahler <bmah...@apache.org> > *Sent:* Thursday, June 16, 2016 4:43 AM > *Subject:* Re: Multiple framework DRF tuning > > Hey Meghdoot, > > Mesos-4687 does indeed fix

Re: [Compatibility] More strict parsing of ranges, e.g. port of resources

2016-06-15 Thread Benjamin Mahler
Sounds OK to me if there are no objections, since it should not be a difficult adjustment for users to make and users can use the more expressive JSON format for resources already. (e.g. https://github.com/dcos/dcos/blob/1.7-open/gen/dcos-config.yaml#L95) Also, please document this in the

Re: Master configuration in the registry

2016-06-13 Thread Benjamin Mahler
> is largely immutable. > > > > Another distinction is that some configuration flags control behavior > > that doesn't need to be consistent between master replicas (e.g., > > "--ip", "--port", "--advertise-ip", "--advertise-port&q

[GPU] [Allocation] "Scarce" Resource Allocation

2016-06-10 Thread Benjamin Mahler
I wanted to start a discussion about the allocation of "scarce" resources. "Scarce" in this context means resources that are not present on every machine. GPUs are the first example of a scarce resource that we support as a known resource type. Consider the behavior when there are the following

Re: Welcome Anand and Joseph as new committers!

2016-06-10 Thread Benjamin Mahler
Welcome Anand and Joseph, thanks for all of your contributions! Looking forward to seeing your ongoing positive influences on the community and the project, let's build great software! On Thu, Jun 9, 2016 at 2:00 PM, Vinod Kone wrote: > Hi folks, > > I'm happy to announce

Master configuration in the registry

2016-06-09 Thread Benjamin Mahler
I'm curious to hear thoughts on the distinction between using flags and persisting in the registry for master configuration. This topic had come up in a discussion and our current choices are intuitive but the criteria were not immediately obvious. Two cases seem interesting to me: (1) Quota.

Re: [VOTE] Release Apache Mesos 0.27.3 (rc1)

2016-06-08 Thread Benjamin Mahler
+1 (binding) All tests pass on OS X with libev. On Tue, Jun 7, 2016 at 11:48 PM, Jörg Schad wrote: > +1 (Non-Binding) > (sudo) make check on OSX + Update Test Script from 27.2 > > Two test failures (FetcherCacheTest.LocalUncachedExtract and >

Re: Mesos 0.24.1 on Raspberry Pi 3

2016-06-06 Thread Benjamin Mahler
Cool stuff Andrew, thanks for sharing! On Thu, Jun 2, 2016 at 11:50 AM, Andrew Spyker wrote: > FYI, based on the work others have done in the past, Netflix was able to > get Mesos agent building and running on Raspberry Pi natively and under > Docker containers.

Re: [C++11] Please use `nullptr`!

2016-06-06 Thread Benjamin Mahler
Thanks Tomasz! Does the style checker now catch NULL introductions? On Mon, Jun 6, 2016 at 2:12 PM, Michael Park wrote: > Hello, > > Tomasz Janiszewski kindly started the initiative on the migration to > `nullptr`, and we have closed MESOS-3243 >

Re: Mesos Coverity Scan

2016-06-05 Thread Benjamin Mahler
+jörg On Fri, May 20, 2016 at 1:40 PM, Benjamin Mahler <bmah...@apache.org> wrote: > Any update on getting the coverity scan up and running? > > It used to send us new defects as commits land, and that helped us catch a > number of bugs, so it would be great to see it revived!

Re: [REVIEW PROCESS] Proposal for new review process working group

2016-05-23 Thread Benjamin Mahler
Thanks Kevin! I would love to see improvements to our current system of subcomponent maintainers, so I would be happy to participate. What does it mean to be added to the working group now that we use email [TOPIC] prefixes? On Fri, May 20, 2016 at 10:59 AM, Kevin Klues

Re: mesos git commit: Updated quota endpoint help.

2016-05-23 Thread Benjamin Mahler
+kevin for context When we approached this problem there were a few routes we could take. One approach we were leaning towards was to allow the help information to be specified directly in markdown rather than in C++. Markdown would be the only source of help information, and the C++ code calling

Re: Mesos Coverity Scan

2016-05-20 Thread Benjamin Mahler
Any update on getting the coverity scan up and running? It used to send us new defects as commits land, and that helped us catch a number of bugs, so it would be great to see it revived! On Thu, Mar 31, 2016 at 12:36 AM, Jörg Schad wrote: > Hi, > just a short update on why

Re: Looking for Shepherd for MESOS-2201

2016-05-13 Thread Benjamin Mahler
+alexr It would be helpful if the shepherd replies to the list when they get involved. Hard to tell from the mailing list that this was picked up. On Tue, May 10, 2016 at 12:46 AM, Tomek Janiszewski wrote: > Hi > > Can anyone help shepherd MESOS-2201 – Fixed replica log

Re: mesos git commit: Fixed a head-of-line blocking bug in libevent SSL socket.

2016-05-13 Thread Benjamin Mahler
Here is a test that catches the issue: https://reviews.apache.org/r/47362/ On Thu, May 12, 2016 at 5:34 PM, Benjamin Mahler <bmah...@apache.org> wrote: > Yes definitely! We would want to test that a connection without any data > sent does not block subsequent requests when SS

Re: mesos git commit: Replaced CHECK with CHECK_READY.

2016-05-13 Thread Benjamin Mahler
t; > However, do we still want to separate different sorts of cleanups as > well or > > squash them together to avoid the churn? If I search for a bug and see a > > style fix patch, I simply skip. I'd rather prefer to have one single > patch > > for all style fixes than a tiny patch f

<    1   2   3   4   5   6   7   8   9   10   >