Re: Looking for shepherd HealthCheck flaky test cases

2016-05-13 Thread Benjamin Mahler
Thanks for looking into these, I gave reviews on: https://reviews.apache.org/r/47089/ https://reviews.apache.org/r/46307/ I couldn't tell why this change was being made, can you describe why in the review description? https://reviews.apache.org/r/47088/ Just as an aside, the health check test

Re: Simple question about slave<->master latency?

2016-05-12 Thread Benjamin Mahler
Could you tell us more about what you would do with this information? On Wed, May 11, 2016 at 9:39 AM, James Vanns wrote: > Sorry for cross-posting, I was meant to send this to the dev list > but sent it to the user list instead by accident! > > Is the latency (perhaps the

Re: mesos git commit: Fixed a head-of-line blocking bug in libevent SSL socket.

2016-05-12 Thread Benjamin Mahler
2 > > > > > > Project: http://git-wip-us.apache.org/repos/asf/mesos/repo > > Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/28c085fc > > Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/28c085fc > > Diff: http://git-wip-us.apache.org/repos/

Re: mesos git commit: Replaced CHECK with CHECK_READY.

2016-05-07 Thread Benjamin Mahler
Hm.. any reason that unrelated headers were touched and the using statement was removed in this patch? My concern with mixing unrelated changes within a single patch is that patches become less precise. If one reads the patch there is additional overhead in understanding what is related to the

Re: stable remote branches

2016-05-04 Thread Benjamin Mahler
Jie I've highlighted in the doc the backports that remain from the initial search of fix versions. Let me know if you'd like any help! On Mon, Apr 25, 2016 at 7:23 PM, Benjamin Mahler <bmah...@apache.org> wrote: > +user as an FYI > > Going forward we'll push directly to

Re: Looking for Shepherd for MESOS-5263

2016-04-26 Thread Benjamin Mahler
Looks like Vinod shipped MESOS-5121. I just shipped MESOS-5263 following the same approach. Haosdent mentioned some cleanups are possible here so please keep us posted if the cleanups are available! On Sun, Apr 24, 2016 at 1:34 PM, Tomek Janiszewski wrote: > Hi, > > Can

Re: stable remote branches

2016-04-25 Thread Benjamin Mahler
+user as an FYI Going forward we'll push directly to these branches as backport decisions are made. Since 0.28.x, 0.27.x, and 0.26.x have just been created, here is what was already marked for these versions, that we'll have to cherry-pick: The following need to be cherry-picked for 0.28.2:

Re: Shepherd for MESOS-4279 (Graceful restart of docker task)

2016-04-22 Thread Benjamin Mahler
If any bugs were discovered in https://issues.apache.org/jira/browse/MESOS-4279, could we file new tickets for them? It would be nice to distinguish the investigation/triaging of user reports from the bugs that we end up finding in mesos. If I were to see the following ticket (e.g. in the

Re: How to record time elapsed of a set of async functions operation?

2016-04-22 Thread Benjamin Mahler
Here's an example of using Stopwatch for this: Future f = Nothing(); Stopwatch s; s.start(); f.then(a) .then(b) .then(c) .onAny([s](){ cout << "a->b->c took: " << s.elapsed() << endl; }); On Fri, Apr 22, 2016 at 3:16 AM, Jian Qiu wrote: > Hi folks, > > We are

Re: On launching command tasks

2016-04-08 Thread Benjamin Mahler
> > Mesos expects the first argument to be the same > as the command itself [1] To be precise, what does "expect" mean here? Do we actually have code in mesos with this expectation? Or are you just saying that we require CommandInfo.arguments to map directly to exec's 'args'? Have you

Re: mesos git commit: Add curl_easy_cleanup when fopen is failed.

2016-04-08 Thread Benjamin Mahler
Looks like this was a file descriptor leak? Seems like we should have a bug to track this. AFAICT it's not a bad leak since it only affects the fetcher, and the fetcher is short-lived? $ grep -R net::download 3rdparty src 3rdparty/libprocess/3rdparty/stout/README.md:A collection of utilities for

Re: Typed Error Handling in Mesos

2016-04-07 Thread Benjamin Mahler
Long overdue, thanks Michael! Have you considered how composition will work with typed errors? I recall in the past when we looked into this, Future chaining was interesting: f1 = []() -> Future { ... }; f2 = []() -> Future { ... }; f3 = []() -> Future { ... };

Re: Ordering guarantee of future.onAny callbacks

2016-04-06 Thread Benjamin Mahler
ls in parallel > in the future (if we ever need to) outweigh the inconsistency in the API > regarding ordered execution of certain chains (At least as the API is > currently designed). > > — > *Joris Van Remoortere* > Mesosphere > > On Wed, Mar 30, 2016 at 12:25 AM, Benjam

Re: [VOTE] Release Apache Mesos 0.26.1 (rc4)

2016-04-06 Thread Benjamin Mahler
+1 (binding) The following passes on OS X: $ ./configure CC=clang CXX=clang++ --disable-python --disable-java $ make check On Tue, Apr 5, 2016 at 11:41 PM, Michael Park wrote: > Hi all, > > Please vote on releasing the following candidate as Apache Mesos 0.26.1. > > > 0.26.1

Re: [VOTE] Release Apache Mesos 0.25.1 (rc4)

2016-04-06 Thread Benjamin Mahler
+1 (binding) The following passes on OS X: $ ./configure CC=clang CXX=clang++ --disable-python --disable-java $ make check On Tue, Apr 5, 2016 at 11:41 PM, Michael Park wrote: > s/No changes from rc4/No changes from rc3/ > s/New fixes in rc5/New fixes in rc4/ > > On 5 April

Re: [VOTE] Release Apache Mesos 0.24.2 (rc5)

2016-04-06 Thread Benjamin Mahler
+1 (binding) The following passes on OS X: $ ./configure CC=clang CXX=clang++ --disable-python --disable-java $ make check On Tue, Apr 5, 2016 at 10:51 PM, Michael Park wrote: > Hi all, > > Please vote on releasing the following candidate as Apache Mesos 0.24.2. > > > 0.24.2

Re: [VOTE] Release Apache Mesos 0.25.1 (rc3)

2016-03-31 Thread Benjamin Mahler
make check fails on OS X. Looks like we're missing the following: commit 363b0b059bdc7742b2258a33ebfe430fd03f4311 Author: Kapil Arya Date: Mon Jan 25 00:41:17 2016 -0500 Fixed non-linux build involving glog drop_log_meory flag. The variable

Re: [VOTE] Release Apache Mesos 0.24.2 (rc4)

2016-03-31 Thread Benjamin Mahler
I'm seeing the following on OS X for the three RCs that were sent out: $ ./configure CC=clang CXX=clang++ --disable-python --disable-java ... $ make check -j7 ... ./mesos-tests dyld: Symbol not found: __ZN3fLB21FLAGS_drop_log_memoryE Referenced from:

Re: [1/6] mesos git commit: Fixed a memory leak in the scheduler driver.

2016-03-30 Thread Benjamin Mahler
On Wed, Mar 30, 2016 at 2:17 PM, Neil Conway <neil.con...@gmail.com> wrote: > On Wed, Mar 30, 2016 at 4:57 PM, Benjamin Mahler <bmah...@apache.org> > wrote: > > Yikes! (3) being not true to me means that I needed non-local reasoning > to > > determine the opti

Re: [1/6] mesos git commit: Fixed a memory leak in the scheduler driver.

2016-03-30 Thread Benjamin Mahler
Yikes! (3) being not true to me means that I needed non-local reasoning to determine the optionality. I reason about symmetric operations like new/delete in a similar way to other symmetric operations like open/close. Even though close(-1) returns EBADF and doesn't do something bad, it's

Re: [1/6] mesos git commit: Fixed a memory leak in the scheduler driver.

2016-03-30 Thread Benjamin Mahler
I'm not sure the null check was in place for the safety of deletion so much as to make the code easier to reason about: if (process != NULL) { terminate(process); wait(process); delete process; } if (credential != NULL) { delete credential; } delete latch; Here, (1)

Re: Ordering guarantee of future.onAny callbacks

2016-03-29 Thread Benjamin Mahler
I don't believe we have made this assumption often, and I'm not convinced it's a problem in Future. Why would one make such an assumption in the first place? It seems brittle, especially when callbacks are executed in deferred contexts that Future is unaware of. It also limits our flexibility

Re: Build Mesos on Windows

2016-03-25 Thread Benjamin Mahler
+ Alex Clemmer On Thu, Mar 24, 2016 at 7:50 PM, tommy xiao wrote: > i remember microsoft team invovled in this case, but not found any update > on it? anyone can update news? > > 2016-03-25 6:08 GMT+08:00 Juan Larriba : > > > Hi all, > > > > I have been

Re: Event bus for Mesos

2016-03-25 Thread Benjamin Mahler
I think the consensus is that event streaming will come at some point. The status is that we opted to focus instead on making some significant performance improvements to the json endpoints and providing finer-grained endpoints, since these were a much simpler effort. The need at the time was

Re: [VOTE] Release Apache Mesos 0.24.2 (rc2)

2016-03-23 Thread Benjamin Mahler
Also, I tagged https://issues.apache.org/jira/browse/MESOS-5021 with a fix version of 0.24.2. Can you include it? On Sat, Mar 19, 2016 at 6:30 AM, Michael Park wrote: > As there are insufficient votes on this rc along with a request > from Evan Krall to include additional

Re: [VOTE] Release Apache Mesos 0.26.1 (rc2)

2016-03-23 Thread Benjamin Mahler
Also, I tagged https://issues.apache.org/jira/browse/MESOS-5021 with a fix version of 0.26.1. Can you include it? On Mon, Mar 21, 2016 at 1:59 PM, Benjamin Mahler <bmah...@apache.org> wrote: > Yes it has existed for a long time but has only been discovered recently. &g

Re: 0.28.1

2016-03-23 Thread Benjamin Mahler
Thanks Jie, I've added a fix version of 0.28.1 to: https://issues.apache.org/jira/browse/MESOS-5021 On Fri, Mar 18, 2016 at 5:52 PM, Jie Yu wrote: > Hi, > > We recently noticed two bugs >

Re: [jira] [Created] (MESOS-4948) MasterMaintenanceTest.InverseOffers is flaky

2016-03-22 Thread Benjamin Mahler
Sorry, I didn't realize the summary of this ticket had changed since this email was generated, and the plan is now to migrate the test to the new scheduler library. On Mon, Mar 21, 2016 at 11:21 PM, Benjamin Mahler <bmah...@apache.org> wrote: > +joseph > > Have you seen this? >

Re: [jira] [Created] (MESOS-4948) MasterMaintenanceTest.InverseOffers is flaky

2016-03-22 Thread Benjamin Mahler
+joseph Have you seen this? On Tue, Mar 15, 2016 at 7:13 AM, Greg Mann (JIRA) wrote: > Greg Mann created MESOS-4948: > > > Summary: MasterMaintenanceTest.InverseOffers is flaky > Key: MESOS-4948 >

Re: [jira] [Created] (MESOS-4635) CoordinatorTest.AppendDiscarded is flaky

2016-03-22 Thread Benjamin Mahler
+jie Jie, have you seen this? On Wed, Feb 10, 2016 at 7:46 AM, Greg Mann (JIRA) wrote: > Greg Mann created MESOS-4635: > > > Summary: CoordinatorTest.AppendDiscarded is flaky > Key: MESOS-4635 >

Filing bugs and flaky test tickets

2016-03-22 Thread Benjamin Mahler
Folks, Our JIRA volume is very high and I'm finding that important bugs and flaky tests are getting lost in the noise. When filing a bug or a flaky test ticket as a dev in the project, it's critical to 'git blame' the code to determine who is responsible for it, in order to notify them of the

Re: [jira] [Updated] (MESOS-4984) MasterTest.SlavesEndpointTwoSlaves is flaky

2016-03-22 Thread Benjamin Mahler
I'm finding these are getting lost in the noise, it would be great when filing test issue tickets to 'git blame' the code and figure out who to notify to fix the test. Could you do that here? On Fri, Mar 18, 2016 at 3:55 PM, Neil Conway (JIRA) wrote: > > [ >

Usage of protobuf 'enum' fields

2016-03-21 Thread Benjamin Mahler
Hi folks, I wanted to surface the following ticket to our attention: https://issues.apache.org/jira/browse/MESOS-4997 The issue is that when enum fields are deserialized, unknown enum values are _stripped_. This means that if an enum field is 'required' and a new value is added, old clients

Re: [jira] [Created] (MESOS-4993) FetcherTest.ExtractZipFile assumes `unzip` is installed

2016-03-21 Thread Benjamin Mahler
+jie, Tomasz Looks like this new test needs a filter. Can one of you follow up with a fix? On Mon, Mar 21, 2016 at 12:51 PM, Neil Conway (JIRA) wrote: > Neil Conway created MESOS-4993: > -- > > Summary: FetcherTest.ExtractZipFile

Re: [VOTE] Release Apache Mesos 0.26.1 (rc2)

2016-03-21 Thread Benjamin Mahler
a little > as to what the consequences are? > > Thanks! > > MPark > > On 18 March 2016 at 16:20, Benjamin Mahler <bmah...@apache.org> wrote: > >> These are be captured under: >> https://issues.apache.org/jira/browse/MESOS-4979 >> >> On

Re: [RESULT][VOTE] Release Apache Mesos 0.27.2 (rc1)

2016-03-21 Thread Benjamin Mahler
A single branch for a release seems brittle because it assumes that RC tag N shares the same lineage as RC tag N-1. This is mostly true, but not always. The branching approach that would mirror how I've put together releases would be to have a branch for each RC. The RC N branch is usually on top

Re: RFC: RevocableInfo Changes

2016-03-21 Thread Benjamin Mahler
your comments if any for those two >>> names or even if you want to propose a new name here. >>> >> >>> >> message RevocableInfo { >>> >> message ThrottleInfo {} >>> >> >>> >> // If set, indicates that the resour

Re: [proposal] MESOS-4610: MasterContender/MasterDetector should be loadable as modules

2016-03-21 Thread Benjamin Mahler
+Yan On Mon, Mar 21, 2016 at 10:28 AM, Anurag Singh < anurag.prakash.si...@gmail.com> wrote: > Joseph's suggestion is that since Ben Hindman may not have enough time to > shepherd this issue, we should seek another one. Would anyone here be able > to shepherd

Re: [VOTE] Release Apache Mesos 0.26.1 (rc2)

2016-03-19 Thread Benjamin Mahler
Thanks for the hard work! Do we need to backport the rmdir fixes on the outstanding release candidates? commit 5278e5cc50544ed7af28b15a1acd2b2e96a15a47 Author: Jojy Varghese Date: Tue Mar 15 17:12:01 2016 -0700 Added support for FTS_SLNONE in rmdir. Review:

Re: [VOTE] Release Apache Mesos 0.26.1 (rc2)

2016-03-19 Thread Benjamin Mahler
These are be captured under: https://issues.apache.org/jira/browse/MESOS-4979 On Thu, Mar 17, 2016 at 5:04 PM, Benjamin Mahler <bmah...@apache.org> wrote: > Thanks for the hard work! Do we need to backport the rmdir fixes on the > outstanding release candidates

Re: Negative durations

2016-03-16 Thread Benjamin Mahler
On Fri, Mar 11, 2016 at 9:22 AM, haosdent wrote: > I saw we use Seconds(-1) represent infinity in current code. > > ``` > ./3rdparty/libprocess/include/process/future.hpp: bool await(const > Duration& duration = Seconds(-1)) const; >

Re: RFC: RevocableInfo Changes

2016-03-14 Thread Benjamin Mahler
t; > > > > > > > > > I think that currently and even in the near future, the > > > __ThrottleInfo__ > > > > > will only be used by the usage oversubscriptions and the > > > oversubscription > > > > > for allocator (Both quota and reservation

RFC: RevocableInfo Changes

2016-03-11 Thread Benjamin Mahler
Hey folks, In the resource allocation working group we've been looking into a few projects that will make the allocator able to offer out resources as revocable. For example: -We'll want to eventually allocate resources as revocable _by default_, only allowing non-revocable when there are

Re: [3/3] mesos git commit: New python lib with only the executor driver.

2016-03-11 Thread Benjamin Mahler
+vinod This breaks the build for me on OS X, it appears this line is the culprit: EXTRA_LINK_ARGS = ['-Wl,--as-needed'] This leads to the following: clang++ -bundle -undefined dynamic_lookup -arch x86_64 -arch i386 -Wl,-F. -L/usr/local/opt/subversion/lib -O2 -O2 -Wno-unused-local-typedef

Re: Extend PerfEventIsolator to support all possible Perf Events.

2016-03-07 Thread Benjamin Mahler
Why the dynamic map rather than following the existing convention in PerfStatistics? Seems inconsistent. On Monday, February 22, 2016, Bartłomiej Płotka wrote: > Hi, > > We want to introduce the support in PerfEventIsolator for all possible* > perf events*. > I'd love to

Re: Enable compiler optimization by default?

2016-03-07 Thread Benjamin Mahler
I won't -1 but please see below before proceeding. This was the original behavior and this will bring it full circle :) See the thread here, and the additional links: http://markmail.org/thread/ylqbxezgz6rtb7v2 https://reviews.apache.org/r/26426/#comment_rc96919-56878

Re: State of registrar

2016-03-07 Thread Benjamin Mahler
Apologies for the long delay. I wouldn't call it experimental (that comment is stale), you should feel free to turn on strictness. Strictness enforces that agents that were removed by an old master cannot re-join with a new master. This preserves the steady state behavior: if the master removes

Re: Mesos Maintenance Enhancement (post-MVP)

2016-03-07 Thread Benjamin Mahler
Can you send an invite to bmah...@apache.org? On Sun, Mar 6, 2016 at 6:40 PM, Klaus Ma wrote: > Hi team, > > I started the following working group to enhance Mesos Maintenance for some > cases. Please join the working group if you're interesting in it :). > > *Working

Re: Looking for shepherd for MESOS-4705

2016-03-07 Thread Benjamin Mahler
Thanks for looking into this bug, I left some comments. On Sun, Mar 6, 2016 at 11:28 PM, Du, Fan wrote: > Hi > > Could I have a shepherd for MESOS-4705< > https://issues.apache.org/jira/browse/MESOS-4705> ? > A trivial bug fix with RR https://reviews.apache.org/r/44379/ > >

Re: Making 'curl' a prerequisite for installing Mesos

2016-03-06 Thread Benjamin Mahler
Also would be great to understand where libprocess is currently insufficient in terms of the HTTP support you need. On Fri, Mar 4, 2016 at 12:17 PM, Jie Yu wrote: > Thanks for the feedback, guys! > > I think we all agree that using libcurl is the ideal solution. I've

Re: [2/2] mesos git commit: Added documentation for labeled reserved resources.

2016-02-20 Thread Benjamin Mahler
you want to show for setting reservationInfo for static > reservation is https://issues.apache.org/jira/browse/MESOS-4476 > > On Sat, Feb 13, 2016 at 2:16 AM, Neil Conway <neil.con...@gmail.com> > wrote: > > > Hi Ben, > > > > On Fri, Feb 12, 2016 at 2:34 AM

Re: [2/2] mesos git commit: Added documentation for labeled reserved resources.

2016-02-12 Thread Benjamin Mahler
Any plans to support labels for static reservations? Are we intentionally not supporting ReservationInfo for static reservations? Or is this just outside of the initial scope? On Fri, Feb 12, 2016 at 1:18 AM, wrote: > Added documentation for labeled reserved resources. > >

Re: Endpoint documentation is now published!

2016-02-08 Thread Benjamin Mahler
could try some api generators like http://swagger.io/ or > https://github.com/apidoc/apidoc > > On Tue, Feb 9, 2016 at 1:10 AM, Benjamin Mahler <bmah...@apache.org> > wrote: > >> We now have endpoint documentation published on the website: >> >> http://mesos.apa

Re: Need a shepherd for https://issues.apache.org/jira/browse/MESOS-4588

2016-02-08 Thread Benjamin Mahler
Neil, if you review this I'll be happy to commit when it's ready! On Mon, Feb 8, 2016 at 7:34 AM, Abhishek Dasgupta < a10gu...@linux.vnet.ibm.com> wrote: > Hi, > > There is these changes to set the titles for Mesos documentation pages. > Will anyone shepherd the issue >

Re: [4/4] mesos git commit: Added `Resources::size()`.

2016-02-05 Thread Benjamin Mahler
Didn't we pull this out in the past? I seem to remember it being too brittle to have code looking at 'size' since it depends on our changing concept of when Resource objects can be merged. On Fri, Feb 5, 2016 at 3:16 PM, wrote: > Added `Resources::size()`. > > Review:

Re: [RESULT][VOTE] Release Apache Mesos 0.27.0 (rc2)

2016-02-03 Thread Benjamin Mahler
Great! Is a blog post on the way? On Sun, Jan 31, 2016 at 5:39 PM, Michael Park wrote: > Hi all, > > The vote for Mesos 0.27.0 (rc2) has passed with the > following votes. > > +1 (Binding) > -- > Vinod Kone > Joris Van Remoortere > Till Toenshoff >

Design Doc: Initial Support for GPGPU Resources

2016-02-02 Thread Benjamin Mahler
Hi folks, On behalf of the GPU working group [1] I'd like to share a design doc for adding some initial support for GPU resources in Mesos: JIRA Epic: https://issues.apache.org/jira/browse/MESOS-4424 Design Doc:

Re: Need a shepherd for https://issues.apache.org/jira/browse/MESOS-4446

2016-01-29 Thread Benjamin Mahler
+tim, jie since this is docker related On Sun, Jan 24, 2016 at 10:31 AM, Abhishek Dasgupta < a10gu...@linux.vnet.ibm.com> wrote: > Hi, > > Is there someone who can please shepherd the issue > https://issues.apache.org/jira/browse/MESOS-4446? > We can have a discussion on designing this on the

Re: Core affinity in Mesos

2016-01-29 Thread Benjamin Mahler
Since "Isolation" applies broadly outside of the context of addressing latency sensitive workloads (e.g. user/pid/network namespacing, resource limitations (e.g. cpu quota, memory limits, gpu device visibility) it would be great to choose a more specific name. Some suggestions: interference,

Re: Need a shepherd for MESOS--3317

2016-01-29 Thread Benjamin Mahler
IMO there is not enough information in the ticket and review to understand why this is being done. The only information I see is: "A well defined query string order (e.g. in alphabetical order) may be important for bot detection." Could we please clarify what problem is being solved here? On

Re: Shepherd request

2016-01-29 Thread Benjamin Mahler
If some contributors can help review, I would be happy to get this committed for you. On Wed, Jan 27, 2016 at 3:52 PM, Disha Singh wrote: > Can anyone be the shepherd for : > https://issues.apache.org/jira/browse/MESOS-3161 > > I would need help in inserting proper

Re: [Discussion] MESOS-4442: `allocated` may have more resources then `total` in allocator

2016-01-29 Thread Benjamin Mahler
Looks like you've seen the comment here: https://issues.apache.org/jira/browse/MESOS-4442?focusedCommentId=15120754=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15120754 We allow this so that the allocator can be over-allocated. When over-allocated, we will not

Re: IPv6 support in Mesos

2016-01-29 Thread Benjamin Mahler
I've un-assigned and removed the shepherd on this, no work has taken place for some time. Glad to see you're using Mesos! There is currently no shepherd for IPv6 support, but it would be great if you could publish a design document for feedback after you've assessed what needs to be done to

Re: Operator HTTP endpoints

2016-01-15 Thread Benjamin Mahler
The distinction between being related to the request vs. how the request should be processed seems arguable, do you feel that we'll be able to make the distinction easily? One thought.. if there are top-level Request objects: message QuotaRequest { optional bool force; required QuotaInfo

Re: [MESOS-1865] Redirect to the leader master when current master is not a leader.

2016-01-08 Thread Benjamin Mahler
Some feedback on this ticket: it focuses on the solution rather than the problem. We generally want to avoid this, I guess it's been coined 'The XY Problem' (thanks Benjamin Bannier). In this case it turns out that there are actually 2 distinct problems that the user is facing: (1) Passive

Re: Looking for a shepherd for MESOS-4258

2016-01-08 Thread Benjamin Mahler
This is very helpful, thanks for doing it. I'll shepherd. On Wed, Jan 6, 2016 at 9:47 PM, Shuai Lin wrote: > Hi list, > > I'm working on MESOS-4258 < > https://issues.apache.org/jira/browse/MESOS-4258>, > "Generate xml test reports in the jenkins build", , > > It's a

Re: [MESOS-1865] Redirect to the leader master when current master is not a leader.

2016-01-08 Thread Benjamin Mahler
confusing for users that some endpoints redirect and some do not. On Fri, Jan 8, 2016 at 12:47 PM, Neil Conway <neil.con...@gmail.com> wrote: > On Fri, Jan 8, 2016 at 12:29 PM, Benjamin Mahler <bmah...@apache.org> > wrote: > > (2) It is difficult to reliably obtain

Re: Change minimum supported version for GCC to 4.8.1

2016-01-05 Thread Benjamin Mahler
/browse/MESOS-2604>? > > AFAICT, it just shows that a particular variant of GCC 4.8+ is available > on each of the supported distributions. So, this should not be an issue > unless I am missing something? > > -anand > > > On Jan 4, 2016, at 5:42 PM, Benjamin Mahler <bmah

Re: Change minimum supported version for GCC to 4.8.1

2016-01-04 Thread Benjamin Mahler
When we moved to 4.8 there was a spreadsheet that showed how folks can get 4.8 on various distributions, have you checked that 4.8.1 is available across distributions? On Mon, Jan 4, 2016 at 4:07 PM, Adam Bordelon wrote: > +1 > > On Mon, Jan 4, 2016 at 3:19 PM, Joris Van

Re: Fix for MESOS-3809 not in 0.26.0 (Was: Re: [RESULT][VOTE] Release Apache Mesos 0.26.0) (rc5)

2016-01-04 Thread Benjamin Mahler
a > > On Wed, Dec 16, 2015 at 4:57 AM, Till Toenshoff <toensh...@me.com> wrote: > > > Hi friends, > > > > The vote for Mesos 0.26.0 (rc5) has passed with the > > following votes. > > > > +1 (Binding) > > ---

Re: Looking for a shepherd

2016-01-04 Thread Benjamin Mahler
Glad to hear you're using mesos! I introduced this bug, sorry! I just pushed your fix, thanks for sending it! On Mon, Jan 4, 2016 at 3:08 AM, Jocelyn De La Rosa < jocelyn.delar...@scmfrance.fr> wrote: > Hello everyone, > > My name is Jocelyn and I'm working on a mesos framework for a big >

Re: Speed up Mesos tests

2015-12-29 Thread Benjamin Mahler
There was a sharp increase in the test suite duration back when we added the registrar: by default every test with a master uses replicated log storage which involves many synchronous disk writes. We can swap out replicated log storage for in-memory storage (already exists, just needs to be wired

Re: mesos git commit: Revert "Added XML test output to the jenkins docker build."

2015-12-29 Thread Benjamin Mahler
git-wip-us.apache.org/repos/asf/mesos/tree/0d66b691 > Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/0d66b691 > > Branch: refs/heads/master > Commit: 0d66b6915dbb65727bff91beae3084fb266c6f1c > Parents: d8551f0 > Author: Benjamin Mahler <benjamin.mah...@gmail.com> >

Re: promises, futures and process::Queue

2015-12-28 Thread Benjamin Mahler
Queue does not currently have discard semantics implemented, so discard() does nothing. Keep in mind that f.discard() is just a request, and f.hasDiscard() tells you if the request was made. It's up to the promise owner to decide if discards are supported, and so after a discard is requested the

Re: `F()` vs `F(void)`

2015-12-13 Thread Benjamin Mahler
std::function becomes std::function? +1 On Sun, Dec 13, 2015 at 10:55 AM, Jie Yu wrote: > +1 > > On Sun, Dec 13, 2015 at 10:46 AM, Michael Park wrote: > > > Hello, > > > > In the C++ world, the *void* parameter is considered to be

Re: [VOTE] Release Apache Mesos 0.26.0 (rc5)

2015-12-11 Thread Benjamin Mahler
+1 (binding) Make check on OS X with and without '--enable-ssl --enable-libevent'. On Thu, Dec 10, 2015 at 2:55 PM, Till Toenshoff wrote: > Hi friends, > > we did unfortunately, once again run into an issue that needed immediate > attention (see vote on rc4), hence we have to

Re: [VOTE] Release Apache Mesos 0.26.0 (rc4)

2015-12-10 Thread Benjamin Mahler
, Dec 10, 2015 at 11:22 AM, Benjamin Mahler <benjamin.mah...@gmail.com > wrote: > What is the workaround? > > On Thu, Dec 10, 2015 at 4:37 AM, Bernd Mathiske <be...@mesosphere.io> > wrote: > >> I think that whereas this would clearly be a desirable bug fi

Re: mesos git commit: Fixed pointer alignment error in IP::create().

2015-12-04 Thread Benjamin Mahler
of *ref* is *const T&* > *const T* ptr = * > // incorrect assumption: *ptr == * > > We actually need: *const auto& ref = static_cast(t);* in order > for *ptr == * to be true. With that in mind, I would prefer to write the > above code as: > > *const auto* ptr = static

Re: mesos git commit: Fixed pointer alignment error in IP::create().

2015-12-04 Thread Benjamin Mahler
Sorry, the first example from protobuf_utils.cpp isn't so bad, although we're inconsistent with how we name iterators. Also, it would be great to use foreach with a reversed adaptor rather than manual reverse iteration. On Fri, Dec 4, 2015 at 12:01 PM, Benjamin Mahler <benjamin.mah...@gmail.

Re: mesos git commit: Fixed health check consecutive failure comments.

2015-12-04 Thread Benjamin Mahler
Thank you! On Thu, Dec 3, 2015 at 9:36 PM, wrote: > Repository: mesos > Updated Branches: > refs/heads/master 6441c368b -> 56cdb455f > > > Fixed health check consecutive failure comments. > > > Project: http://git-wip-us.apache.org/repos/asf/mesos/repo > Commit:

Re: mesos git commit: Added documentation about terminate/wait in Processes destructors.

2015-12-03 Thread Benjamin Mahler
-1 This is asymmetric, the caller should be spawning and terminating, but we terminate also within process destructors? This looks like compensating for a programming error, needs more thought. I will revert this, and please revert any code that is using this pattern. On Thu, Dec 3, 2015 at

Re: [VOTE] Release Apache Mesos 0.26.0 (rc3)

2015-12-03 Thread Benjamin Mahler
+1 (binding) tests pass on OS X 10.11.1 with both SSL and non-SSL configurations. Some feedback from framework developers would be great here. Agreed that MESOS-3973 is not a blocker, given it also occurs on 0.26.0 all the way back to 0.21.0.

Re: How to write numbers in docs

2015-12-03 Thread Benjamin Mahler
> Do you even care? I don't have an opinion here, but I'm pretty skeptical this is going to be correctly enforced since this is a rule about how people should write their sentences. There are some high value items in this area, like exploring if we can add a markdown linter into our tool chain.

Re: [jira] [Comment Edited] (MESOS-2079) IO.Write test is flaky on OS X 10.10.

2015-12-02 Thread Benjamin Mahler
ading side. > > > > The only thing I could see us caring about SIGPIPE is if we want to know > as soon as the pipe breaks that the event happened. > > So it sounds like there is no objection to this change? Can we land these > changes now? > > >>

Re: Mesos Events Calendar

2015-11-20 Thread Benjamin Mahler
Nice, is there a way to open up the calendar so that others can add events? On Fri, Nov 20, 2015 at 8:42 AM, Michael Park wrote: > Hello, I've created a public events calendar: > > >

Re: [VOTE] Release Apache Mesos 0.26.0 (rc1)

2015-11-20 Thread Benjamin Mahler
Did you forget to replace 0.26.0 with 0.27.0 in configure.ac? Ideally all commits with configure.ac pointing to 0.26.0 land in 0.26.0. Please move configure.ac to 0.27.0 if you've decided on a cut point :) On Fri, Nov 13, 2015 at 12:14 PM, Till Toenshoff wrote: > Hi friends,

Re: Website update frequency

2015-11-15 Thread Benjamin Mahler
I also use apply-reviews as an aid for code reviewing. Glad to see others are doing this since IMHO just looking at diffs rather than the final product can be limiting. On Thu, Nov 12, 2015 at 11:57 AM, Isabel Jimenez < contact.isabeljime...@gmail.com> wrote: > I also like to apply reviews,

Re: Mesos Style Guideline Adjustments

2015-11-15 Thread Benjamin Mahler
matting tools. > > If there is more than some simple math involved, this may not be a viable > solution. > > Joris > > — > *Joris Van Remoortere* > Mesosphere > > On Fri, Nov 6, 2015 at 11:10 AM, Benjamin Mahler < > benjamin.mah...@gmail.com> > wrote: &g

Re: Add JIRA ticket# to `TODO`s in comments

2015-11-15 Thread Benjamin Mahler
t; >>> > > >>> I may be wrong, but I feel that sometimes we use `TODO`s as food for > > >>> thought, not for something that should or will necessarily be > > implemented > > >>> soon. A `TODO` may provide additional context to the implementation

Re: libprocess: ordered message delivery

2015-11-15 Thread Benjamin Mahler
Having ordered delivery as defined by Akka [1] and Erlang [2] is definitely useful, we've made several assumptions around it, despite knowing that it is not guaranteed due to the subtleties around link-less sends and link breakage that you covered in (a) and (b). The memory overhead of storing

Re: Add JIRA ticket# to `TODO`s in comments

2015-11-11 Thread Benjamin Mahler
Kapil would you mind clarifying what is being proposed here? Folks are already free to include a reference to a ticket when writing a comment or a TODO, so is the suggestion here to require it for TODOs? Or to add a syntax for this? If it's the latter, what does the syntax achieve? On Wed, Nov

Re: Mesos Style Guideline Adjustments

2015-11-06 Thread Benjamin Mahler
;>>>>> I've removed the 70 column restriction on comments from the style > >>>> guide: > >>>>>>> > >>>>>> > >>>> > >>> > https://github.com/apache/mesos/commit/f9c2604ea97b9

Re: Mesos Style Guideline Adjustments

2015-11-06 Thread Benjamin Mahler
riendly formatting tools. > > If there is more than some simple math involved, this may not be a viable > solution. > > Joris > > — > *Joris Van Remoortere* > Mesosphere > > On Fri, Nov 6, 2015 at 11:10 AM, Benjamin Mahler < > benjamin.mah...@gmail.com

Re: [jira] [Comment Edited] (MESOS-2079) IO.Write test is flaky on OS X 10.10.

2015-11-06 Thread Benjamin Mahler
that > SIGPIPE is raised as soon as the OS realizes the pipe is broken while the > error on the write happens when you actually try to write on the pipe. > > All in all, I prefer to ignore the signal and deal with the return value > of `write`. > > > On 06 Nov 2015, at 03:27, Benj

Re: Better error reporting in Mesos

2015-11-06 Thread Benjamin Mahler
Thanks for the proposal Michael. This has come up in discussions before and I think it's really valuable, so it's nice to see folks thinking about this. Some things to consider: Don't forget 'Failure' which is unfortunately not unified with 'Error'. How does this affect error message composition

Re: MESOS-3545: Investigate restoring tasks/executors after machine reboot.

2015-11-06 Thread Benjamin Mahler
Any reason that this doesn't mention the executor failing during the steady state? I assume that the desire here is more generally to restart executors according to a policy, without having the round-trip back to the scheduler which may not be successful in many circumstances. Also, any reason

Fwd: [jira] [Created] (MESOS-2353) Improve performance of the master's state.json endpoint for large clusters.

2015-11-05 Thread Benjamin Mahler
ement > Components: master >Reporter: Benjamin Mahler > Labels: newbie, scalability, twitter > > The master's state.json endpoint consistently takes a long time to compute the JSON result, for large clusters: > {noformat} > $ time curl -s -o /dev/null

Re: Mesos Style Guideline Adjustments

2015-11-05 Thread Benjamin Mahler
; -1 on sweeping changes; incremental changes when touching old > comments > >>>>> will do IMHO > >>>>> > >>>>> +1 on the -1? :) > >>>> Incremental changes are good and I doubt anyone will be "confused"

Re: Welcome Kapil as Mesos committer and PMC member!

2015-11-05 Thread Benjamin Mahler
Congrats and welcome! On Thu, Nov 5, 2015 at 4:04 PM, Kapil Arya wrote: > Thanks everyone! :-). > > > > On Thu, Nov 5, 2015 at 3:50 PM, Elizabeth Lingg > wrote: > >> Congrats Professor! You definitely deserve it. >> >> -Elizabeth >> >> On Thu, Nov

Re: [jira] [Comment Edited] (MESOS-2079) IO.Write test is flaky on OS X 10.10.

2015-11-05 Thread Benjamin Mahler
Components: libprocess, technical debt, test > > Environment: OS X 10.10 > > {noformat} > > $ clang++ --version > > Apple LLVM version 6.0 (clang-600.0.54) (based on LLVM 3.5svn) > > Target: x86_64-apple-darwin14.0.0 > > Thread model: posix > >

<    1   2   3   4   5   6   7   8   9   10   >