Fwd: [jira] [Updated] (MESOS-3826) Add an optional unique identifier for resource reservations

2015-11-04 Thread Benjamin Mahler
Are you actually going to shepherd this michael? We ended up not adding IDs to these because we wanted dynamic reservations to be symmetric with static reservations. Needs some thought. -- Forwarded message -- From: Guangya Liu (JIRA) Date: Tue, Nov 3, 2015 at

Re: soliciting shepherds

2015-11-03 Thread Benjamin Mahler
I will take https://issues.apache.org/jira/browse/MESOS-3708, can other committers pitch in for the other tickets here? On Thu, Oct 29, 2015 at 8:15 PM, James Peach wrote: > Hi all, > > Can anyone shepherd the following changes? > >

Re: [Breaking bug fix] Binary in state endpoints

2015-11-02 Thread Benjamin Mahler
Sorry for the confusion, the motivation to remove 'data' is for memory scalability reasons (the ability to express binary fields is orthogonal and is not the reason to remove 'data'). We can get into a really bad state in large clusters if frameworks are putting non-trivial amounts of 'data' in

Re: RFC: license headers interfere with doxygen documentation (MESOS-3581)

2015-10-20 Thread Benjamin Mahler
+1 for (a), in this case the wide sweep only touches the license comments, so it won't be disruptive to history. On Tue, Oct 20, 2015 at 11:59 AM, James Peach wrote: > > > On Oct 20, 2015, at 8:55 AM, Bernd Mathiske wrote: > > > > All, is changing every

Re: custom(ized) conteinerization

2015-10-12 Thread Benjamin Mahler
; > > > > > How would I know whether they conflict? For example, the docker one > and > > > the default mesos one with certain configuration of isolators etc? > > > > > > Thanks, > > > Alex > > > > > > > > > Benjamin M

Re: custom(ized) conteinerization

2015-10-09 Thread Benjamin Mahler
(1) is something that has come up before. The containerizer deals with a variable sized container, the semantics of a task are defined by the executor, there is no way for the containerizer to understand the meaning of a task currently. Some tasks are "special" in that they don't have an executor

Re: [VOTE] Release Apache Mesos 0.22.2 (rc1)

2015-09-29 Thread Benjamin Mahler
+1 (binding), compiled correctly on OS X, but encountered OS X specific networking issues when running the tests. Thanks Adam! On Mon, Sep 28, 2015 at 12:52 PM, Brenden Matthews wrote: > +1 (binding), tested on internal CI > > On Thu, Sep 24, 2015 at 8:58 AM, haosdent

Re: [VOTE] Release Apache Mesos 0.22.2 (rc1)

2015-09-29 Thread Benjamin Mahler
Sending from the right email this time.. +1 (binding), compiled correctly on OS X, but encountered OS X specific networking issues when running the tests. Thanks Adam! On Mon, Sep 28, 2015 at 12:52 PM, Brenden Matthews wrote: > +1 (binding), tested on internal CI > > On

Re: Working Group List

2015-09-24 Thread Benjamin Mahler
Can you add a link to the working groups from the http://mesos.apache.org/community/ page? On Thu, Sep 24, 2015 at 8:59 AM, Artem Harutyunyan wrote: > Hey Nik, > > I could not see how to edit the page, so could you please add a link > to this doc >

Re: Why do we need slave_id in Kill message

2015-09-23 Thread Benjamin Mahler
This decision also makes it easier for us to explore relaxing the globally unique requirement on TaskID, instead requiring that be unique, which makes some problems easier to solve. For example: https://issues.apache.org/jira/browse/MESOS-3070. Also, it could allow us to further

Re: need help/shepherd on MESOS-1806

2015-09-23 Thread Benjamin Mahler
The registrar by default uses the replicated log as a storage backend, and the replicated log uses zookeeper for replica discovery, so this may be related to your etcd integration. On Thu, Sep 17, 2015 at 11:47 PM, Shuai Lin wrote: > Hi, > > I am working on MESOS-1806

Re: [2/2] mesos git commit: Added masterSlaveLostHook.

2015-09-23 Thread Benjamin Mahler
+dev Just so the rest of the dev community understands, are these kinds of event based hooks going to be subsumed by a mechanism to stream out cluster events? Or will these hooks co-exist alongside cluster events? On Wed, Sep 23, 2015 at 3:38 PM, wrote: > Added

Re: [2/2] mesos git commit: Added masterSlaveLostHook.

2015-09-23 Thread Benjamin Mahler
Ok, any plan to add TODOs with this context? On Wed, Sep 23, 2015 at 4:11 PM, Niklas Nielsen <nik...@mesosphere.io> wrote: > On 23 September 2015 at 15:47, Benjamin Mahler <benjamin.mah...@gmail.com> > wrote: > > > +dev > > > > Just so the rest of the dev

Re: Working Group List

2015-09-23 Thread Benjamin Mahler
Also, we might need maintainers for > sub-subsystems. > 5. Plans for engagement with maintainers. > > thanks > Jojy > > > > On Sep 21, 2015, at 2:43 PM, Benjamin Mahler <benjamin.mah...@gmail.com> > wrote: > > > > Hi Jojy, > > > > This was b

Re: Working Group List

2015-09-23 Thread Benjamin Mahler
t;j...@mesosphere.io> wrote: > The proposal lists the motivations in the "problem statement” section. > > -Jojy > > > > On Sep 23, 2015, at 4:27 PM, Benjamin Mahler <benjamin.mah...@gmail.com> > wrote: > > > > Rather than address these suggestions, I'd li

Re: [2/2] mesos git commit: Added masterSlaveLostHook.

2015-09-23 Thread Benjamin Mahler
t an alternative (yet). > > Niklas > > On 23 September 2015 at 16:29, Benjamin Mahler <bmah...@twitter.com.invalid > > > wrote: > > > Ok, any plan to add TODOs with this context? > > > > On Wed, Sep 23, 2015 at 4:11 PM, Niklas Nielsen <nik...@

Re: Mesos Style Guideline Adjustments

2015-08-11 Thread Benjamin Mahler
actually use that one and be done with it. Having looked through the codebase, we wrap the braces for *enum* for about half of the cases. It would be about 35 instances that we have to fix from what I can see in our codebase. What do you think? On Thu, Jul 30, 2015 at 5:14 PM Benjamin

Re: Range-based for loops

2015-08-05 Thread Benjamin Mahler
for it :-). Cheers, Artem. On Tue, Aug 4, 2015 at 5:18 PM, Benjamin Mahler benjamin.mah...@gmail.com wrote: I noticed there was a single ranged-based for loop introduced in the source tree: https://github.com/apache/mesos/blob/master/src/tests/resources_tests.cpp#L1004 Since

Re: mesos git commit: Revert Add subscribe- subscribed workflow for http frameworks

2015-08-05 Thread Benjamin Mahler
-us.apache.org/repos/asf/mesos/diff/586307e5 Branch: refs/heads/master Commit: 586307e546955c23aadf0ed5bfae9e00c0228f86 Parents: dbf35da Author: Benjamin Mahler benjamin.mah...@gmail.com Authored: Wed Aug 5 16:47:36 2015 -0700 Committer: Benjamin Mahler benjamin.mah...@gmail.com Committed: Wed

Re: Autoscaling in an IaaS environment

2015-08-03 Thread Benjamin Mahler
With auto-scaling, shrinking is not as easy as growing. For example, we may need to defragment the cluster in order to shrink the number of slaves, and mesos seems to be in the best position to orchestrate such a process if you want do this based on framework's SLA constraints (would re-use

Re: mesos git commit: Candidate port of result.hpp.

2015-07-31 Thread Benjamin Mahler
Hm.. this could have used a better commit name, what is a candidate port? Looks like just a variable rename to me :) On Fri, Jul 31, 2015 at 11:38 AM, b...@apache.org wrote: Repository: mesos Updated Branches: refs/heads/master d144fc7ba - d018eb712 Candidate port of result.hpp.

Re: Mesos Style Guideline Adjustments

2015-07-30 Thread Benjamin Mahler
Is it worth adding our own style? I noticed other have (LLVM, Google, Chromium, Mozilla, WebKit.). How hard is it? On Thu, Jul 30, 2015 at 4:23 PM, Michael Park mcyp...@gmail.com wrote: There are a few syntactical Mesos style guidelines that I would like to propose to drop. They are: 1.

Re: Beware of ASSERT_* Placement

2015-07-28 Thread Benjamin Mahler
that. I mainly wanted to inform folks of this limitation and the corresponding confusing error message that follows. On 27 July 2015 at 18:42, Benjamin Mahler benjamin.mah...@gmail.com wrote: Michael, note that we've avoided having ASSERT_ or EXPECT_ inside test helper methods because

Re: Where's Meses design documents

2015-07-27 Thread Benjamin Mahler
Vinod, it would be nice to have them within the repo, can't we have an area in docs/ for design documents? Even if that just links to active google docs, seems nicer than using cwiki? On Mon, Jul 27, 2015 at 2:05 PM, Vinod Kone vinodk...@gmail.com wrote: Ideally, all design docs that are

Re: Beware of ASSERT_* Placement

2015-07-27 Thread Benjamin Mahler
Michael, note that we've avoided having ASSERT_ or EXPECT_ inside test helper methods because they print out the line number of the helper method, rather than the line number where the helper method was called from the test. This is why we've been pretty careful when adding helpers and have tried

Re: Introducing a CMake-based build system for Mesos

2015-07-23 Thread Benjamin Mahler
Cool, hoping that we also explore speeding up the tests by running them in parallel (although I realize that automake already has a parallel test runner). On Wed, Jul 22, 2015 at 2:12 PM, Alex Clemmer clemmer.alexan...@gmail.com wrote: Hey folks. For some time there has been vestigial

Re: Quota Design Doc v1

2015-07-16 Thread Benjamin Mahler
that container as root on the box. Locking other things down by default / leaving them off by default won't improve the default security configuration of a Mesos cluster. On Wed, Jul 15, 2015 at 3:02 PM Benjamin Mahler benjamin.mah...@gmail.com wrote: If we omit authz for admin endpoints

Re: [jira] [Commented] (MESOS-3035) As a Developer I would like a standard way to run a Subprocess in libprocess

2015-07-16 Thread Benjamin Mahler
Hey sorry for the frustration, I wrote subprocess originally but it's evolved over time through a number of folks. Is ben going to shepherd this? Just a few higher level things to consider: (1) Discard semantics: with subprocess the caller has the ability to kill the process through s.pid.

Re: synchronized

2015-07-15 Thread Benjamin Mahler
PM Benjamin Mahler bmah...@twitter.com.invalid wrote: Thanks Michael, please do keep sending things like this out, and encourage others to do so as well. Going to be increasingly important to let each other know about things like this as the community grows. :) On Thu, Jul 9

Re: Quota Design Doc v1

2015-07-15 Thread Benjamin Mahler
If we omit authz for admin endpoints like this, it would be great to disable them _by default_ until we have proper authorization in place. Otherwise operators will accidentally leave admin endpoints open for anyone to hit! :) On Wed, Jul 15, 2015 at 12:07 PM, Alex Rukletsov a...@mesosphere.com

Re: Doxygen / Javadoc changes

2015-07-14 Thread Benjamin Mahler
wrote: On Mon, Jul 13, 2015 at 9:41 PM, Benjamin Mahler benjamin.mah...@gmail.com wrote: Let me try to contain the length of this thread, two points don't seem to agree my request and benh's reply. (1) You're saying all non-trivial classes / methods in headers should have javadoc

Re: Doxygen / Javadoc changes

2015-07-13 Thread Benjamin Mahler
:23 PM, Benjamin Mahler benjamin.mah...@gmail.com wrote: A couple of thoughts: (1) When introducing javadoc comments, can we please keep comment style consistent within files and APIs? For the most part, it seems folks are introducing javadoc in consistent sweeps, which is great

Re: RFC: Framework - Executor Message Passing Optimization Removal

2015-07-13 Thread Benjamin Mahler
back stdout/stderr logs from the build to the client for ease of use/debugging and the executor-framework best-effort messaging stuff made this effortless. -- Tom Arnfeld Developer // DueDil On Mon, Jun 29, 2015 at 10:48 PM, Benjamin Mahler benjamin.mah...@gmail.com wrote: FYI Some

Re: [VOTE] Release Apache Mesos 0.23.0 (rc2)

2015-07-09 Thread Benjamin Mahler
Here is the ticket: https://issues.apache.org/jira/browse/MESOS-3025 On Wed, Jul 8, 2015 at 4:52 PM, Benjamin Mahler benjamin.mah...@gmail.com wrote: -1 sorry! We just found a backwards incompatible change while fixing: https://issues.apache.org/jira/browse/MESOS-2940 Schedulers still

Re: [jira] [Updated] (MESOS-2075) Add maintenance information to the replicated registry.

2015-07-09 Thread Benjamin Mahler
...@mesosphere.io wrote: Hi Ben, Yes, we do plan to work on this. Thanks a lot for raising the concern! We will change the first task to update the design doc and revive the discussion around this. Cheers, Artem. On Tue, Jul 7, 2015 at 3:20 PM, Benjamin Mahler benjamin.mah...@gmail.com

Re: synchronized

2015-07-09 Thread Benjamin Mahler
Thanks Michael, please do keep sending things like this out, and encourage others to do so as well. Going to be increasingly important to let each other know about things like this as the community grows. :) On Thu, Jul 9, 2015 at 4:37 PM, Marco Massenzio ma...@mesosphere.io wrote: sweet!

Doxygen / Javadoc changes

2015-07-09 Thread Benjamin Mahler
A couple of thoughts: (1) When introducing javadoc comments, can we please keep comment style consistent within files and APIs? For the most part, it seems folks are introducing javadoc in consistent sweeps, which is great. However, it looks also like there are reviews and commits where we are

Re: [VOTE] Release Apache Mesos 0.23.0 (rc2)

2015-07-08 Thread Benjamin Mahler
-1 sorry! We just found a backwards incompatible change while fixing: https://issues.apache.org/jira/browse/MESOS-2940 Schedulers still running a 0.22.0 driver against a 0.23.0 master will not function correctly because StatusUpdate.uuid is now optional and no longer set for reconciliation

Re: Quota Design Doc v1

2015-07-07 Thread Benjamin Mahler
Great work guys! Couple of related high level questions, mostly around customization: (1) I imagine some folks may not want to use an endpoint for this. For example, they may want the master to consult an external quota database, file, etc as it is a bit easier to guarantee convergence with this

Re: [jira] [Updated] (MESOS-2075) Add maintenance information to the replicated registry.

2015-07-07 Thread Benjamin Mahler
Reporter: Benjamin Mahler Labels: mesosphere, twitter Fix For: 0.24.0 To achieve fault-tolerance for the maintenance primitives, we will need to add the maintenance information to the registry. The registry currently stores all of the slave information, which

Re: RFC: Framework - Executor Message Passing Optimization Removal

2015-06-29 Thread Benjamin Mahler
FYI Some folks reached out off thread that they are using this optimization for distributed health checking of tasks. This is on the order of O(10,000) framework messages per second for them, which may not be possible through the master. On Tue, Jun 23, 2015 at 6:08 PM, Benjamin Mahler

Re: Project wide updates to #include statements

2015-06-26 Thread Benjamin Mahler
+1 to cody's suggestion for stout / libprocess. Looking forward to seeing include style automated, will help us be more effective with reviews. :) It looks like we can further modify include what you use to capture stout and libprocess headers, probably worth the effort:

Re: Update minimum required automake version to 1.13

2015-06-25 Thread Benjamin Mahler
: https://www.softwarecollections.org/en/scls/praiskup/autotools/ If the tools are available, would there be any other objections to move to the newer versions? On Thu, Jun 25, 2015 at 7:02 PM, Benjamin Mahler benjamin.mah...@gmail.com wrote: Well, CentOS 5 users don't have

Re: Update minimum required automake version to 1.13

2015-06-25 Thread Benjamin Mahler
What about CentOS 5 and 6? https://en.wikipedia.org/wiki/CentOS#End-of-support_schedule Also, how does this interact with the effort to use CMake? https://issues.apache.org/jira/browse/MESOS-898 On Thu, Jun 25, 2015 at 10:40 AM, Kapil Arya ka...@mesosphere.io wrote: Hi All, First off, I am

Re: Update minimum required automake version to 1.13

2015-06-25 Thread Benjamin Mahler
the backwards incompatible changes automake had in 1.12 to 1.14 and trying to support all the default versions across different distros. due to this we are switching to cmake as well -Jake On Thu, Jun 25, 2015 at 1:46 PM, Benjamin Mahler benjamin.mah

RFC: Framework - Executor Message Passing Optimization Removal

2015-06-23 Thread Benjamin Mahler
The existing Mesos API provides unreliable messaging passing for framework - executor communication: -- Schedulers can call 'sendFrameworkMessage(executor, slave, data)' on the driver [1], this sends a message to the executor. This has a best-effort optimization to bypass the master, and send the

IRC channel for HTTP API work

2015-06-22 Thread Benjamin Mahler
I've created an IRC channel to make it easier for folks working on the HTTP API to collaborate: #mesos-http-api

Re: [Breaking Change 0.24, MESOS 1988] Silently ignore launchTask/acceptOffers calls when disconnected

2015-06-22 Thread Benjamin Mahler
+vinod Hm.. I can't tell from MESOS-1988, why is this required for the HTTP API? I see MESOS-1972 as a link to more context, but that is for validation. The disconnected case does not overlap with the master's validation logic, it is an artifact of the driver implementation (the scheduler can't

Folly Futures

2015-06-19 Thread Benjamin Mahler
Looks like facebook added Futures to folly: https://github.com/facebook/folly/tree/master/folly/futures Error handling is done through exceptions, and the executor is made explicit so that people can choose different execution models.

Re: Folly Futures

2015-06-19 Thread Benjamin Mahler
Blog post here: https://code.facebook.com/posts/1661982097368498 On Fri, Jun 19, 2015 at 3:15 PM, Benjamin Mahler benjamin.mah...@gmail.com wrote: Looks like facebook added Futures to folly: https://github.com/facebook/folly/tree/master/folly/futures Error handling is done through

Re: Style guide for std::move

2015-06-17 Thread Benjamin Mahler
Also, do we want to allow a re-assignment after a move to re-use the object? Just some food for thought, have you explored extending Option to capture this? Optionvectorint v {1, 2, 3, 4}; foo(v.move()); v.isSome(); // false v = {1, 2, 3, 4}; v.isSome() // true On Wed, Jun 17, 2015 at 7:19 AM,

Re: Mesos Jira workflow

2015-06-10 Thread Benjamin Mahler
To go from accepted to open you need to go through in progress? On Wed, Jun 10, 2015 at 2:16 PM, Marco Massenzio ma...@mesosphere.io wrote: Thanks, everyone, for your suggestions: quick feedback was much appreciated! I've updated the Google Doc, I think we're in good shape, I'll wait until

Re: Mesos Jira workflow

2015-06-10 Thread Benjamin Mahler
at 6:19 PM, Benjamin Mahler benjamin.mah...@gmail.com wrote: To go from accepted to open you need to go through in progress? That part wasn't changed from before? Anyways, why would you ever want to do that? This means that, at some point we looked at something, thought we would want

Re: Mesos Jira workflow

2015-06-09 Thread Benjamin Mahler
I don't have comment permissions on the doc, but it looks like you omitted a way to go from Reviewable - In Progress, which we often do when the reviewee has more work to do before being ready for additional reviews, for example. I'm not sure what 'Closed' is supposed to represent, what does it

Re: Build failed in Jenkins: mesos-reviewbot #6201

2015-06-04 Thread Benjamin Mahler
Looks like ben pushed a fix ~ 5 hours ago. On Thu, Jun 4, 2015 at 12:50 PM, Vinod Kone vinodk...@apache.org wrote: On Thu, Jun 4, 2015 at 7:48 AM, Apache Jenkins Server jenk...@builds.apache.org wrote: checking for C++ compiler version... 4.8.2 checking for C++ compiler vendor...

Re: To contribute 2 mesos bugs, Please set Jira account joe-zhou as a contributor

2015-06-01 Thread Benjamin Mahler
Thanks, you can now assign issues to yourself. I've committed r/34887, and reviewed r/34886, can you update the diff? On Mon, Jun 1, 2015 at 5:09 AM, zhou weitao zhouwtl...@gmail.com wrote: Hi, mesos committers: Here is my patches: https://reviews.apache.org/r/34886/ ,

Re: Apache Mesos Committer Checklist

2015-05-15 Thread Benjamin Mahler
Thanks Bernd! Looks great. On Fri, May 8, 2015 at 3:47 PM, Vinod Kone vinodk...@apache.org wrote: This looks great. Thanks for sharing! On Fri, May 8, 2015 at 3:17 PM, Bernd Mathiske be...@mesosphere.io wrote: As mentioned at the community meeting at Twitter headquarters yesterday, a

Re: [jira] [Updated] (MESOS-1280) Add replace task primitive

2015-05-14 Thread Benjamin Mahler
, Benjamin Mahler benjamin.mah...@gmail.com wrote: Thanks for clarifying Jake! Marco / Ben, can you guys audit the type of the tickets that were mass transitioned to bugs? Many of these are not bugs :( On Wed, May 13, 2015 at 12:54 PM, Marco Massenzio ma...@mesosphere.io wrote: +benh - who

Re: [jira] [Updated] (MESOS-2020) mesos should send docker failure messages to scheduler

2015-05-14 Thread Benjamin Mahler
to resolve the ticket but it seems to be stuck on this state. Tim On May 13, 2015, at 5:03 PM, Benjamin Mahler benjamin.mah...@gmail.com wrote: +tim, jake What does pending closed mean? I noticed that this had become the default resolution yesterday. Did something change

Re: [jira] [Updated] (MESOS-1280) Add replace task primitive

2015-05-14 Thread Benjamin Mahler
*) -- review request Anyway, just some thoughts. MPark. On 14 May 2015 at 14:16, Benjamin Mahler benjamin.mah...@gmail.com wrote: Try to use Resolved instead of Closed if it was fixed / taken care of, etc. Also, with Resolved you don't need to re-open to make certain changes. On Wed, May 13

Re: Scaling Proposal: MAINTAINERS Files

2015-05-14 Thread Benjamin Mahler
...@twopensource.com javascript:; wrote: Yes, great. Why not use OWNERS as it is already in use internally at Twitter, at Google, in Chromium, and tooling already supports that as an implicit standard? On Feb 8, 2015 2:52 AM, Benjamin Mahler benjamin.mah...@gmail.com

Re: [jira] [Updated] (MESOS-2020) mesos should send docker failure messages to scheduler

2015-05-13 Thread Benjamin Mahler
+tim, jake What does pending closed mean? I noticed that this had become the default resolution yesterday. Did something change Jake? Tim, should this be resolved? On Tue, May 12, 2015 at 12:28 AM, Timothy Chen (JIRA) j...@apache.org wrote: [

Re: [jira] [Updated] (MESOS-1280) Add replace task primitive

2015-05-13 Thread Benjamin Mahler
of subtasks so all subtasks where run though and in the process they where converted to issues with the default issue type of 'bug'. -Jake On Wed, May 13, 2015 at 12:54 PM, Benjamin Mahler benjamin.mah...@gmail.com wrote: +jake We received a large number of emails about ticket

Fwd: [jira] [Updated] (MESOS-1280) Add replace task primitive

2015-05-13 Thread Benjamin Mahler
+jake We received a large number of emails about ticket transitions. It looks like they were all subtasks that were mass converted to bugs? Many of these are not bugs, e.g. this one, so I'm curious what caused this? Were subtask tickets disabled for the mesos project? -- Forwarded

Re: [Style Proposal] Mesos Header Include Order: Follow Google Style Guide completely

2015-05-02 Thread Benjamin Mahler
I'm a +1 on this so long as you follow up with all of the necessary include changes. :) BenH was probably the one that initially enacted this style, so I've cc'ed him to see if there was intention behind it. It should be pointed out that this rule doesn't apply to all .cpp files, yes? (e.g. tests

Re: [VOTE] Release Apache Mesos 0.22.1 (rc6)

2015-04-30 Thread Benjamin Mahler
Wasn't that ticket just a duplicate of https://issues.apache.org/jira/browse/MESOS-2601? On Thu, Apr 30, 2015 at 4:21 PM, Elizabeth Lingg elizab...@mesosphere.io wrote: +1, tested Mesos 2601, 2605, and 2668 in a test cluster with many services running. Adam, could you add the fix for Mesos

Re: builds now require gcc 4.8+ or clang 3.5+

2015-04-26 Thread Benjamin Mahler
Glad to see this, thanks to those involved! Sent from my iPhone On Apr 25, 2015, at 4:29 PM, Benjamin Hindman benjamin.hind...@gmail.com wrote: I'm happy to announce that we've committed the updates to configure.ac that require gcc 4.8+ and clang 3.5+! See this thread

Re: Using boost filesystem

2015-04-24 Thread Benjamin Mahler
\ -lsvn_delta-1 \ -lapr-1 - Original Message - From: Benjamin Mahler benjamin.mah...@gmail.com To: dev dev@mesos.apache.org Sent: Thursday, April 23, 2015 1:58:24 PM Subject: Re: Using boost filesystem These have been around 3rd party libraries

Re: Using boost filesystem

2015-04-24 Thread Benjamin Mahler
My apologies, I read your message too quickly. Tim, your snippet is not from stout, it's from libprocess' 3rdparty makefile. On Fri, Apr 24, 2015 at 11:38 AM, Benjamin Mahler benjamin.mah...@gmail.com wrote: Well, we should fix the forced linkage, it's not the intent. I assume that's what

Re: JIRA backlog grooming

2015-04-24 Thread Benjamin Mahler
Here's a link for such tickets, if you're logged in to JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%20MESOS%20AND%20status%20in%20(Open%2C%20Reopened%2C%20Accepted)%20AND%20assignee%20in%20(currentUser()) On Fri, Apr 24, 2015 at 10:47 AM, Benjamin Hindman

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

2015-04-23 Thread Benjamin Mahler
Is it worth iterating on the review at this point? Looking at the doc's comments, I can't tell if there's been consensus around the design. On Wed, Apr 22, 2015 at 7:35 AM, Alexander Rojas alexan...@mesosphere.io wrote: --- This is an

Re: Using boost filesystem

2015-04-23 Thread Benjamin Mahler
These have been around 3rd party libraries, e.g. glog, svn, protobuf, etc. Here the choice to use these external libraries is made in the code that uses stout. If they don't use protobuf, they don't include stout's protobuf header, and they don't link it in. There should be no surprise to the

Re: statusUpdate always RUNNING even after job has finished

2015-04-22 Thread Benjamin Mahler
That's a bug, the default should have been backwards compatible. Sorry for that! It's a trivial fix, Alex, can we get the fix in 0.22.1? https://issues.apache.org/jira/browse/MESOS-2643 I'll send a fix shortly. On Wed, Apr 22, 2015 at 12:42 AM, Alexander Rojas alexan...@mesosphere.io wrote:

Re: Suggestion: Mesos 0.22.1 point release

2015-04-22 Thread Benjamin Mahler
: Also, this one: https://issues.apache.org/jira/browse/MESOS-2601 This sounds like a non trivial fix. - Jie On Tue, Apr 14, 2015 at 6:35 PM, Benjamin Mahler benjamin.mah...@gmail.com wrote: Per Nik's comment here: Based on input from Vinod

Re: Suggestion: Mesos 0.22.1 point release

2015-04-22 Thread Benjamin Mahler
Linked it with the release ticket as a blocker. The fix is committed. On Wed, Apr 22, 2015 at 2:53 PM, Benjamin Mahler bmah...@twitter.com wrote: One regression in 0.22.x we missed: https://issues.apache.org/jira/browse/MESOS-2643 Here, the python bindings are not backwards compatible

Re: [jira] [Commented] (MESOS-2144) Segmentation Fault in ExamplesTest.LowLevelSchedulerPthread

2015-04-17 Thread Benjamin Mahler
Cody, your stack trace looks unrelated to the original issue here? It seems related to checkpointing in the slave. On Thu, Apr 16, 2015 at 5:02 PM, Benjamin Mahler benjamin.mah...@gmail.com wrote: Hey Cody, the 'F' failure log line was far up from the stack trace, I edited the stack trace

Re: Build failed in Jenkins: Mesos » clang,docker||Hadoop,ubuntu:14.10 #154

2015-04-17 Thread Benjamin Mahler
+jie Can you take a look? On Fri, Apr 17, 2015 at 3:51 PM, Apache Jenkins Server jenk...@builds.apache.org wrote: See https://builds.apache.org/job/Mesos/COMPILER=clang,LABEL=docker%7C%7CHadoop,OS=ubuntu%3A14.10/154/changes Changes: [vinodkone] Disable dmesg logging in jenkins build

Re: [jira] [Commented] (MESOS-2144) Segmentation Fault in ExamplesTest.LowLevelSchedulerPthread

2015-04-16 Thread Benjamin Mahler
Hey Cody, the 'F' failure log line was far up from the stack trace, I edited the stack trace to show it. On Thu, Apr 16, 2015 at 2:48 PM, Cody Maloney (JIRA) j...@apache.org wrote: [

Re: Suggestion: Mesos 0.22.1 point release

2015-04-14 Thread Benjamin Mahler
by sometime tomorrow. The spreadsheet is up-to-date, just need to cherry-pick and modify the change-log. Joris On Tue, Apr 14, 2015 at 5:37 PM, Benjamin Mahler benjamin.mah...@gmail.com wrote: Hey Nik, any progress on this? Is the spreadsheet up-to-date? On Wed, Apr 8, 2015 at 1:00 AM, Adam

Re: Suggestion: Mesos 0.22.1 point release

2015-04-14 Thread Benjamin Mahler
Hey Nik, any progress on this? Is the spreadsheet up-to-date? On Wed, Apr 8, 2015 at 1:00 AM, Adam Bordelon a...@mesosphere.io wrote: Hi Adam, Yes, once we have finalized the scope of the point release, Niklas will send out an announcement of Mesos 0.22.1-rc1 (release candidate) which we

Re: mesos git commit: Improved compile time of by adding cpp files for flag headers.

2015-04-13 Thread Benjamin Mahler
Authored: Thu Apr 9 18:24:44 2015 -0700 Committer: Benjamin Mahler benjamin.mah...@gmail.com Committed: Thu Apr 9 18:38:17 2015 -0700 -- src/Makefile.am| 3 + src/logging/flags.cpp | 51

Re: Regarding old frameworks in Mesos repository

2015-04-06 Thread Benjamin Mahler
+1 on removing deploy_jar, haproxy+apache, torque. For mesos-submit, it seems that this should instead be a mesos CLI command. On Mon, Apr 6, 2015 at 2:04 PM, Vinod Kone vinodk...@apache.org wrote: +1 On Mon, Apr 6, 2015 at 12:28 PM, Adam Bordelon a...@mesosphere.io wrote: +1 to moving

Re: bug in 0.22.0?

2015-03-31 Thread Benjamin Mahler
From the slave logs you posted here: https://gist.github.com/hgschmie/fc20b361a2cadeba0fbd The slave received updates for RUNNING followed by KILLED from the executor. The slave was only forwarding RUNNING to the master as it didn't receive an ack from the framework. Why do you think that KILLED

Re: bug in 0.22.0?

2015-03-31 Thread Benjamin Mahler
the TASK_RUNNING is still sitting in the message queue). So, if that is the case, then there are actually is no bug in Mesos. Once the framework correctly acks the messages, they are delivered correctly. -h On Tue, Mar 31, 2015 at 11:28 AM, Benjamin Mahler benjamin.mah...@gmail.com wrote: From

Re: [Style Proposal] Disallow Capture by Constant Reference to temporary

2015-03-30 Thread Benjamin Mahler
IIRC, it was when we changed Option:::get to return a const ref. Some callers of 'OptionV hashmapK,V::get()' were grabbing a const ref to the temporary coming from the option (case 1 in your markdown), and it then became a temporary to a temporary's member (case 2 in your markdown): E.g.:

Re: [Style Proposal] Disallow Capture by Constant Reference to temporary

2015-03-30 Thread Benjamin Mahler
, and things smaller than 1024 bytes most likely the copy is cheaper than any sort of reference scheme on a modern processor. On Mon, Mar 30, 2015 at 3:31 PM, Benjamin Mahler benjamin.mah...@gmail.com wrote: IIRC, it was when we changed Option:::get to return a const ref. Some callers

Re: [VOTE] Release Apache Mesos 0.22.0 (rc4)

2015-03-23 Thread Benjamin Mahler
that would be ok but not necessary IMO. I'd suggest leaving them in but when we do 0.22.1 or 0.23.0 we should try to anticipate and fix/disable any failing tests. On Mon, Mar 23, 2015 at 1:59 PM, Benjamin Mahler benjamin.mah...@gmail.com wrote: Don't think these are blockers, but they do consistently

Re: [VOTE] Release Apache Mesos 0.22.0 (rc4)

2015-03-23 Thread Benjamin Mahler
you file a JIRA for the broken test? Niklas On 21 March 2015 at 13:29, Benjamin Mahler benjamin.mah...@gmail.com wrote: On CentOS w/ gcc 4.8, make check passes but sudo make check fails for me: [ RUN ] PerfTest.ROOT_SampleInit ../../src/tests/perf_tests.cpp:147: Failure Expected

Re: [VOTE] Release Apache Mesos 0.22.0 (rc4)

2015-03-21 Thread Benjamin Mahler
On CentOS w/ gcc 4.8, make check passes but sudo make check fails for me: [ RUN ] PerfTest.ROOT_SampleInit ../../src/tests/perf_tests.cpp:147: Failure Expected: (0u) (statistics.get().cycles()), actual: 0 vs 0 ../../src/tests/perf_tests.cpp:150: Failure Expected: (0.0)

Re: Review Request 31720: MESOS-2448 add homebrew update to release guide

2015-03-10 Thread Benjamin Mahler
They should have supported # numbered lists or something other than using 1. for each item, as that reads poorly. We should optimize for readable numbered lists as opposed to diffs, is there another way to let the numbers be computed implicitly? If not, let's just number correctly to be consistent

Re: Review Request 31416: Remove extra semicolons.

2015-03-10 Thread Benjamin Mahler
, Benjamin Mahler benjamin.mah...@gmail.com wrote: Did we really need to have 3 people and 6 emails to remove some double semi-colons? I'd highly encourage us to try to avoid the pattern of drive-by reviewing when you see something that looks easy and want to jump in. We've historically

Re: Review Request 30014: Enable the slave garbage collector to take the number of links into account.

2015-03-06 Thread Benjamin Mahler
. Best Regards, On 4 March 2015 at 08:06, Benjamin Mahler benjamin.mah...@gmail.com wrote: Hey Ritwik, please hold off dealing with review comments. The current approach here still seems to be not quite what we want. In the current patch, you're speeding up garbage collection globally when

Re: Review Request 30014: Enable the slave garbage collector to take the number of links into account.

2015-03-03 Thread Benjamin Mahler
Hey Ritwik, please hold off dealing with review comments. The current approach here still seems to be not quite what we want. In the current patch, you're speeding up garbage collection globally when an individual directory has too many child directories. This approach works fine with disk usage

Re: Review Request 31416: Remove extra semicolons.

2015-02-27 Thread Benjamin Mahler
Did we really need to have 3 people and 6 emails to remove some double semi-colons? I'd highly encourage us to try to avoid the pattern of drive-by reviewing when you see something that looks easy and want to jump in. We've historically found this pattern to be very distracting and

Re: Regarding starting hacking

2015-02-25 Thread Benjamin Mahler
is to scale up actors count while not losing performance? On Tue, Feb 24, 2015 at 7:27 AM, Benjamin Mahler benjamin.mah...@gmail.com wrote: Atri, one area of benchmarking is in the area of scalability of libprocess in terms of number of actors. The Mesos master currently creates tens of thousands

Re: Review Request 31390: Added discovery info documentation.

2015-02-25 Thread Benjamin Mahler
Have you filed an INFRA ticket about that? On Wed, Feb 25, 2015 at 12:46 PM, Adam B a...@mesosphere.io wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31390/ On February 25th, 2015, 11:08 a.m. PST, *Adam B* wrote: Minor markdown tweaks,

Re: Review Request 31390: Added discovery info documentation.

2015-02-25 Thread Benjamin Mahler
Sorry, that was in reply to Adam. On Wed, Feb 25, 2015 at 2:33 PM, Christos Kozyrakis kozyr...@gmail.com wrote: If by INFRA you meant JIRA: https://issues.apache.org/jira/browse/MESOS-2396 Otherwise, I am not sure what an INFRA ticket is. On Wed, Feb 25, 2015 at 1:39 PM, Benjamin Mahler

Re: mesos-dns

2015-02-24 Thread Benjamin Mahler
Just a few curiosities after reading through this: (1) How are the A records used? Don't you also need to know the port to talk to the service? (2) For SRV records, do applications need to be updated to use DNS libraries http://linux.die.net/man/3/res_init directly? It looks like getaddrinfo()

Fwd: Review Request 31183: Distinguished resources from different slaves in DRFSorter.

2015-02-23 Thread Benjamin Mahler
+ben and vinod for more context This review fixes the issue related to aggregating 'Resources' across slaves: https://issues.apache.org/jira/browse/MESOS-2373 Today, this only works for scalars inside 'Resources' objects. For sets (and ranges, which are sets), 'Resources' will merge these as it

Re: Cutting Mesos 0.22.0 RC1

2015-02-23 Thread Benjamin Mahler
Awesome, great work! Please cut once HEAD is fixed so we can cherry pick anything that's left for 0.22.0 to prevent any further breaks. You will have to make cherry picks anyway (e.g. the CHANGELOG is incomplete). On Mon, Feb 23, 2015 at 11:14 AM, Niklas Nielsen nik...@mesosphere.io wrote: Hi

<    1   2   3   4   5   6   7   8   9   10   >