Re: Unzip should work in non interactive mode

I can shepherd it. Do you have a patch ready? - Jie On Fri, Mar 18, 2016 at 3:13 AM, Tomek Janiszewski wrote: > Hi > > Consider situation when deployed zip file is malformed and contains > duplicated files . > When fetcher downloads malformed zip file, that contains

Re: Looking for a shepherd for MESOS-4878

Shuai, thanks for the patch. Taking a look at it now. On Thu, Mar 17, 2016 at 8:30 PM, Shuai Lin wrote: > Ping. > > > On Thu, Mar 10, 2016 at 3:55 PM, Shuai Lin wrote: > >> The bug is: if a framework launches a task with mesos containerizer and a

Re: [RESULT][VOTE] Release Apache Mesos 0.27.2 (rc1)

I like the idea of using branches to manage releases. We can use that to manage point releases and backports as well. Say we want to cut 0.29.0 now, we fork a branch 0.29.0 and tag RCs in that branch. Once the RC is accepted, the head of that branch will become the release. Then, we immediate

0.28.1

Hi, We recently noticed two bugs in 0.28.0 related to the unified containerizer: Because of that, I propose we cut a point release (0.28.1) once these

Re: Looking for shepherd (MESOS-4355 - Docker Volume Isolator)

Guangya, I'd be happy to shepherd this work if no other committers volunteer for this work. - Jie On Thu, Mar 17, 2016 at 6:05 AM, Guangya Liu wrote: > Hi, > > I was now working on the FS for MESOS-4355 with some EMC guys, can anyone > help shepherd for this? There are some

Re: Backport r/44230 to 0.27 branch

art. Note that, Mesos is a fast moving project and is young. Comparing it to Linux (20+ years) is not a fair comparison. On Wed, Mar 16, 2016 at 11:44 AM, Cong Wang <cw...@twopensource.com> wrote: > On Tue, Mar 15, 2016 at 2:39 PM, Jie Yu <yujie@gmail.com> wrote: > > Mesos c

Re: Backport r/44230 to 0.27 branch

g Wang <cw...@twopensource.com> > wrote: > > > On Wed, Mar 16, 2016 at 11:58 AM, Jie Yu <yujie@gmail.com> wrote: > > > > > > Currently, it's based on request. We definitely need to improve this > > part. > > > > > > It simply doesn't

Re: [DISCUSS] Fetching Docker Images Requiring User Credentials.

ype... > } > }, > "image_credentials" : > [ > { > "image_name" : "", > "type" : "", > "credential" : > { > // Custom based on type.

Re: Backport r/44230 to 0.27 branch

6 at 2:46 PM, Jie Yu <yujie@gmail.com> wrote: > Also, I think we should fix the TODO in rmdir as well (i.e., handle > FTS_SLNONE as well as Neil suggested). > > - Jie > > On Tue, Mar 15, 2016 at 2:39 PM, Jie Yu <yujie@gmail.com> wrote: >> >> Mesos cur

Re: Backport r/44230 to 0.27 branch

Also, I think we should fix the TODO in rmdir as well (i.e., handle FTS_SLNONE as well as Neil suggested). - Jie On Tue, Mar 15, 2016 at 2:39 PM, Jie Yu <yujie@gmail.com> wrote: > Mesos currently has no notion of long term stable releases (i.e., LTS). I > think the consensus

Re: Backport r/44230 to 0.27 branch

Mesos currently has no notion of long term stable releases (i.e., LTS). I think the consensus in the last community sync was to introduce LTS after 1.0. 0.27.2 has already been released. Looks like we need 0.27.3 if we want to backport it. I am OK with back porting it. Then the question is that

Re: [DISCUSS] Fetching Docker Images Requiring User Credentials.

> > Yeah I was thinking having the JSON as a dictionary with keys being the > registry URI (appc/docker) and the values being credentials (which will be > a dictionary as well I guess). Using registry URI as the key is problematic. Think about the public docker hub. Different frameworks might

Re: RFC: RevocableInfo Changes

> > Just a quick note: Ian D. and the performance isolation working group are > discussing similar annotations and we should meet and talk about the > options. +1 Would love to understand the relationship between this and the task/executor level annotations. - Jie On Mon, Mar 14, 2016 at 9:29

Re: mesos git commit: Add 'name' field into NetworkInfo.

t; > Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/2a436e02 > > > > Branch: refs/heads/master > > Commit: 2a436e02f7f475e2d7264c6a4b58dd557bfec883 > > Parents: 57a574f > > Author: Qian Zhang <zhang

Re: Executors no longer inherit environment variables from the agent

Alex, See my response inlined: First, does this change include the executor library? We currently use > environment variables to propagate various config values from an agent to > executors. If it does, what is the alternative? Any environment variables generated by Mesos (i.e., MESOS_,

Re: [VOTE] Release Apache Mesos 0.28.0 (rc1)

I'd like to fix https://issues.apache.org/jira/browse/MESOS-4888 as well if you guys plan to cut another RC On Mon, Mar 7, 2016 at 10:16 AM, Daniel Osborne < daniel.osbo...@metaswitch.com> wrote: > -1 > > If it doesn’t cause too much pain, I'm hoping we can squeeze a relatively > small patch

Re: [VOTE] Release Apache Mesos 0.28.0 (rc1)

Steven, sorry about the delay. I'll finish the doc today. On Fri, Mar 4, 2016 at 10:29 AM, Steven Schlansker < sschlans...@opentable.com> wrote: > > > On Mar 3, 2016, at 5:43 PM, Vinod Kone wrote: > > > > Hi all, > > Please vote on releasing the following candidate as

Re: Making 'curl' a prerequisite for installing Mesos

gt; >>> +1 to add 'curl' dependency firstly. > >>> > >>> > >>> Da (Klaus), Ma (马达) | PMP® | Advisory Software Engineer > >>> Platform OpenSource Technology, STG, IBM GCG > >>> +86-10-8245 4084 | klaus1982...@gmail.com | http://k8

Re: [VOTE] Release Apache Mesos 0.28.0 (rc1)

I am writing that as you speaking On Fri, Mar 4, 2016 at 10:34 AM, Vinod Kone wrote: > I think this was supposed to refer to > https://github.com/apache/mesos/blob/master/docs/mesos-containerizer.md > > @Jie ^^ ? > > On Fri, Mar 4, 2016 at 10:29 AM, Steven Schlansker < >

Re: Making 'curl' a prerequisite for installing Mesos

xx() APIs explored? > > Neil > > On Thu, Mar 3, 2016 at 9:10 AM, Jie Yu <yujie@gmail.com> wrote: > > Hi, > > > > I am proposing making 'curl' a prerequisite when installing Mesos. > > Currently, we require 'libcurl' being present when installing Mesos >

Making 'curl' a prerequisite for installing Mesos

Hi, I am proposing making 'curl' a prerequisite when installing Mesos. Currently, we require 'libcurl' being present when installing Mesos ( http://mesos.apache.org/gettingstarted/). However, we found that it does not compose well with our asynchronous runtime environment (i.e., it'll block the

Re: Reorganize 3rdparty directory

> > However, in the current code base, we don't strictly follow the 3rdparty > structure. For example, stout has a dependency on picojson and > google-protobuf, but we don't put these two packages inside > 3rdparty/libprocess/3rdparty/stout/3rdparty/. My understanding is that stout is header

Re: Reorganize 3rdparty directory

n the original email is that "in the current code base, we don't strictly follow the 3rdparty structure", which IMO is not a very convincing reason for such a big change. - Jie On Tue, Feb 9, 2016 at 5:04 PM, Kapil Arya <ka...@mesosphere.io> wrote: > On Tue, Feb 9, 2016 at 7:20

Re: [4/4] mesos git commit: Added `Resources::size()`.

maybe add a comment saying that size() is only used for testing. - Jie On Fri, Feb 5, 2016 at 6:07 PM, Michael Park wrote: > I also spoke to Jie about this issue, and he agreed that it'd be better to > expose the `size` rather than people trying to compute it manually. > > On

Re: [RESULT][VOTE] Release Apache Mesos 0.27.0 (rc2)

Niklas, I think Joris is still working on the user doc for multi-disk support in Mesos. - Jie On Thu, Feb 4, 2016 at 1:22 AM, Niklas Nielsen wrote: > Awesome guys! > > Kapil, we usually linked to the user documentation in the blog to the new > features. Do you have a link to the

Re: [3/3] mesos git commit: Plugged in docker runtime isolator.

/repos/asf/mesos/diff/0b0a3dc5 > > > > Branch: refs/heads/master > > Commit: 0b0a3dc5467224511b1963dd0ac530bca7506376 > > Parents: 2d5d14f > > Author: Gilbert Song <songzihao1...@gmail.com> > > Authored: W

Re: mesos git commit: Fixed posix filesystem isolator to not allow executors with image.

James, this is for filesystem/posix isolator, and has nothing to do with posix/disk isolator. Also, this has nothing to do with persistent volumes. - Jie On Wed, Jan 6, 2016 at 8:03 PM, James Peach wrote: > > > On Jan 6, 2016, at 7:44 PM, Timothy Chen

Re: `F()` vs `F(void)`

+1 On Sun, Dec 13, 2015 at 10:46 AM, Michael Park wrote: > Hello, > > In the C++ world, the *void* parameter is considered to be only there for C > compatibility reasons. > > We do a good job of not using *void *parameters in function declarations, > e.g., *void F();*. On the

Re: Fetcher refactor proposal

Thanks guys! Created an Epic (MESOS-3918 <https://issues.apache.org/jira/browse/MESOS-3918>) to track. On Wed, Nov 11, 2015 at 2:31 AM, Bernd Mathiske <be...@mesosphere.io> wrote: > +1 - go for it! > > > On Nov 11, 2015, at 12:45 AM, Jie Yu <yujie@g

Fetcher refactor proposal

Hi, Fetcher was originally designed to fetch CommandInfo::URIs (e.g., executor binary) for executors/tasks. A recent refactor (MESOS-336 ) added caching support to the fetcher. The recent work on filesystem isolation/unified containerizer (

Re: Fetcher refactor proposal

ect things like the > executable/extract bits that are available in the existing fetcher? Would > that logic move outside of the fetcher itself, or would it live on the URI? > > I’m not sure if I’ve missed something in the design doc about this, but it > came to mind… > > Tom. > >

Re: Filesystem isolator test fail

Can you create a ticket with full verbose logging. Which test are you running? Which version are you using? Thanks, - Jie On Fri, Nov 6, 2015 at 9:27 PM, Vaibhav Khanduja wrote: > On my build setup (using vagrant ubuntu), I am seeing filesystem isolator > test fail

Re: Welcome Kapil as Mesos committer and PMC member!

Congrats Kapil! On Thu, Nov 5, 2015 at 2:02 AM, Till Toenshoff wrote: > I'm happy to announce that Kapil Arya has been voted a Mesos committer and > PMC member! > > Welcome Kapil, and thanks for all of your great contributions to the > project so far! > > Looking forward to

Re: Apache Mesos Community Sync

Adam, since most of the Twitter folks are OOO this week. I chatted with Artem/Vinod. we think it makes sense to host the sync at Mesosphere tomorrow. - Jie On Wed, Nov 4, 2015 at 4:22 PM, Adam Bordelon wrote: > It's been a while since our last community sync, and tomorrow,

Re: Removing external containerizer from code base

. > > Tim > > On Mon, Oct 12, 2015 at 12:04 AM, tommy xiao <xia...@gmail.com> wrote: > > HI Jie Yu, > > > > https://issues.apache.org/jira/browse/MESOS-3435 in this proposal, i > sure > > the hyper is new containerizer, Does this can implement as a m

Re: Removing external containerizer from code base

nd the > option to use ECP seemed attractive. > Can you, please, elaborate on the implications of having our own > containerizer without ECP? I assume we would have to implement it in cpp, > it might require recompiling (parts of) Mesos, some other things? > > Thanks, > Alex

Re: Removing external containerizer from code base

t;glik...@il.ibm.com> wrote: > Thanks Jie, this sounds promising, but I don't see 'containerizer' as one > of the supported module types listed in the documentation.. > Can you, please, clarify? > > Thanks, > Alex > > > > > From: Jie Yu <yujie@gmail.com> &g

Removing external containerizer from code base

Hey guys, Per discussion in MESOS-3370 , I'll start removing the external containerizer and cleaning up the relevant code. Please let me know if you have any concern. Thanks! - Jie

Re: [jira] [Created] (MESOS-3498) Failed to create a containerizer

+ Kapil On Tue, Sep 22, 2015 at 5:59 PM, Rafael Capucho (JIRA) wrote: > Rafael Capucho created MESOS-3498: > - > > Summary: Failed to create a containerizer > Key: MESOS-3498 > URL:

Re: [5/5] mesos git commit: Integer Precision for JSON <-> Protobuf conversions.

Joris, It breaks the build: picojson-1.3.0/picojson.h: In member function ‘std::string picojson::value::to_str() const’: picojson-1.3.0/picojson.h:370:38: error: expected ‘)’ before ‘PRId64’ SNPRINTF(buf, sizeof(buf), "%" PRId64, u_.int64_); On Wed, Sep 16, 2015 at 2:56 PM,

Re: [VOTE] Release Apache Mesos 0.24.0 (rc1)

Niklas, This is the known problem reported by Marco. I am OK with both because the linux filesystem isolator cannot be used in 0.24.0. If you guys prefer to cut another RC, here is the patch that needs to be cherry picked: commit 3ecd54320397c3a813d555f291b51778372e273b Author: Greg Mann

Re: [VOTE] Release Apache Mesos 0.24.0 (rc1)

: If it is that easy to fix, why not get it in? How about https://issues.apache.org/jira/browse/MESOS-3053 (which Haosdent ran into)? On 27 August 2015 at 15:36, Jie Yu yujie@gmail.com wrote: Niklas, This is the known problem reported by Marco. I am OK with both because the linux

Re: Mesos Developer Community Design Discussions

Periscope? On Mon, Aug 10, 2015 at 4:41 PM, Timothy Anderegg timothy.ander...@gmail.com wrote: Live stream for folks who won't be there would be great, thanks! Tim On Mon, Aug 10, 2015 at 7:09 PM, Benjamin Hindman b...@eecs.berkeley.edu wrote: The spreadsheet has been updated, sorry

Re: Resource Estimator

Tiago, ResourceEstimator is used for oversubscription and is irrelevant ( https://github.com/apache/mesos/blob/master/docs/oversubscription.md) The logic of estimating available resources on a slave is here:

Re: [DISCUSS] Renaming Mesos Slave

Adam, If a vote is called out, how do we decide if it passes or not. Will that be the same of voting for a release (i.e., PMC member can veto it)? I would imagine that some PMC members might want to express some negative feedbacks on this, but certainly do not want to veto it. How do we deal

Re: [DISCUSS] Renaming Mesos Slave

any change may have on any adopter/organization and discuss those risks and problems openly, but ideally this decision would be made based upon consensus within the community. If consensus cannot be reached, a vote among committers may be necessary. Dave On Wed, Jun 3, 2015, at 08:52 AM, Jie

Please update your customized reviewboardrc

Hi, I recently modified the post-reviews.py script so that we can configure the tracking branch when posting reviews. I also moved a few hard coded constants (e.g., REPOSITORY_URL) to reviewboardrc so that they are configurable too. If you are not using a customized reviewboardrc (i.e., relying

Re: Enabling 'network' namespace for custom network isolators

Yes. The simplest (cleanest?) way that I see would be to refactor the launcher to take the desired flags when executing the executor, i.e., (Linux)Launcher::fork() takes the namespace flags. The launcher would be directed which namespaces to create by the caller, not inferring them itself

Re: Suggestion: Mesos 0.22.1 point release

Hindman b...@eecs.berkeley.edu wrote: Yes, fixing it in 0.23.0 SGTM. On Tue, Apr 14, 2015 at 10:02 PM, Jie Yu yujie@gmail.com wrote: I am just asking if you guys want to fix that for 0.22.1 or not. It sounds to me a non trivial fix. Given the bug is there for quite a while

Re: Suggestion: Mesos 0.22.1 point release

Tim's patch cause a few compiler warnings. I committed a fix (just added to the spreadsheet). On Fri, Apr 24, 2015 at 2:35 PM, Jie Yu j...@twitter.com wrote: Now that MESOS-2601 has landed, shall we include it in 0.22.1(-rc5) too? +1 On Fri, Apr 24, 2015 at 2:34 PM, Adam Bordelon

Review Request 33413: Changed the isolator recover interface to take a set of orphan containers detected by the launcher.

/33413/diff/ Testing --- make check Thanks, Jie Yu

Review Request 33412: Made the launcher recover interface to return a set of orphan containers.

://reviews.apache.org/r/33412/diff/ Testing --- make check Thanks, Jie Yu

Review Request 33414: Made MesosContainerizer not fail on recovery if the destroy of orphan containers fails.

src/slave/containerizer/mesos/containerizer.cpp e4136095fca55637864f495098189ab3ad8d8fe7 Diff: https://reviews.apache.org/r/33414/diff/ Testing --- make check Thanks, Jie Yu

Review Request 33415: Changed launchers and isolators to adapt to the new orphan cleanup semantics.

is exercised by the exiting test: PortMappingMesosTest.ROOT_CleanUpOrphanTest Thanks, Jie Yu

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

/TASK_FAILED). Or am I missing something? - Jie Yu On April 21, 2015, 5:14 p.m., Jay Buffington wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33249

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

On April 21, 2015, 11:25 p.m., Jie Yu wrote: src/slave/slave.cpp, lines 3065-3078 https://reviews.apache.org/r/33249/diff/3/?file=938221#file938221line3065 Instead of doing that in your way, can we just try to make sure `containerizer-wait` here will return a failure

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

On April 21, 2015, 11:25 p.m., Jie Yu wrote: src/slave/slave.cpp, lines 3065-3078 https://reviews.apache.org/r/33249/diff/3/?file=938221#file938221line3065 Instead of doing that in your way, can we just try to make sure `containerizer-wait` here will return a failure

Re: Review Request 33329: Removed unnecessary freeaddrinfo in getIP if getaddrinfo returns error.

https://reviews.apache.org/r/33329/#comment130863 +1 - Jie Yu On April 18, 2015, 12:35 a.m., Chi Zhang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33329

Re: Review Request 33257: Fixed recover tasks only by the intiated containerizer.

/docker_containerizer_tests.cpp https://reviews.apache.org/r/33257/#comment130897 Ditto on naming. s/exec/executor/ src/tests/docker_containerizer_tests.cpp https://reviews.apache.org/r/33257/#comment130898 Set the frameworkId? - Jie Yu On April 17, 2015, 7:07 p.m., Timothy Chen wrote

Re: Build failed in Jenkins: Mesos » clang,docker||Hadoop,ubuntu:14.10 #154

double free @@ On Fri, Apr 17, 2015 at 3:56 PM, Benjamin Mahler bmah...@twitter.com wrote: +jie Can you take a look? On Fri, Apr 17, 2015 at 3:51 PM, Apache Jenkins Server jenk...@builds.apache.org wrote: See

Re: Suggestion: Mesos 0.22.1 point release

Also, this one: https://issues.apache.org/jira/browse/MESOS-2601 This sounds like a non trivial fix. - Jie On Tue, Apr 14, 2015 at 6:35 PM, Benjamin Mahler benjamin.mah...@gmail.com wrote: Per Nik's comment here: Based on input from Vinod and Adam; I will reduce the scope on the point

Re: Suggestion: Mesos 0.22.1 point release

(it's a really trivial fix). Jie, where did you get MESOS-2601 from? That's definitely not in the spreadsheet. On Tue, Apr 14, 2015 at 7:40 PM, Jie Yu yujie@gmail.com wrote: Also, this one: https://issues.apache.org/jira/browse/MESOS-2601 This sounds like a non trivial fix

Re: Review Request 32891: Support for entering and configuring a Linux chroot.

;... - Jie Yu On April 6, 2015, 6 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32891/ --- (Updated April 6, 2015

Re: Review Request 32891: Support for entering and configuring a Linux chroot.

Copy comments from the other review, can you support `Optionstring options` for fs::mount as well? - Jie Yu On April 6, 2015, 6 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

://reviews.apache.org/r/31444/#comment129660 Do you still need this? src/tests/launch_tests.cpp https://reviews.apache.org/r/31444/#comment129657 Add one more blank line above. - Jie Yu On April 8, 2015, 3:24 p.m., Ian Downes wrote

Re: Review Request 32978: Add os::stat::inode to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32978/#review79961 --- Ship it! Ship It! - Jie Yu On April 8, 2015, 3:24 p.m., Ian

Re: Review Request 33040: Expose qdisc statistics from libnl

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33040/#review79742 --- Could you please create a diff with master branch please? - Jie Yu

Re: Review Request 33040: Expose qdisc statistics from libnl

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33040/#review79743 --- Seems that it's still not rebased. - Jie Yu On April 10, 2015, 7

Re: Review Request 32984: Added an example framework for testing persistent volumes.

--- On April 8, 2015, 7:08 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32984

Re: Review Request 33040: Expose qdisc statistics from libnl

::string, uint64_t results; for(int i = 0; i (int) RTNL_TC_STATS_MAX; i++) { results[names[i]] = rtnl_tc_get_stat( TC_CAST(qdisc.get().get(), (rtnl_tc_stat) i); } return results; ``` - Jie Yu On April 10, 2015, 11:17 p.m., Paul Brett wrote

Review Request 32983: Fixed a bug regarding setting work_dir for a local cluster.

Description --- Fixed a bug regarding setting work_dir for a local cluster. Diffs - src/local/local.cpp 19083368212b24ce1afef3a5f91d48766d1cd55e Diff: https://reviews.apache.org/r/32983/diff/ Testing --- make check Thanks, Jie Yu

Review Request 32984: Added an example framework for testing persistent volumes.

/examples_tests.cpp 5222b6d5e66736495b743367b5731bb9094410fd src/tests/persistent_volume_framework_test.sh PRE-CREATION Diff: https://reviews.apache.org/r/32984/diff/ Testing --- make check Thanks, Jie Yu

Re: Review Request 32955: Simplified ROOT_CGROUPS_Listen test.

://reviews.apache.org/r/32955/#comment128705 Any reason you want to remove this? src/tests/cgroups_tests.cpp https://reviews.apache.org/r/32955/#comment128703 Use AWAIT_READY? - Jie Yu On April 8, 2015, 2:29 a.m., Chi Zhang wrote

Re: Review Request 32139: Add 'Resource::ReservationInfo' protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32139/#review79404 --- Ship it! Ship It! - Jie Yu On April 7, 2015, 9:52 p.m., Michael

Re: Review Request 32984: Added an example framework for testing persistent volumes.

check Thanks, Jie Yu

Re: Review Request 32398: Persist the reservation state on the slave.

want to say something about persitent volumes in the comment?:) src/tests/reservation_tests.cpp https://reviews.apache.org/r/32398/#comment128842 compatible or not compatible? - Jie Yu On April 8, 2015, 6:38 p.m., Michael Park wrote

Re: Review Request 32149: Enable 'Resources::apply' to handle reservation operations.

/#comment128786 Do you need to call validate(operation.reserve().resources()) first (like we did in CREATE/DESTROY)? Do you also want to check if each resource is dynamically reserved (i.e., has ReservationInfo, role != `*`)? - Jie Yu On April 7, 2015, 10:25 p.m., Michael Park wrote

Re: Review Request 32140: Enable 'Resources' to handle 'Resource::ReservationInfo'.

of this function becomes a little weired now. For example, for a resource that has `role == *` and has reservation set, `isReserved(resource, *)` is going to return `true`? Given that 'resource' is invalid, we should return a `false` in that case? - Jie Yu On April 7, 2015, 9:56 p.m

Review Request 32820: Fixed the non-POD global variable in perf sampler.

Description --- Fixed the non-POD global variable in perf sampler. Diffs - src/linux/perf.cpp cad6c80e2a9608ff02fc2b8976efba52713dd5a8 Diff: https://reviews.apache.org/r/32820/diff/ Testing --- make check Thanks, Jie Yu

Re: Review Request 32805: Terminated the perf subprocess once the parent exits.

/perf.cpp cad6c80e2a9608ff02fc2b8976efba52713dd5a8 Diff: https://reviews.apache.org/r/32805/diff/ Testing --- sudo make check I also manually verified it by terminating the slave while perf is in progress. The perf is killed immediately. Thanks, Jie Yu

Re: Review Request 32820: Fixed the non-POD global variable in perf sampler.

next week. - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32820/#review78829 --- On April 3, 2015, 5:01 p.m., Jie Yu wrote

Re: Review Request 32805: Terminated the perf subprocess once the parent exits.

immediately. Thanks, Jie Yu

Re: Review Request 32805: Terminated the perf subprocess once the parent exits.

/perf.cpp cad6c80e2a9608ff02fc2b8976efba52713dd5a8 Diff: https://reviews.apache.org/r/32805/diff/ Testing --- sudo make check I also manually verified it by terminating the slave while perf is in progress. The perf is killed immediately. Thanks, Jie Yu

Review Request 32833: Added os::signals::install to install signal handlers.

--- Added os::signals::install to install signal handlers. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp 30232f50cc72a79acd21499fe7602c9bcd624ff6 Diff: https://reviews.apache.org/r/32833/diff/ Testing --- Tested in the later patch. Thanks, Jie Yu

Review Request 32805: Terminated the perf subprocess once the parent exits.

cad6c80e2a9608ff02fc2b8976efba52713dd5a8 Diff: https://reviews.apache.org/r/32805/diff/ Testing --- sudo make check I also manually verified it by terminating the slave while perf is in progress. The perf is killed immediately. Thanks, Jie Yu

Re: Review Request 32694: Set death signal for forked du processes for posix/disk isolator.

--- On April 1, 2015, 7:40 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32694/ --- (Updated

Re: Review Request 32653: Replace busy loop on ready file with a more relaxed loop

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32653/#review78666 --- Ship it! Ship It! - Jie Yu On April 1, 2015, 11 p.m., Paul

Re: Review Request 32698: Used the argv version of subprocess for linux perf utilities.

--- On April 1, 2015, 7:40 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32698/ --- (Updated April

Re: Review Request 32654: Clean up HostIPNetwork since every use performs the same extract stringify operation

https://reviews.apache.org/r/32654/#comment127613 hostIPNetwork.get().address() returns an net::IP, why do you need an extra copy constructor? ``` hostIP = hostIPNetwork.get().address(); ``` - Jie Yu On April 1, 2015, 11:07 p.m., Paul Brett wrote

Re: Review Request 32744: PortMapping: change to not host namespace symlink handles in /var/run/netns.

/slave/containerizer/isolators/network/port_mapping.cpp https://reviews.apache.org/r/32744/#comment127591 Ditto. - Jie Yu On April 1, 2015, 10:36 p.m., Chi Zhang wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 32699: Set death signal for the perf subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32699/#review78678 --- On March 31, 2015, 8:14 p.m., Jie Yu wrote

Re: Review Request 32699: Set death signal for the perf subprocess.

the processes in a process group and use -SIGKILL as the DEATHSIG. Depending on how this was implemented, this might signal the entire process group? Jie Yu wrote: I checked the kernel code. This won't work. ::kill(-pid, SIGKILL) is the one that kill a process group (not ::kill(pid, -SIGKILL

Re: Review Request 32728: Fixed indentation in mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32728/#review78543 --- Ship it! Thanks! - Jie Yu On April 1, 2015, 5:16 p.m., Chi

Re: Review Request 32694: Set death signal for forked du processes for posix/disk isolator.

/posix/disk.cpp 6e41e2a72cdcf914f2c922fdcb3d267b938e456e Diff: https://reviews.apache.org/r/32694/diff/ Testing --- make check Thanks, Jie Yu

Re: Review Request 32698: Used the argv version of subprocess for linux perf utilities.

signal patch. Diffs (updated) - src/linux/perf.cpp 863aa4a972289a59f57e93cd06ba2bf9df949fe2 Diff: https://reviews.apache.org/r/32698/diff/ Testing --- sudo make check Thanks, Jie Yu

Re: Review Request 32694: Set death signal for forked du processes for posix/disk isolator.

-mail. To reply, visit: https://reviews.apache.org/r/32694/#review78526 --- On March 31, 2015, 7:32 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 32694: Set death signal for forked du processes for posix/disk isolator.

--- On March 31, 2015, 7:32 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32694/ --- (Updated

Re: Review Request 32654: Clean up HostIPNetwork since every use performs the same extract stringify operation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32654/#review78585 --- The diff does seem to be correct. - Jie Yu On April 1, 2015, 8

Review Request 32742: Added command logging for processes running in slave's cgroup.

--- make check Thanks, Jie Yu

Re: Review Request 32653: Replace busy look on ready file with a more relaxed loop

/port_mapping_tests.cpp https://reviews.apache.org/r/32653/#comment127512 s/Seconds(0)/Duration::zero()/ - Jie Yu On April 1, 2015, 8:54 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https

<    1   2   3   4   5   6   7   8   9   10   >