Re: MESOS-5731 Add metric types to GetMetrics v1 api

2016-07-11 Thread Tuan-Anh Hoang-Vu
e, you could have > a histogram of response sizes. > > On Fri, Jul 8, 2016 at 3:32 PM, Tuan-Anh Hoang-Vu <hvtuan...@gmail.com> > wrote: > > > Hi all, > > > > I've finished implementing and testing this issue > > https://issues.apache.org/jira/browse/MESOS-

MESOS-5731 Add metric types to GetMetrics v1 api

2016-07-08 Thread Tuan-Anh Hoang-Vu
Hi all, I've finished implementing and testing this issue https://issues.apache.org/jira/browse/MESOS-5731 and would like to find a shepherd for my patch. Should I go ahead and submit the patch? Following Vinod's suggestion, I've changed Response::GetMetrics in master.proto and v1/master.proto

Re: Extend HTTP Endpoint to allow querying for metric types

2016-07-06 Thread Tuan-Anh Hoang-Vu
I am currently working on this. Could someone assign me this JIRA issue? https://issues.apache.org/jira/browse/MESOS-5731 On Tue, Jun 28, 2016 at 10:43 AM, Tuan-Anh Hoang-Vu <hvtuan...@gmail.com> wrote: > Sounds great! I'll spend time working on this. > > On Mon, Jun 27, 2016 at

Re: Extend HTTP Endpoint to allow querying for metric types

2016-06-28 Thread Tuan-Anh Hoang-Vu
Sounds great! I'll spend time working on this. On Mon, Jun 27, 2016 at 10:41 PM, Vinod Kone <vi...@mesosphere.io> wrote: > v1 API is not yet declared stable, so we can make changes before 1.0. > > On Mon, Jun 27, 2016 at 10:10 PM, Tuan-Anh Hoang-Vu <hvtuan...@gmail.com> &g

Re: Extend HTTP Endpoint to allow querying for metric types

2016-06-27 Thread Tuan-Anh Hoang-Vu
`` > GetMetrics { > repeated Metric gauges = 1; > repeated Metric counters = 2; > } > ``` > > On Mon, Jun 27, 2016 at 6:27 PM, Tuan-Anh Hoang-Vu <hvtuan...@gmail.com> > wrote: > > > Timer will simply measure the amount of time it takes (in ns) for an > > operati

Re: Extend HTTP Endpoint to allow querying for metric types

2016-06-27 Thread Tuan-Anh Hoang-Vu
Timer will simply measure the amount of time it takes (in ns) for an operation. On Mon, Jun 27, 2016 at 6:14 PM, Benjamin Mahler <bmah...@apache.org> wrote: > What is the timer type? Is it effectively a special case of a histogram? > > On Mon, Jun 27, 2016 at 5:34 PM, Tuan-Anh H

Re: Extend HTTP Endpoint to allow querying for metric types

2016-06-27 Thread Tuan-Anh Hoang-Vu
cs collection system understands? The > > types that seem to show up consistently are counter, gauges, and > > histograms. > > > > [1] https://prometheus.io/docs/concepts/metric_types/ > > [2] http://docs.datadoghq.com/guides/metrics/ > > > > On Mon, Jun 27, 2

Re: Extend HTTP Endpoint to allow querying for metric types

2016-06-27 Thread Tuan-Anh Hoang-Vu
/metrics/ > > On Mon, Jun 27, 2016 at 4:37 PM, Tuan-Anh Hoang-Vu <hvtuan...@gmail.com> > wrote: > > > Hi Vinod, > > > > Yes, my metric collection system need to distinguish between different > > metrics. > > Currently we hard coded all metric typ

Re: Extend HTTP Endpoint to allow querying for metric types

2016-06-27 Thread Tuan-Anh Hoang-Vu
, Jun 27, 2016 at 4:31 PM, Vinod Kone <vinodk...@apache.org> wrote: > Hey Tuan. Can I ask what you are trying to accomplish here? Does your > metric collection system need to distinguish between different metrics? > > On Mon, Jun 27, 2016 at 10:35 AM, Tuan-Anh Hoang-Vu <hvtuan.

Extend HTTP Endpoint to allow querying for metric types

2016-06-27 Thread Tuan-Anh Hoang-Vu
Hello, I am planning to extend current metrics endpoint (/metrics/snapshot) to only return a specific type of metrics (either counter, gauge or timer). It would be great if I can get feedback from you if this is worth pursuing, or there is an existing solution, or my implementation plan is sound.