[GitHub] mesos pull request #295: Implementation of JWK

2018-06-02 Thread clems4ever
Github user clems4ever closed the pull request at: https://github.com/apache/mesos/pull/295 ---

[GitHub] mesos pull request #295: Implementation of JWK

2018-06-02 Thread clems4ever
GitHub user clems4ever opened a pull request: https://github.com/apache/mesos/pull/295 Implementation of JWK You can merge this pull request into a Git repository by running: $ git pull https://github.com/clems4ever/mesos jwk Alternatively you can review and apply

[GitHub] mesos issue #284: Remove accent from first name of clems4ever contributor.

2018-04-20 Thread clems4ever
Github user clems4ever commented on the issue: https://github.com/apache/mesos/pull/284 @bbannier , apparently apply-review.py retrieves data from the profile in the review board. I updated my profile and now the author is correct (I mean without accent). Thank you for the help. ---

[GitHub] mesos pull request #284: Remove accent from first name of clems4ever contrib...

2018-04-20 Thread clems4ever
Github user clems4ever closed the pull request at: https://github.com/apache/mesos/pull/284 ---

[GitHub] mesos issue #284: Remove accent from first name of clems4ever contributor.

2018-04-20 Thread clems4ever
Github user clems4ever commented on the issue: https://github.com/apache/mesos/pull/284 @andschwa , no problem. Do you have the rights to merge it? ---

[GitHub] mesos issue #284: Remove accent from first name of clems4ever contributor.

2018-04-19 Thread clems4ever
Github user clems4ever commented on the issue: https://github.com/apache/mesos/pull/284 Thank you guys for your feedbacks. Since it might take some time to rewrite the script in Python 3 I think it's better to merge this PR so that I can move forward with my review in the review

[GitHub] mesos issue #284: Remove accent from first name of clems4ever contributor.

2018-04-19 Thread clems4ever
Github user clems4ever commented on the issue: https://github.com/apache/mesos/pull/284 Apparently the character `\xe9` is `é` as stated here: https://stackoverflow.com/questions/6327494/what-is-the-following-unicode-string-xe9. So, I really think this is due to my first name. ---

[GitHub] mesos issue #284: Remove accent from first name of clems4ever contributor.

2018-04-19 Thread clems4ever
Github user clems4ever commented on the issue: https://github.com/apache/mesos/pull/284 @bmahler , here is the error: ---

[GitHub] mesos pull request #281: Add alg RS256 support for JWT generator and validat...

2018-04-17 Thread clems4ever
Github user clems4ever closed the pull request at: https://github.com/apache/mesos/pull/281 ---

[GitHub] mesos issue #281: Add alg RS256 support for JWT generator and validator.

2018-04-17 Thread clems4ever
Github user clems4ever commented on the issue: https://github.com/apache/mesos/pull/281 Closing this PR since reviews are in the review board. ---

[GitHub] mesos issue #284: Remove accent from first name of clems4ever contributor.

2018-04-17 Thread clems4ever
Github user clems4ever commented on the issue: https://github.com/apache/mesos/pull/284 Hello @tillt , there is an issue with the review bot applying my review: https://reviews.apache.org/r/66621/. I think it is due to the accent in my first name. So, I created this review

[GitHub] mesos pull request #284: Remove accent from first name of clems4ever contrib...

2018-04-17 Thread clems4ever
GitHub user clems4ever opened a pull request: https://github.com/apache/mesos/pull/284 Remove accent from first name of clems4ever contributor. Review bot fails to apply reviews (with ./support/apply-review.py script) because of the accent in my first name. You can merge this pull

[GitHub] mesos issue #281: Add alg RS256 support for JWT generator and validator.

2018-04-14 Thread clems4ever
Github user clems4ever commented on the issue: https://github.com/apache/mesos/pull/281 @tilt, here you go: https://reviews.apache.org/r/66621/. ---

[GitHub] mesos issue #281: Add alg RS256 support for JWT generator and validator.

2018-04-14 Thread clems4ever
Github user clems4ever commented on the issue: https://github.com/apache/mesos/pull/281 @tilt, yes, large diff because I refactored a bit and added as many tests as there are for HS256. :) ---

[GitHub] mesos issue #281: Add alg RS256 support for JWT generator and validator.

2018-04-14 Thread clems4ever
Github user clems4ever commented on the issue: https://github.com/apache/mesos/pull/281 @tilt, what do you mean? There are tests in the commit already. ---

[GitHub] mesos issue #281: Add alg RS256 support for JWT generator and validator.

2018-04-14 Thread clems4ever
Github user clems4ever commented on the issue: https://github.com/apache/mesos/pull/281 @tillt , no pb, I will create a review in the review board now. Thanks. ---

[GitHub] mesos issue #281: Add alg RS256 support for JWT generator and validator.

2018-04-14 Thread clems4ever
Github user clems4ever commented on the issue: https://github.com/apache/mesos/pull/281 Hello @tillt , thank you for having a look. Don't you need to merge the following PR to make me a contributor: https://github.com/apache/mesos/pull/282/commits? ---

[GitHub] mesos issue #281: Add alg RS256 support for JWT generator and validator.

2018-04-14 Thread clems4ever
Github user clems4ever commented on the issue: https://github.com/apache/mesos/pull/281 Since this change is not really trivial, I will go through the contributing process. I'm currently creating my accounts. ---

[GitHub] mesos pull request #281: Add alg RS256 support for JWT generator and validat...

2018-04-14 Thread clems4ever
GitHub user clems4ever opened a pull request: https://github.com/apache/mesos/pull/281 Add alg RS256 support for JWT generator and validator. Currently, the JWT library only support creating and validating HS256 tokens. I implemented the creation and validation of RS256 tokens