Re: Collect feedbacks on TASK_FINISHED

2017-09-24 Thread Qian Zhang
Thanks Vinod and James! So I think the task state transition TASK_KILLING -> TASK_FINISHED is a bug, we should change it to TASK_KILLING -> TASK_KILLED. Regards, Qian Zhang On Fri, Sep 22, 2017 at 3:27 PM, James Peach wrote: > > > On Sep 21, 2017, at 10:12 PM, Vinod Kone

Re: Collect feedbacks on TASK_FINISHED

2017-09-22 Thread James Peach
> On Sep 21, 2017, at 10:12 PM, Vinod Kone wrote: > > I think it makes sense for `TASK_KILLED` to be sent in response to a KILL > call irrespective of the exit status. IIRC, that was the original intention. Those are the semantics we implement and expect in our scheduler

Re: Collect feedbacks on TASK_FINISHED

2017-09-21 Thread Vinod Kone
I think it makes sense for `TASK_KILLED` to be sent in response to a KILL call irrespective of the exit status. IIRC, that was the original intention. On Thu, Sep 21, 2017 at 8:20 PM, Qian Zhang wrote: > Hi Folks, > > I'd like to collect the feedbacks on the task state

Collect feedbacks on TASK_FINISHED

2017-09-21 Thread Qian Zhang
Hi Folks, I'd like to collect the feedbacks on the task state TASK_FINISHED. Currently the default and command executor will always send TASK_FINISHED as long as the exit code of task is 0, this cause an issue: when scheduler initiates a kill task, the executor will send SIGTERM to the task