Re: Collecting futures in the same actor in libprocess

2018-03-01 Thread Benjamin Mahler
Chatted offline with Chun and Meng and suggested we take an explicit approach of using process::Sequence to ensure ordered task delivery (this would need to be done both in the master and agent). On Thu, Mar 1, 2018 at 1:17 PM, Chun-Hung Hsiao wrote: > Some background for

Re: Collecting futures in the same actor in libprocess

2018-03-01 Thread Chun-Hung Hsiao
Some background for the bug AlexR and Meng found: In https://issues.apache.org/jira/browse/MESOS-1720, we introduce an ordering dependency between two `LAUNCH`/`LAUNCH_GROUP` calls to a new executor. The master would specify that the first call is the one to launch a new executor through the

Re: Collecting futures in the same actor in libprocess

2018-03-01 Thread Benjamin Mahler
Could you explain the problem in more detail? On Thu, Mar 1, 2018 at 12:15 PM Chun-Hung Hsiao wrote: > Hi all, > > Meng found a bug in `slave.cpp`, where the proper fix requires collecting > futures in order. Currently every `collect` call spawns it's own actor, so > for

Collecting futures in the same actor in libprocess

2018-03-01 Thread Chun-Hung Hsiao
Hi all, Meng found a bug in `slave.cpp`, where the proper fix requires collecting futures in order. Currently every `collect` call spawns it's own actor, so for two `collect` calls, even though their futures are satisfied in order, they may finish out-of-order. So we need some libprocess changes