Re: MESOS-5731 Add metric types to GetMetrics v1 api

I've pushed 4 review requests for this issue: https://reviews.apache.org/r/49936/ https://reviews.apache.org/r/49937/ https://reviews.apache.org/r/49938/ https://reviews.apache.org/r/49939/ @Benjamin: I'm not sure I understand what you mean. Some of current Timers have `statistics` to calculate

Re: MESOS-5731 Add metric types to GetMetrics v1 api

Have you considered introducing 'histograms' rather than 'timers'? Our Timers are just a special case of a histogram. For example, you could have a histogram of response sizes. On Fri, Jul 8, 2016 at 3:32 PM, Tuan-Anh Hoang-Vu wrote: > Hi all, > > I've finished implementing

MESOS-5731 Add metric types to GetMetrics v1 api

Hi all, I've finished implementing and testing this issue https://issues.apache.org/jira/browse/MESOS-5731 and would like to find a shepherd for my patch. Should I go ahead and submit the patch? Following Vinod's suggestion, I've changed Response::GetMetrics in master.proto and v1/master.proto