Re: Review Request 14663: Fixed slave gc to use modification time for old directories.

2013-10-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14663/ --- (Updated Oct. 23, 2013, 7:45 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 14663: Fixed slave gc to use modification time for old directories.

2013-10-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14663/#review27421 --- Ship it! src/slave/slave.cpp

Re: Review Request 14663: Fixed slave gc to use modification time for old directories.

2013-10-23 Thread Vinod Kone
On Oct. 23, 2013, 9:17 p.m., Ben Mahler wrote: src/slave/slave.cpp, lines 2343-2419 https://reviews.apache.org/r/14663/diff/2/?file=369935#file369935line2343 We should likely check if it exists rather than crashing if we cannot update the utime: if (os::exists(path))

Re: Review Request 14663: Fixed slave gc to use modification time for old directories.

2013-10-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14663/ --- (Updated Oct. 24, 2013, 12:20 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 14663: Fixed slave gc to use modification time for old directories.

2013-10-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14663/#review27357 --- src/slave/slave.cpp

Re: Review Request 14663: Fixed slave gc to use modification time for old directories.

2013-10-17 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14663/#review27134 --- src/slave/slave.hpp

Review Request 14663: Fixed slave gc to use modification time for old directories.

2013-10-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14663/ --- Review request for mesos, Benjamin Hindman and Ben Mahler. Bugs: MESOS-742