Re: Review Request 15745: Fixed some task reconciliation cases.

2014-02-27 Thread Niklas Nielsen
On Nov. 22, 2013, 12:04 p.m., Niklas Nielsen wrote: Did we get to a conclusion regarding case 1)? and could we write a test which exercises the new scenarios? Brenden Matthews wrote: If I get some time, I'll write a test. I've been testing it in production for a few days though.

Re: Review Request 15745: Fixed some task reconciliation cases.

2014-02-27 Thread Brenden Matthews
On Nov. 22, 2013, 8:04 p.m., Niklas Nielsen wrote: Did we get to a conclusion regarding case 1)? and could we write a test which exercises the new scenarios? Brenden Matthews wrote: If I get some time, I'll write a test. I've been testing it in production for a few days though.

Re: Review Request 15745: Fixed some task reconciliation cases.

2014-02-27 Thread Benjamin Hindman
On Nov. 22, 2013, 8:04 p.m., Niklas Nielsen wrote: Did we get to a conclusion regarding case 1)? and could we write a test which exercises the new scenarios? Brenden Matthews wrote: If I get some time, I'll write a test. I've been testing it in production for a few days though.

Re: Review Request 15745: Fixed some task reconciliation cases.

2013-11-26 Thread Brenden Matthews
On Nov. 22, 2013, 8:04 p.m., Niklas Nielsen wrote: Did we get to a conclusion regarding case 1)? and could we write a test which exercises the new scenarios? Brenden Matthews wrote: If I get some time, I'll write a test. I've been testing it in production for a few days though.

Re: Review Request 15745: Fixed some task reconciliation cases.

2013-11-24 Thread Benjamin Hindman
On Nov. 22, 2013, 8:04 p.m., Niklas Nielsen wrote: Did we get to a conclusion regarding case 1)? and could we write a test which exercises the new scenarios? Brenden Matthews wrote: If I get some time, I'll write a test. I've been testing it in production for a few days though.

Re: Review Request 15745: Fixed some task reconciliation cases.

2013-11-22 Thread Brenden Matthews
On Nov. 22, 2013, 8:04 p.m., Niklas Nielsen wrote: Did we get to a conclusion regarding case 1)? and could we write a test which exercises the new scenarios? If I get some time, I'll write a test. I've been testing it in production for a few days though. Not sure about consensus.

Re: Review Request 15745: Fixed some task reconciliation cases.

2013-11-21 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15745/#review29244 --- Awesome Brenden! Can we write tests that covers the new scenarios?

Re: Review Request 15745: Fixed some task reconciliation cases.

2013-11-21 Thread Brenden Matthews
On Nov. 21, 2013, 7:59 p.m., Niklas Nielsen wrote: src/master/master.cpp, line 1597 https://reviews.apache.org/r/15745/diff/2/?file=389363#file389363line1597 What happens if status.task_id() does not exist in tasks? Is it silently ignored or does it fail? In this case I'm

Re: Review Request 15745: Fixed some task reconciliation cases.

2013-11-21 Thread Brenden Matthews
On Nov. 21, 2013, 10:03 p.m., Ben Mahler wrote: Slaves continue to retry status updates until an acknowledgement is received (the scheduler driver sends an acknowledgement once Scheduler::statusUpdate was invoked). So in Case 1 you've described, if a task transitions while a

Re: Review Request 15745: Fixed some task reconciliation cases.

2013-11-21 Thread Brenden Matthews
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15745/ --- (Updated Nov. 22, 2013, 12:30 a.m.) Review request for mesos and Niklas

Re: Review Request 15745: Fixed some task reconciliation cases.

2013-11-21 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15745/#review29249 --- Slaves continue to retry status updates until an acknowledgement is

Re: Review Request 15745: Fixed some task reconciliation cases.

2013-11-21 Thread Brenden Matthews
On Nov. 21, 2013, 7:59 p.m., Niklas Nielsen wrote: src/master/master.cpp, line 1597 https://reviews.apache.org/r/15745/diff/2/?file=389363#file389363line1597 What happens if status.task_id() does not exist in tasks? Is it silently ignored or does it fail? Brenden Matthews