Re: Review Request 15764: Minor fix for script-without-shebang MESOS-831

2013-12-09 Thread Ben Mahler
On Nov. 22, 2013, 9:51 p.m., Ben Mahler wrote: Interesting, these files are not meant to be scripts (they are python libraries), which tool reported the script-without-shebang issue? (Can you kill the trailing whitespace in the Apache header?) Timothy St. Clair wrote: rpmlint

Re: Review Request 15764: Minor fix for script-without-shebang MESOS-831

2013-12-09 Thread Timothy St. Clair
On Nov. 22, 2013, 9:51 p.m., Ben Mahler wrote: Interesting, these files are not meant to be scripts (they are python libraries), which tool reported the script-without-shebang issue? (Can you kill the trailing whitespace in the Apache header?) Timothy St. Clair wrote: rpmlint

Re: Review Request 15764: Minor fix for script-without-shebang MESOS-831

2013-12-09 Thread Benjamin Mahler
Sorry for the trouble! I could submit this and clean up the whitespace for you, but I think this will be a good exercise in using reviewboard. :) Updating will, as far as I know, result in a new revision in the diff page, but there is only one diff revision:

Re: Review Request 15764: Minor fix for script-without-shebang MESOS-831

2013-12-09 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15764/ --- (Updated Dec. 9, 2013, 10:40 p.m.) Review request for mesos. Changes ---

Re: Review Request 15764: Minor fix for script-without-shebang MESOS-831

2013-12-09 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15764/#review30055 --- Ship it! Ship It! - Ben Mahler On Dec. 9, 2013, 10:40 p.m.,

Re: Review Request 15764: Minor fix for script-without-shebang MESOS-831

2013-12-09 Thread Ben Mahler
On Dec. 9, 2013, 10:47 p.m., Ben Mahler wrote: Ship It! Thanks Tim, this is now committed, can you mark this review as submitted and update the JIRA ticket? - Ben --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 15764: Minor fix for script-without-shebang MESOS-831

2013-12-06 Thread Timothy St. Clair
On Nov. 22, 2013, 9:51 p.m., Ben Mahler wrote: Interesting, these files are not meant to be scripts (they are python libraries), which tool reported the script-without-shebang issue? (Can you kill the trailing whitespace in the Apache header?) Timothy St. Clair wrote: rpmlint

Re: Review Request 15764: Minor fix for script-without-shebang MESOS-831

2013-11-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15764/#review29316 --- Interesting, these files are not meant to be scripts (they are

Re: Review Request 15764: Minor fix for script-without-shebang MESOS-831

2013-11-22 Thread Timothy St. Clair
On Nov. 22, 2013, 9:51 p.m., Ben Mahler wrote: Interesting, these files are not meant to be scripts (they are python libraries), which tool reported the script-without-shebang issue? (Can you kill the trailing whitespace in the Apache header?) rpmlint generated on recent update