On March 4, 2014, 1:36 a.m., Ben Mahler wrote:
I think the only remaining bit that might be tricky is that we expose
'Bound' for 'Interval' construction but then we only expose inclusive
lower() and exclusive upper(). I think this is better than exposing the
'Bounds' from interval
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18093/#review36142
---
Ship it!
Ship It!
- Ben Mahler
On March 4, 2014, 6:58 p.m., Jie
On Feb. 21, 2014, 12:12 a.m., Benjamin Hindman wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp, line 107
https://reviews.apache.org/r/18093/diff/5/?file=499572#file499572line107
IMHO, providing element iteration can be sneaky and cause unintended
performance
On Feb. 21, 2014, 12:12 a.m., Benjamin Hindman wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp, line 107
https://reviews.apache.org/r/18093/diff/5/?file=499572#file499572line107
IMHO, providing element iteration can be sneaky and cause unintended
performance
On Feb. 21, 2014, 12:13 a.m., Ben Mahler wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp, lines 99-104
https://reviews.apache.org/r/18093/diff/5/?file=499572#file499572line99
Is this useful outside of testing..?
Jie Yu wrote:
It's only used in testing.
On Feb. 21, 2014, 12:12 a.m., Benjamin Hindman wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp, line 107
https://reviews.apache.org/r/18093/diff/5/?file=499572#file499572line107
IMHO, providing element iteration can be sneaky and cause unintended
performance
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18093/
---
(Updated Feb. 25, 2014, 1:08 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18093/
---
(Updated Feb. 21, 2014, 7:23 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18093/
---
(Updated Feb. 20, 2014, 11:46 p.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18093/#review35111
---
3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18093/#review35114
---
Ship it!
This is a great first step to commit, now that you only
On Feb. 21, 2014, 12:12 a.m., Benjamin Hindman wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp, line 107
https://reviews.apache.org/r/18093/diff/5/?file=499572#file499572line107
IMHO, providing element iteration can be sneaky and cause unintended
performance
On Feb. 21, 2014, 12:13 a.m., Ben Mahler wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp, lines 99-104
https://reviews.apache.org/r/18093/diff/5/?file=499572#file499572line99
Is this useful outside of testing..?
It's only used in testing. Added a TODO.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18093/
---
(Updated Feb. 21, 2014, 1:16 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18093/
---
(Updated Feb. 19, 2014, 8:48 p.m.)
Review request for mesos, Benjamin Hindman,
On Feb. 18, 2014, 5:46 p.m., Dominic Hamon wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp, line 147
https://reviews.apache.org/r/18093/diff/3/?file=487339#file487339line147
could you use composition instead of inheritance here? It might avoid
some of the
On Feb. 17, 2014, 9:24 p.m., Ben Mahler wrote:
3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp, line 166
https://reviews.apache.org/r/18093/diff/3/?file=487340#file487340line166
Is there support for iterating over an individual interval as well? Or
did you want to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18093/#review34665
---
3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp
On Feb. 17, 2014, 9:24 p.m., Ben Mahler wrote:
3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp, lines 167-168
https://reviews.apache.org/r/18093/diff/3/?file=487340#file487340line167
Can these be called lower() and upper()?
That's gonna hide the lower() and upper() in
On Feb. 14, 2014, 5:54 p.m., Ben Mahler wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp, lines 143-146
https://reviews.apache.org/r/18093/diff/2/?file=484865#file484865line143
I'm wondering about the use-cases here to see if the current iterator
semantics are
On Feb. 14, 2014, 5:54 p.m., Ben Mahler wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp, lines 143-146
https://reviews.apache.org/r/18093/diff/2/?file=484865#file484865line143
I'm wondering about the use-cases here to see if the current iterator
semantics are
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18093/#review34507
---
Ship it!
Looks great, I'm wondering if we should provide
On Feb. 14, 2014, 5:54 p.m., Ben Mahler wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp, lines 194-207
https://reviews.apache.org/r/18093/diff/2/?file=484865#file484865line194
Interesting that they provided both + and |, are they not the same
operation? (In
On Feb. 14, 2014, 5:54 p.m., Ben Mahler wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp, lines 143-146
https://reviews.apache.org/r/18093/diff/2/?file=484865#file484865line143
I'm wondering about the use-cases here to see if the current iterator
semantics are
On Feb. 14, 2014, 5:54 p.m., Ben Mahler wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp, lines 143-146
https://reviews.apache.org/r/18093/diff/2/?file=484865#file484865line143
I'm wondering about the use-cases here to see if the current iterator
semantics are
On Feb. 14, 2014, 5:54 p.m., Ben Mahler wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp, lines 143-146
https://reviews.apache.org/r/18093/diff/2/?file=484865#file484865line143
I'm wondering about the use-cases here to see if the current iterator
semantics are
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18093/
---
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18093/
---
(Updated Feb. 14, 2014, 5:38 a.m.)
Review request for mesos, Benjamin Hindman,
28 matches
Mail list logo
