Re: Review Request 24576: Some Master cleanups.

2014-08-13 Thread Ben Mahler
On Aug. 13, 2014, 2:42 a.m., Niklas Nielsen wrote: src/master/master.cpp, lines 2252-2253 https://reviews.apache.org/r/24576/diff/1/?file=658113#file658113line2252 It this comment still relevant? Good catch, I think vinod meant stack instead of heap, since they have always been on

Re: Review Request 24576: Some Master cleanups.

2014-08-13 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24576/ --- (Updated Aug. 13, 2014, 6:51 p.m.) Review request for mesos, Niklas Nielsen

Re: Review Request 24576: Some Master cleanups.

2014-08-13 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24576/ --- (Updated Aug. 13, 2014, 6:52 p.m.) Review request for mesos, Niklas Nielsen

Re: Review Request 24576: Some Master cleanups.

2014-08-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24576/#review50366 --- Ship it! src/master/master.cpp

Re: Review Request 24576: Some Master cleanups.

2014-08-12 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24576/#review50396 --- Ship it! Modulo Vinod's comments. Looks good otherwise!

Review Request 24576: Some Master cleanups.

2014-08-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24576/ --- Review request for mesos, Niklas Nielsen and Vinod Kone. Repository: mesos-git

Re: Review Request 24576: Some Master cleanups.

2014-08-11 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24576/#review50263 --- src/master/master.cpp