---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/#review58315
---
As discussed on IRC:
-- please split this into multiple reviews
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/#review57511
---
src/common/slaveinfo_utils.hpp
On Oct. 15, 2014, 1:25 a.m., Vinod Kone wrote:
src/master/master.cpp, lines 3146-3149
https://reviews.apache.org/r/25525/diff/8/?file=717605#file717605line3146
Hmm. i don't think we want these semantics. Why not just fail if
readmission failed?
Cody Maloney wrote:
So if
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/
---
(Updated Oct. 21, 2014, 11:55 p.m.)
Review request for mesos, Adam B and Vinod
On Oct. 21, 2014, 5:23 p.m., Vinod Kone wrote:
src/common/slaveinfo_utils.hpp, line 32
https://reviews.apache.org/r/25525/diff/8-11/?file=717600#file717600line32
Actually I think this would be better as OptionError compatible()
instead of Trybool isCompatible(), similar to how we
On Oct. 15, 2014, 1:25 a.m., Vinod Kone wrote:
src/master/master.cpp, lines 3146-3149
https://reviews.apache.org/r/25525/diff/8/?file=717605#file717605line3146
Hmm. i don't think we want these semantics. Why not just fail if
readmission failed?
Cody Maloney wrote:
So if
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/#review57715
---
Bad patch!
Reviews applied: [25525]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/
---
(Updated Oct. 22, 2014, 12:32 a.m.)
Review request for mesos, Adam B and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/#review57722
---
Bad patch!
Reviews applied: [25525]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/
---
(Updated Oct. 15, 2014, 7:30 p.m.)
Review request for mesos, Adam B and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/#review56832
---
Patch looks great!
Reviews applied: [25525]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/#review56872
---
Bad patch!
Reviews applied: [25525]
Failed command:
On Oct. 16, 2014, 2:50 a.m., Cody Maloney wrote:
Bad patch!
Reviews applied: [25525]
Failed command: ['./support/appy-review.sh', '-r', '25525']
Error:
-r: ./support/appy-review.sh: No such file or directory
Ignore this. I was testing out some changes to the review checking
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/
---
(Updated Oct. 15, 2014, 3:06 a.m.)
Review request for mesos, Adam B and Vinod
On Oct. 15, 2014, 1:25 a.m., Vinod Kone wrote:
src/master/master.hpp, line 1308
https://reviews.apache.org/r/25525/diff/8/?file=717604#file717604line1308
This should be CHECK_SOME(compatible).
True, a incompatible change shouldn't get that far because there are advance
checks, but
- Cody
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/#review56590
---
On Oct. 15, 2014, 3:13 a.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/
---
(Updated Oct. 15, 2014, 3:13 a.m.)
Review request for mesos, Adam B and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/#review56158
---
src/common/attributes.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/
---
(Updated Oct. 10, 2014, 6:49 p.m.)
Review request for mesos, Adam B and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/
---
(Updated Oct. 10, 2014, 2:29 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/
---
(Updated Oct. 10, 2014, 2:29 a.m.)
Review request for mesos, Adam B and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/#review56104
---
Patch looks great!
Reviews applied: [25525]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/
---
(Updated Sept. 30, 2014, 6:05 p.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/#review55001
---
Patch looks great!
Reviews applied: [25525]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/
---
(Updated Sept. 29, 2014, 11:26 p.m.)
Review request for mesos, Adam B,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/#review54937
---
Bad patch!
Reviews applied: [25261]
Failed command: git apply
On Sept. 11, 2014, 9:53 p.m., Vinod Kone wrote:
OK. I went through parts of this review but I have a bigger suggestion in
mind, before I get too much into the weeds.
I think it's worthwhile for you to write up a design doc similar to the
framework info doc w.r.t. updating
On Sept. 11, 2014, 9:53 p.m., Vinod Kone wrote:
OK. I went through parts of this review but I have a bigger suggestion in
mind, before I get too much into the weeds.
I think it's worthwhile for you to write up a design doc similar to the
framework info doc w.r.t. updating
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/#review53271
---
Patch looks great!
Reviews applied: [25261, 25525]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/
---
(Updated Sept. 12, 2014, 11:33 p.m.)
Review request for mesos, Adam B,
On Sept. 11, 2014, 9:53 p.m., Vinod Kone wrote:
OK. I went through parts of this review but I have a bigger suggestion in
mind, before I get too much into the weeds.
I think it's worthwhile for you to write up a design doc similar to the
framework info doc w.r.t. updating
On Sept. 11, 2014, 9:53 p.m., Vinod Kone wrote:
src/slave/slave.cpp, line 3122
https://reviews.apache.org/r/25525/diff/2/?file=685078#file685078line3122
You should checkpoint the updated slave info!
Cody Maloney wrote:
info contains the new slave info set at the command
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/#review53248
---
src/Makefile.am
https://reviews.apache.org/r/25525/#comment92804
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/
---
(Updated Sept. 13, 2014, 12:33 a.m.)
Review request for mesos, Adam B,
On Sept. 12, 2014, 11:48 p.m., Dominic Hamon wrote:
src/common/slaveinfo_utils.cpp, line 44
https://reviews.apache.org/r/25525/diff/3/?file=688208#file688208line44
std::pairconst std::string, const T* might be preferable.
T is a pointer to member function in this case. I could try
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/
---
(Updated Sept. 11, 2014, 8:13 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/#review53102
---
Patch looks great!
Reviews applied: [25525]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/#review53100
---
OK. I went through parts of this review but I have a bigger
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/
---
Review request for mesos, Adam B, Benjamin Hindman, Patrick Reilly, and Vinod
39 matches
Mail list logo
