---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25597/#review53553
---
Looking much better, thanks Kapil!!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25597/
---
(Updated Sept. 16, 2014, 2:48 p.m.)
Review request for mesos, Adam B and
On Sept. 15, 2014, 6:46 p.m., Ben Mahler wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp, lines 32-34
https://reviews.apache.org/r/25597/diff/3/?file=688423#file688423line32
The program will crash if the split is non-numeric, because you'll call
.get() on a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25597/#review53569
---
Almost there!!
I think we can get away with not needing to expose
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25597/#review53572
---
Bad patch!
Reviews applied: [25597]
Failed command:
On Sept. 15, 2014, 2:46 p.m., Ben Mahler wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp, lines 32-34
https://reviews.apache.org/r/25597/diff/3/?file=688423#file688423line32
The program will crash if the split is non-numeric, because you'll call
.get() on a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25597/
---
(Updated Sept. 16, 2014, 4:39 p.m.)
Review request for mesos, Adam B and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25597/
---
(Updated Sept. 16, 2014, 4:40 p.m.)
Review request for mesos, Adam B and
On Sept. 15, 2014, 6:46 p.m., Ben Mahler wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp, lines 32-34
https://reviews.apache.org/r/25597/diff/3/?file=688423#file688423line32
The program will crash if the split is non-numeric, because you'll call
.get() on a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25597/#review53595
---
Ship it!
Thanks Kapil, looks great! I will get this committed for
On Sept. 16, 2014, 9:05 p.m., Ben Mahler wrote:
Thanks Kapil, looks great! I will get this committed for you shortly, I'll
just add a TODO per your comments on more than 3 version components and
I'll remove the single quotes per my comment below.
Committed!
- Ben
On Sept. 16, 2014, 5:05 p.m., Ben Mahler wrote:
Thanks Kapil, looks great! I will get this committed for you shortly, I'll
just add a TODO per your comments on more than 3 version components and
I'll remove the single quotes per my comment below.
Ben Mahler wrote:
Committed!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25597/#review53608
---
Patch looks great!
Reviews applied: [25597]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25597/#review53352
---
Ship it!
Looks like it is ready to go :)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25597/#review53353
---
3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25597/#review53370
---
Thanks for adding this Kapil!
I made a few notes for cleanup, in
On Sept. 15, 2014, 11:46 a.m., Ben Mahler wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp, lines 28-29
https://reviews.apache.org/r/25597/diff/3/?file=688423#file688423line28
Any reason not to take a const ?
How about s/str/version/ in this whole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25597/
---
(Updated Sept. 15, 2014, 6:22 p.m.)
Review request for mesos, Adam B and
On Sept. 15, 2014, 2:46 p.m., Ben Mahler wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp, lines 32-34
https://reviews.apache.org/r/25597/diff/3/?file=688423#file688423line32
The program will crash if the split is non-numeric, because you'll call
.get() on a
On Sept. 15, 2014, 2:46 p.m., Ben Mahler wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp, lines 86-89
https://reviews.apache.org/r/25597/diff/3/?file=688423#file688423line86
Can you remove all of the _ suffixes for these members? If you look
through our
On Sept. 15, 2014, 6:46 p.m., Ben Mahler wrote:
Thanks for adding this Kapil!
I made a few notes for cleanup, in particular, about:
(1) The consolidation with os::Release, which implements ~ the same thing.
(2) Leveraging stringify with a stream operator as opposed to using a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25597/#review53453
---
Bad patch!
Reviews applied: [25597]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25597/
---
(Updated Sept. 15, 2014, 10:02 p.m.)
Review request for mesos, Adam B and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25597/#review53463
---
3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25597/
---
(Updated Sept. 16, 2014, 1:11 a.m.)
Review request for mesos, Adam B and
On Sept. 16, 2014, 12:25 a.m., Cody Maloney wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp, line 33
https://reviews.apache.org/r/25597/diff/5/?file=690341#file690341line33
Using a C array initializer here would be a little cleaner to read
int versions[3] =
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25597/#review53263
---
Bad patch!
Reviews applied: [25597]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25597/
---
(Updated Sept. 12, 2014, 8:14 p.m.)
Review request for mesos, Adam B and
28 matches
Mail list logo
