Re: Review Request 25798: Refactor Libprocess Help to reduce compile time.

2014-09-19 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25798/#review53951 --- 3rdparty/libprocess/include/process/help.hpp

Re: Review Request 25798: Refactor Libprocess Help to reduce compile time.

2014-09-19 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25798/ --- (Updated Sept. 19, 2014, 7:01 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 25798: Refactor Libprocess Help to reduce compile time.

2014-09-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25798/#review54017 --- Patch looks great! Reviews applied: [25789, 25798] All tests

Review Request 25798: Refactor Libprocess Help to reduce compile time.

2014-09-18 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25798/ --- Review request for mesos, Benjamin Hindman and Niklas Nielsen. Repository:

Re: Review Request 25798: Refactor Libprocess Help to reduce compile time.

2014-09-18 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25798/#review53886 --- +1 - Dominic Hamon On Sept. 18, 2014, 3:53 p.m., Joris Van

Re: Review Request 25798: Refactor Libprocess Help to reduce compile time.

2014-09-18 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25798/#review53889 --- 3rdparty/libprocess/include/process/help.hpp

Re: Review Request 25798: Refactor Libprocess Help to reduce compile time.

2014-09-18 Thread Cody Maloney
On Sept. 18, 2014, 11:14 p.m., Niklas Nielsen wrote: 3rdparty/libprocess/include/process/help.hpp, line 120 https://reviews.apache.org/r/25798/diff/1/?file=693978#file693978line120 std::endl? std::endl is a flush + '\n'. Note the whole codebase only uses '\n' newlines, so this

Re: Review Request 25798: Refactor Libprocess Help to reduce compile time.

2014-09-18 Thread Joris Van Remoortere
On Sept. 18, 2014, 11:14 p.m., Niklas Nielsen wrote: 3rdparty/libprocess/include/process/help.hpp, line 120 https://reviews.apache.org/r/25798/diff/1/?file=693978#file693978line120 std::endl? Cody Maloney wrote: std::endl is a flush + '\n'. Note the whole codebase only uses

Re: Review Request 25798: Refactor Libprocess Help to reduce compile time.

2014-09-18 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25798/ --- (Updated Sept. 19, 2014, 12:26 a.m.) Review request for mesos, Benjamin

Re: Review Request 25798: Refactor Libprocess Help to reduce compile time.

2014-09-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25798/#review53935 --- Patch looks great! Reviews applied: [25789, 25798] All tests