Review Request 25847: Refactor Libprocess: class Node

2014-09-19 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25847/ --- Review request for mesos and Niklas Nielsen. Repository: mesos-git

Re: Review Request 25847: Refactor Libprocess: class Node

2014-09-19 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25847/#review54018 --- 3rdparty/libprocess/include/process/node.hpp

Re: Review Request 25847: Refactor Libprocess: class Node

2014-09-19 Thread Nikita Vetoshkin
On Sept. 19, 2014, 8:32 p.m., Dominic Hamon wrote: 3rdparty/libprocess/include/process/node.hpp, line 32 https://reviews.apache.org/r/25847/diff/1/?file=697014#file697014line32 uint64_t? start getting ipv6 support in... ;) Still won't fit in ipv6 though :( - Nikita

Re: Review Request 25847: Refactor Libprocess: class Node

2014-09-19 Thread Joris Van Remoortere
On Sept. 19, 2014, 8:32 p.m., Dominic Hamon wrote: 3rdparty/libprocess/include/process/node.hpp, line 32 https://reviews.apache.org/r/25847/diff/1/?file=697014#file697014line32 uint64_t? start getting ipv6 support in... ;) Nikita Vetoshkin wrote: Still won't fit

Re: Review Request 25847: Refactor Libprocess: class Node

2014-09-19 Thread Niklas Nielsen
On Sept. 19, 2014, 1:32 p.m., Dominic Hamon wrote: 3rdparty/libprocess/include/process/node.hpp, line 32 https://reviews.apache.org/r/25847/diff/1/?file=697014#file697014line32 uint64_t? start getting ipv6 support in... ;) Nikita Vetoshkin wrote: Still won't fit

Re: Review Request 25847: Refactor Libprocess: class Node

2014-09-19 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25847/#review54030 --- Ship it! Can you motivate it a bit in context of eventually

Re: Review Request 25847: Refactor Libprocess: class Node

2014-09-19 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25847/ --- (Updated Sept. 19, 2014, 10:19 p.m.) Review request for mesos and Niklas

Re: Review Request 25847: Refactor Libprocess: class Node

2014-09-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25847/#review54050 --- Patch looks great! Reviews applied: [25847] All tests passed. -