Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-15 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26229/ --- (Updated Oct. 15, 2014, 12:21 p.m.) Review request for mesos, Benjamin

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26229/#review56701 --- Patch looks great! Reviews applied: [26229] All tests passed. -

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-15 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26229/#review56860 --- Ship it! Will commit this shortly.

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-09 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26229/ --- (Updated Oct. 9, 2014, 4:34 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26229/#review56038 --- Patch looks great! Reviews applied: [26229] All tests passed. -

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-08 Thread Alexander Rukletsov
On Oct. 6, 2014, 10:02 p.m., Ben Mahler wrote: 3rdparty/libprocess/src/reap.cpp, lines 124-127 https://reviews.apache.org/r/26229/diff/1/?file=710088#file710088line124 Why do you need a variable for this? Can't this just be a 'return' statement? If there's a reason

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-08 Thread Alexander Rukletsov
On Oct. 7, 2014, 9:46 p.m., Ben Mahler wrote: I'm curious why you need to expose both sides of the bounds? Our tests currently hard-code 1 second as the reap interval, and since Ian did not change the maximum, the tests continue to function as expected. Are you planning to follow

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26229/ --- (Updated Oct. 8, 2014, 9:30 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-08 Thread Michael Park
On Oct. 6, 2014, 10:02 p.m., Ben Mahler wrote: 3rdparty/libprocess/src/reap.cpp, lines 124-127 https://reviews.apache.org/r/26229/diff/1/?file=710088#file710088line124 Why do you need a variable for this? Can't this just be a 'return' statement? If there's a reason

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-08 Thread Alexander Rukletsov
On Oct. 6, 2014, 10:02 p.m., Ben Mahler wrote: 3rdparty/libprocess/src/reap.cpp, lines 124-127 https://reviews.apache.org/r/26229/diff/1/?file=710088#file710088line124 Why do you need a variable for this? Can't this just be a 'return' statement? If there's a reason

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26229/#review55779 --- Patch looks great! Reviews applied: [26229] All tests passed. -

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-08 Thread Michael Park
On Oct. 6, 2014, 10:02 p.m., Ben Mahler wrote: 3rdparty/libprocess/src/reap.cpp, lines 124-127 https://reviews.apache.org/r/26229/diff/1/?file=710088#file710088line124 Why do you need a variable for this? Can't this just be a 'return' statement? If there's a reason

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-08 Thread Alexander Rukletsov
On Oct. 6, 2014, 10:02 p.m., Ben Mahler wrote: 3rdparty/libprocess/src/reap.cpp, lines 124-127 https://reviews.apache.org/r/26229/diff/1/?file=710088#file710088line124 Why do you need a variable for this? Can't this just be a 'return' statement? If there's a reason

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-08 Thread Ben Mahler
On Oct. 7, 2014, 9:46 p.m., Ben Mahler wrote: I'm curious why you need to expose both sides of the bounds? Our tests currently hard-code 1 second as the reap interval, and since Ian did not change the maximum, the tests continue to function as expected. Are you planning to follow

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-07 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26229/ --- (Updated Oct. 7, 2014, 4:39 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-07 Thread Alexander Rukletsov
On Oct. 6, 2014, 10:04 p.m., Ben Mahler wrote: 3rdparty/libprocess/include/process/reap.hpp, lines 12-14 https://reviews.apache.org/r/26229/diff/1/?file=710087#file710087line12 Can you add some more description to this ticket? If a caller is to use these values, their

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-07 Thread Alexander Rukletsov
On Oct. 6, 2014, 10:02 p.m., Ben Mahler wrote: 3rdparty/libprocess/src/reap.cpp, lines 124-127 https://reviews.apache.org/r/26229/diff/1/?file=710088#file710088line124 Why do you need a variable for this? Can't this just be a 'return' statement? If there's a reason

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26229/#review55675 --- Patch looks great! Reviews applied: [26229] All tests passed. -

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-07 Thread Michael Park
On Oct. 6, 2014, 10:02 p.m., Ben Mahler wrote: 3rdparty/libprocess/src/reap.cpp, lines 124-127 https://reviews.apache.org/r/26229/diff/1/?file=710088#file710088line124 Why do you need a variable for this? Can't this just be a 'return' statement? If there's a reason

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-07 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26229/#review55718 --- I'm curious why you need to expose both sides of the bounds? Our

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-06 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26229/#review55491 --- 3rdparty/libprocess/src/reap.cpp

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-06 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26229/#review55492 --- Ship it! Ship It! - Till Toenshoff On Oct. 1, 2014, 2:12 p.m.,

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-06 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26229/ --- (Updated Oct. 6, 2014, 1:14 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-06 Thread Alexander Rukletsov
On Oct. 6, 2014, 12:50 p.m., Till Toenshoff wrote: 3rdparty/libprocess/src/reap.cpp, line 124 https://reviews.apache.org/r/26229/diff/1/?file=710088#file710088line124 Did we decide on our auto use-cases yet? If I remember correctly, then we did definitely say that iterators are a

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-06 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26229/#review55582 --- 3rdparty/libprocess/src/reap.cpp

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-06 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26229/#review55583 --- 3rdparty/libprocess/include/process/reap.hpp

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-02 Thread Alexander Rukletsov
On Oct. 1, 2014, 5:08 p.m., Ian Downes wrote: I'm curious why this is useful. Is there some code elsewhere that will depend on knowing these parameters? If so, why not just expose them as constants? Yes, I need these constants for graceful shutdown tests. I used static functions for

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-02 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26229/#review55214 --- Ship it! Ship It! - Ian Downes On Oct. 1, 2014, 7:12 a.m.,

Review Request 26229: Expose poll interval from the reaper.

2014-10-01 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26229/ --- Review request for mesos, Ben Mahler, Ian Downes, Jie Yu, and Till Toenshoff.

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26229/#review55077 --- Patch looks great! Reviews applied: [26229] All tests passed. -

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-01 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26229/#review55084 --- I'm curious why this is useful. Is there some code elsewhere that