Re: Review Request 26698: Added StatusUpdateManager::unacknowledged() API call.

2014-10-15 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26698/#review56754 --- Think Adam caught most issues. Only two small nits/questions

Re: Review Request 26698: Added StatusUpdateManager::unacknowledged() API call.

2014-10-15 Thread Vinod Kone
On Oct. 14, 2014, 10:51 p.m., Adam B wrote: src/messages/messages.proto, line 45 https://reviews.apache.org/r/26698/diff/1/?file=720965#file720965line45 Maybe 'unacknowledged_status' would be more accurate, since the uuid is associated with the StatusUpdate message itself, and

Re: Review Request 26698: Added StatusUpdateManager::unacknowledged() API call.

2014-10-15 Thread Vinod Kone
On Oct. 15, 2014, 6:17 p.m., Niklas Nielsen wrote: src/slave/status_update_manager.cpp, lines 292-293 https://reviews.apache.org/r/26698/diff/1/?file=720967#file720967line292 Can you use stream-next() instead ? done. - Vinod

Re: Review Request 26698: Added StatusUpdateManager::unacknowledged() API call.

2014-10-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26698/ --- (Updated Oct. 15, 2014, 9:27 p.m.) Review request for mesos, Adam B, Ben

Review Request 26698: Added StatusUpdateManager::unacknowledged() API call.

2014-10-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26698/ --- Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen. Repository:

Re: Review Request 26698: Added StatusUpdateManager::unacknowledged() API call.

2014-10-14 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26698/#review56583 --- src/messages/messages.proto