---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28655/
---
(Updated Jan. 13, 2015, 7:36 p.m.)
Review request for mesos.
Changes
---
On Jan. 13, 2015, 5:26 p.m., Niklas Nielsen wrote:
src/hook/hook.hpp, lines 22-24
https://reviews.apache.org/r/28655/diff/6/?file=819518#file819518line22
Do you have an example where mesos.hpp is included before stout headers?
I just did a `grep mesos.mesos.hpp -A4 src/* -nr` and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28655/
---
(Updated Jan. 13, 2015, 7:45 p.m.)
Review request for mesos.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28655/
---
(Updated Jan. 13, 2015, 9:09 p.m.)
Review request for mesos.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28655/
---
(Updated Jan. 13, 2015, 8:04 p.m.)
Review request for mesos.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28655/#review67994
---
Ship it!
Ship It!
- Niklas Nielsen
On Jan. 13, 2015, 5:04 p.m.,
On Jan. 6, 2015, 5:26 a.m., Niklas Nielsen wrote:
Hi Kapil,
One high-level observation is that hooks are wired up with function
pointers. Can't we use an abstract class with virtual methods instead?
Kapil Arya wrote:
It can be done either way. One of the reasons for using the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28655/#review66813
---
Hi Kapil,
One high-level observation is that hooks are wired up
On Jan. 6, 2015, 8:26 a.m., Niklas Nielsen wrote:
Hi Kapil,
One high-level observation is that hooks are wired up with function
pointers. Can't we use an abstract class with virtual methods instead?
It can be done either way. One of the reasons for using the functions pointers
was
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28655/
---
(Updated Jan. 5, 2015, 5:42 p.m.)
Review request for mesos and Niklas Nielsen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28655/
---
(Updated Dec. 30, 2014, 6:57 p.m.)
Review request for mesos and Niklas
11 matches
Mail list logo