Re: Review Request 28655: Introduced Mesos Hooks abstraction.

2015-01-13 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28655/ --- (Updated Jan. 13, 2015, 7:36 p.m.) Review request for mesos. Changes ---

Re: Review Request 28655: Introduced Mesos Hooks abstraction.

2015-01-13 Thread Kapil Arya
On Jan. 13, 2015, 5:26 p.m., Niklas Nielsen wrote: src/hook/hook.hpp, lines 22-24 https://reviews.apache.org/r/28655/diff/6/?file=819518#file819518line22 Do you have an example where mesos.hpp is included before stout headers? I just did a `grep mesos.mesos.hpp -A4 src/* -nr` and

Re: Review Request 28655: Introduced Mesos Hooks abstraction.

2015-01-13 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28655/ --- (Updated Jan. 13, 2015, 7:45 p.m.) Review request for mesos. Bugs:

Re: Review Request 28655: Introduced Mesos Hooks abstraction.

2015-01-13 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28655/ --- (Updated Jan. 13, 2015, 9:09 p.m.) Review request for mesos. Changes ---

Re: Review Request 28655: Introduced Mesos Hooks abstraction.

2015-01-13 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28655/ --- (Updated Jan. 13, 2015, 8:04 p.m.) Review request for mesos. Changes ---

Re: Review Request 28655: Introduced Mesos Hooks abstraction.

2015-01-13 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28655/#review67994 --- Ship it! Ship It! - Niklas Nielsen On Jan. 13, 2015, 5:04 p.m.,

Re: Review Request 28655: Introduced Mesos Hooks abstraction.

2015-01-07 Thread Niklas Nielsen
On Jan. 6, 2015, 5:26 a.m., Niklas Nielsen wrote: Hi Kapil, One high-level observation is that hooks are wired up with function pointers. Can't we use an abstract class with virtual methods instead? Kapil Arya wrote: It can be done either way. One of the reasons for using the

Re: Review Request 28655: Introduced Mesos Hooks abstraction.

2015-01-06 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28655/#review66813 --- Hi Kapil, One high-level observation is that hooks are wired up

Re: Review Request 28655: Introduced Mesos Hooks abstraction.

2015-01-06 Thread Kapil Arya
On Jan. 6, 2015, 8:26 a.m., Niklas Nielsen wrote: Hi Kapil, One high-level observation is that hooks are wired up with function pointers. Can't we use an abstract class with virtual methods instead? It can be done either way. One of the reasons for using the functions pointers was

Re: Review Request 28655: Introduced Mesos Hooks abstraction.

2015-01-05 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28655/ --- (Updated Jan. 5, 2015, 5:42 p.m.) Review request for mesos and Niklas Nielsen.

Re: Review Request 28655: Introduced Mesos Hooks abstraction.

2014-12-30 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28655/ --- (Updated Dec. 30, 2014, 6:57 p.m.) Review request for mesos and Niklas