Re: Review Request 28875: Added remove-executor hook for slave.

2015-01-13 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28875/ --- (Updated Jan. 13, 2015, 7:36 p.m.) Review request for mesos and Niklas

Re: Review Request 28875: Added remove-executor hook for slave.

2015-01-13 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28875/ --- (Updated Jan. 13, 2015, 7:46 p.m.) Review request for mesos and Niklas

Re: Review Request 28875: Added remove-executor hook for slave.

2015-01-13 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28875/ --- (Updated Jan. 13, 2015, 1:25 p.m.) Review request for mesos and Niklas

Re: Review Request 28875: Added remove-executor hook for slave.

2015-01-13 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28875/ --- (Updated Jan. 13, 2015, 8:05 p.m.) Review request for mesos and Niklas

Re: Review Request 28875: Added remove-executor hook for slave.

2015-01-13 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28875/#review67962 --- Ship it! Modulo API comment - Niklas Nielsen On Jan. 13, 2015,

Re: Review Request 28875: Added remove-executor hook for slave.

2015-01-06 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28875/#review66822 --- See comments to prior RR's. src/hook/manager.hpp

Re: Review Request 28875: Added remove-executor hook for slave.

2015-01-05 Thread Kapil Arya
On Jan. 5, 2015, 5:49 p.m., Timothy Chen wrote: src/hook/manager.cpp, line 124 https://reviews.apache.org/r/28875/diff/3/?file=803964#file803964line124 This should never happen right? CHECK instead? This can happen, if non of the hook modules install a remove-executor hook. This

Re: Review Request 28875: Added remove-executor hook for slave.

2015-01-05 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28875/ --- (Updated Jan. 5, 2015, 5:42 p.m.) Review request for mesos and Niklas Nielsen.

Re: Review Request 28875: Added remove-executor hook for slave.

2015-01-05 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28875/#review66741 --- src/hook/manager.cpp

Re: Review Request 28875: Added remove-executor hook for slave.

2014-12-30 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28875/ --- (Updated Dec. 30, 2014, 6:57 p.m.) Review request for mesos and Niklas

Review Request 28875: Added remove-executor hook for slave.

2014-12-09 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28875/ --- Review request for mesos and Niklas Nielsen. Repository: mesos-git

Re: Review Request 28875: Added remove-executor hook for slave.

2014-12-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28875/#review64458 --- Patch looks great! Reviews applied: [28655, 28656, 28875] All

Re: Review Request 28875: Added remove-executor hook for slave.

2014-12-09 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28875/ --- (Updated Dec. 9, 2014, 6:45 p.m.) Review request for mesos and Niklas Nielsen.