Re: Review Request 29926: Wrapped underlying process in Owned.

2015-01-20 Thread Alexander Rukletsov
On Jan. 15, 2015, 7:43 p.m., Ben Mahler wrote: This is an extremely common pattern in the code, and so we should avoid doing it in an inconsistent manner. FWIW, we've yet to see leaks from this pattern, but if you want to make this change, let's do it as a broad sweep instead of

Re: Review Request 29926: Wrapped underlying process in Owned.

2015-01-18 Thread Bernd Mathiske
On Jan. 15, 2015, 11:43 a.m., Ben Mahler wrote: This is an extremely common pattern in the code, and so we should avoid doing it in an inconsistent manner. FWIW, we've yet to see leaks from this pattern, but if you want to make this change, let's do it as a broad sweep instead of

Re: Review Request 29926: Wrapped underlying process in Owned.

2015-01-16 Thread Alexander Rukletsov
On Jan. 15, 2015, 7:43 p.m., Ben Mahler wrote: This is an extremely common pattern in the code, and so we should avoid doing it in an inconsistent manner. FWIW, we've yet to see leaks from this pattern, but if you want to make this change, let's do it as a broad sweep instead of

Re: Review Request 29926: Wrapped underlying process in Owned.

2015-01-16 Thread Niklas Nielsen
On Jan. 15, 2015, 11:43 a.m., Ben Mahler wrote: This is an extremely common pattern in the code, and so we should avoid doing it in an inconsistent manner. FWIW, we've yet to see leaks from this pattern, but if you want to make this change, let's do it as a broad sweep instead of

Re: Review Request 29926: Wrapped underlying process in Owned.

2015-01-16 Thread Benjamin Mahler
Let's look at the two options: 1. Used Owned now only in this location, add a ticket to do a sweep. 2. Use the existing pattern, add a ticket to do a sweep. Removing a single instance from the sweep you're planning to do doesn't seem to warrant the inconsistency in such a common pattern (Process

Review Request 29926: Wrapped underlying process in Owned.

2015-01-15 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29926/ --- Review request for mesos, Bernd Mathiske and Niklas Nielsen. Bugs: MESOS-2213

Re: Review Request 29926: Wrapped underlying process in Owned.

2015-01-15 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29926/#review68303 --- This is an extremely common pattern in the code, and so we should