---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/#review71016
---
Ship it!
src/tests/master_validation_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/#review70908
---
Patch looks great!
Reviews applied: [30513]
All tests passed.
-
On Feb. 2, 2015, 6:43 p.m., Dominic Hamon wrote:
src/master/validation.cpp, line 126
https://reviews.apache.org/r/30513/diff/1/?file=843897#file843897line126
s/resource/volumes/ .. the current code reads as if you're checking
that all resources are persistent volumes, which
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/
---
(Updated Feb. 3, 2015, 11:15 p.m.)
Review request for mesos, Ben Mahler,
On Feb. 3, 2015, 8:15 p.m., Vinod Kone wrote:
src/master/validation.cpp, line 132
https://reviews.apache.org/r/30513/diff/1/?file=843897#file843897line132
ditto.
It's clear that resource.name() is 'disk' in this case.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/
---
(Updated Feb. 3, 2015, 11:19 p.m.)
Review request for mesos, Ben Mahler,
On Feb. 3, 2015, 8:15 p.m., Vinod Kone wrote:
Test?
Added/refactored tests.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/#review70815
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/#review70815
---
Test?
src/master/validation.cpp
On Feb. 2, 2015, 6:43 p.m., Dominic Hamon wrote:
src/master/validation.cpp, line 544
https://reviews.apache.org/r/30513/diff/1/?file=843897#file843897line544
if this is all you need, can you pass in the persisted resources
instead of a slave? might make future testing easier.
+1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/#review70867
---
Patch looks great!
Reviews applied: [30513]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/
---
(Updated Feb. 4, 2015, 1:10 a.m.)
Review request for mesos, Ben Mahler,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/
---
Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/#review70600
---
src/master/validation.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/#review70626
---
Bad patch!
Reviews applied: [30513]
Failed command:
14 matches
Mail list logo
