Re: Review Request 30584: Added metrics for slave shutdowns.

2015-02-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30584/ --- (Updated Feb. 4, 2015, 10:44 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 30584: Added metrics for slave shutdowns.

2015-02-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30584/ --- (Updated Feb. 5, 2015, 12:13 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 30584: Added metrics for slave shutdowns.

2015-02-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30584/#review71099 --- Ship it! TIL: Americans spell it canceled, not cancelled :)

Re: Review Request 30584: Added metrics for slave shutdowns.

2015-02-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30584/#review71073 --- Patch looks great! Reviews applied: [30511, 30514, 30584] All

Re: Review Request 30584: Added metrics for slave shutdowns.

2015-02-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30584/#review70919 --- Patch looks great! Reviews applied: [30511, 30514, 30584] All

Re: Review Request 30584: Added metrics for slave shutdowns.

2015-02-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30584/ --- (Updated Feb. 4, 2015, 1:57 a.m.) Review request for mesos, Ben Mahler and Jie

Review Request 30584: Added metrics for slave shutdowns.

2015-02-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30584/ --- Review request for mesos, Ben Mahler and Jie Yu. Bugs: MESOS-1148

Re: Review Request 30584: Added metrics for slave shutdowns.

2015-02-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30584/#review70842 --- Bad patch! Reviews applied: [30511] Failed command:

Re: Review Request 30584: Added metrics for slave shutdowns.

2015-02-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30584/#review70855 --- src/master/master.cpp

Re: Review Request 30584: Added metrics for slave shutdowns.

2015-02-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30584/ --- (Updated Feb. 4, 2015, 12:24 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 30584: Added metrics for slave shutdowns.

2015-02-03 Thread Vinod Kone
On Feb. 3, 2015, 11:37 p.m., Jie Yu wrote: src/master/master.cpp, line 3908 https://reviews.apache.org/r/30584/diff/1/?file=846680#file846680line3908 This doesn't seem to necessary since we have master/slave_removals already (which will be incremented in removeSlave(slave)

Re: Review Request 30584: Added metrics for slave shutdowns.

2015-02-03 Thread Jie Yu
On Feb. 3, 2015, 11:37 p.m., Jie Yu wrote: src/master/master.cpp, line 3908 https://reviews.apache.org/r/30584/diff/1/?file=846680#file846680line3908 This doesn't seem to necessary since we have master/slave_removals already (which will be incremented in removeSlave(slave)

Re: Review Request 30584: Added metrics for slave shutdowns.

2015-02-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30584/ --- (Updated Feb. 4, 2015, 12:31 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 30584: Added metrics for slave shutdowns.

2015-02-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30584/#review70888 --- Patch looks great! Reviews applied: [30511, 30514, 30584] All