Re: Review Request 30945: Waited containerizer update to finish before sending task to the executor in Slave::_runTask.

2015-02-12 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30945/#review72221 --- src/slave/slave.cpp

Review Request 30945: Waited containerizer update to finish before sending task to the executor in Slave::_runTask.

2015-02-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30945/ --- Review request for mesos, Ian Downes and Vinod Kone. Bugs: MESOS-998

Re: Review Request 30945: Waited containerizer update to finish before sending task to the executor in Slave::_runTask.

2015-02-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30945/#review72227 --- Just realized that there still a race here with killTask (killTask

Re: Review Request 30945: Waited containerizer update to finish before sending task to the executor in Slave::_runTask.

2015-02-12 Thread Jie Yu
On Feb. 12, 2015, 7:47 p.m., Jie Yu wrote: Just realized that there still a race here with killTask (killTask happens between `_runTask` and `__runTask`). We could end up with the situation where the executor receives an KillTaskMessage with an unknown task since RunTaskMessage