Re: Review Request 30948: Reverted configurable graceful shutdown period patch set.

2015-02-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30948/#review72347 --- Just to confirm: do we revert these patches from master or from

Re: Review Request 30948: Reverted configurable graceful shutdown period patch set.

2015-02-13 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30948/#review72401 --- This looks good, I'm curious though, were you unable to revert the

Re: Review Request 30948: Reverted configurable graceful shutdown period patch set.

2015-02-13 Thread Ben Mahler
On Feb. 13, 2015, 6:15 p.m., Ben Mahler wrote: This looks good, I'm curious though, were you unable to revert the specific commits at this point? How did you get this diff? - Ben --- This is an automatically generated e-mail. To

Re: Review Request 30948: Reverted configurable graceful shutdown period patch set.

2015-02-13 Thread Niklas Nielsen
On Feb. 13, 2015, 10:15 a.m., Ben Mahler wrote: This looks good, I'm curious though, were you unable to revert the specific commits at this point? Ben Mahler wrote: How did you get this diff? I did a reverse diff of the chain and fixed the conflicts. I could have split this in

Re: Review Request 30948: Reverted configurable graceful shutdown period patch set.

2015-02-13 Thread Niklas Nielsen
On Feb. 13, 2015, 12:41 a.m., Alexander Rukletsov wrote: Just to confirm: do we revert these patches from master or from 0.22 release only? From master/HEAD. Instead of cherry picking the commits out (which would potentially touch many commits), we tag HEAD and apply the reverse diff.

Re: Review Request 30948: Reverted configurable graceful shutdown period patch set.

2015-02-13 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30948/#review72408 --- Ship it! Thanks Nik, looking forward to landing configurable

Re: Review Request 30948: Reverted configurable graceful shutdown period patch set.

2015-02-13 Thread Ben Mahler
On Feb. 13, 2015, 6:15 p.m., Ben Mahler wrote: This looks good, I'm curious though, were you unable to revert the specific commits at this point? Ben Mahler wrote: How did you get this diff? Niklas Nielsen wrote: I did a reverse diff of the chain and fixed the conflicts. I

Review Request 30948: Reverted configurable graceful shutdown period patch set.

2015-02-12 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30948/ --- Review request for mesos, Alexander Rukletsov, Ben Mahler, and Vinod Kone.

Re: Review Request 30948: Reverted configurable graceful shutdown period patch set.

2015-02-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30948/#review72313 --- Patch looks great! Reviews applied: [30948] All tests passed. -