---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31308/
---
(Updated Feb. 23, 2015, 5:37 p.m.)
Review request for mesos and Dominic Hamon.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31308/
---
Review request for mesos.
Repository: mesos
Description
---
see summary
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31308/
---
(Updated Feb. 23, 2015, 5:22 p.m.)
Review request for mesos and Dominic Hamon.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31308/#review73599
---
Ship it!
Ship It!
- Dominic Hamon
On Feb. 23, 2015, 9:37 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31308/#review73614
---
src/tests/port_mapping_tests.cpp
On Feb. 23, 2015, 6:32 p.m., Dominic Hamon wrote:
src/tests/port_mapping_tests.cpp, line 67
https://reviews.apache.org/r/31308/diff/3/?file=872983#file872983line67
we may not, but it was there before the namespace was removed.
yeah, but previously, all code is not under
On Feb. 23, 2015, 1:06 p.m., Jie Yu wrote:
src/tests/port_mapping_tests.cpp, line 67
https://reviews.apache.org/r/31308/diff/3/?file=872983#file872983line67
Can you paste what the error is?
I am curious why we still need `using namespace mesos::internal::tests`
when
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31308/#review73638
---
Ship it!
Modulo Kapil's suggestion on reordering
- Niklas Nielsen
On Feb. 23, 2015, 1:06 p.m., Jie Yu wrote:
src/tests/port_mapping_tests.cpp, line 67
https://reviews.apache.org/r/31308/diff/3/?file=872983#file872983line67
Can you paste what the error is?
I am curious why we still need `using namespace mesos::internal::tests`
when
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31308/#review73626
---
src/tests/port_mapping_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31308/
---
(Updated Feb. 23, 2015, 7:16 p.m.)
Review request for mesos and Dominic Hamon.
On Feb. 23, 2015, 7 p.m., Kapil Arya wrote:
src/tests/port_mapping_tests.cpp, line 82
https://reviews.apache.org/r/31308/diff/3/?file=872983#file872983line82
Just looked at the pastebin file (Thanks!), can we either replace the
entire `using mesos::internal::slave::*` code block
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31308/#review73637
---
Ship it!
confirmed this should fix the errors.
- Chi Zhang
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31308/#review73602
---
src/tests/port_mapping_tests.cpp
On Feb. 23, 2015, 11 a.m., Kapil Arya wrote:
src/tests/port_mapping_tests.cpp, line 82
https://reviews.apache.org/r/31308/diff/3/?file=872983#file872983line82
Just looked at the pastebin file (Thanks!), can we either replace the
entire `using mesos::internal::slave::*` code block
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31308/
---
(Updated Feb. 23, 2015, 11:25 a.m.)
Review request for mesos, Dominic Hamon
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31308/#review73640
---
Ship it!
Ship It!
- Jie Yu
On Feb. 23, 2015, 7:32 p.m., Evelina
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31308/
---
(Updated Feb. 23, 2015, 7:32 p.m.)
Review request for mesos, Dominic Hamon and
18 matches
Mail list logo
