They should have supported # numbered lists or something other than using
1. for each item, as that reads poorly. We should optimize for readable
numbered lists as opposed to diffs, is there another way to let the numbers
be computed implicitly? If not, let's just number correctly to be
consistent
On March 6, 2015, 7:28 p.m., Ben Mahler wrote:
docs/release-guide.md, lines 148-151
https://reviews.apache.org/r/31720/diff/2/?file=884496#file884496line148
Could we please number these correctly?
Hi Ben - just checking, are you aware of the advantages of this valid Markdown
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31720/#review75531
---
This is too vague, what does a pull request entail? We also don't
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31720/#review75206
---
Bad patch!
Reviews applied: [31720]
Failed command:
On March 4, 2015, 6:49 p.m., Niklas Nielsen wrote:
docs/release-guide.md, lines 149-151
https://reviews.apache.org/r/31720/diff/1/?file=884188#file884188line149
You need one more space in front here to get sub items, no? :)
Two spaces is fine for sub items, see L16 for example.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31720/
---
(Updated March 4, 2015, 8:06 p.m.)
Review request for mesos and Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31720/#review75140
---
docs/release-guide.md
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31720/#review75255
---
Ship it!
Ship It!
- Niklas Nielsen
On March 4, 2015, 12:06
On March 4, 2015, 10:49 a.m., Niklas Nielsen wrote:
docs/release-guide.md, lines 149-151
https://reviews.apache.org/r/31720/diff/1/?file=884188#file884188line149
You need one more space in front here to get sub items, no? :)
Aaron Bell wrote:
Two spaces is fine for sub
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31720/
---
Review request for mesos and Niklas Nielsen.
Bugs: MESOS-2448
10 matches
Mail list logo
