Re: Review Request 31977: Fixed the race in MasterTest.MasterFailoverLongLivedExecutor.

2015-03-24 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31977/#review77669 --- Ship it! Let's move it to src/tests/mesos.hpp and remove the

Re: Review Request 31977: Fixed the race in MasterTest.MasterFailoverLongLivedExecutor.

2015-03-24 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31977/ --- (Updated March 25, 2015, 4:04 a.m.) Review request for mesos, Adam B and

Re: Review Request 31977: Fixed the race in MasterTest.MasterFailoverLongLivedExecutor.

2015-03-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31977/#review77707 --- Patch looks great! Reviews applied: [31977] All tests passed. -

Re: Review Request 31977: Fixed the race in MasterTest.MasterFailoverLongLivedExecutor.

2015-03-24 Thread Michael Park
On March 24, 2015, 12:54 a.m., Niklas Nielsen wrote: Hey mpark, mind creating a JIRA issue for this patch? :) Thanks! Done. - Michael --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 31977: Fixed the race in MasterTest.MasterFailoverLongLivedExecutor.

2015-03-24 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31977/ --- (Updated March 24, 2015, 6:32 a.m.) Review request for mesos, Adam B and

Re: Review Request 31977: Fixed the race in MasterTest.MasterFailoverLongLivedExecutor.

2015-03-13 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31977/#review76367 --- Ship it! Ship It! - Alexander Rojas On March 12, 2015, 8:53

Re: Review Request 31977: Fixed the race in MasterTest.MasterFailoverLongLivedExecutor.

2015-03-12 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31977/#review76218 --- Ship it! Looks like a solid fix. Is there a JIRA associated with

Review Request 31977: Fixed the race in MasterTest.MasterFailoverLongLivedExecutor.

2015-03-12 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31977/ --- Review request for mesos, Adam B and Niklas Nielsen. Repository: mesos

Re: Review Request 31977: Fixed the race in MasterTest.MasterFailoverLongLivedExecutor.

2015-03-12 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31977/ --- (Updated March 12, 2015, 7:53 a.m.) Review request for mesos, Adam B and

Re: Review Request 31977: Fixed the race in MasterTest.MasterFailoverLongLivedExecutor.

2015-03-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31977/#review76222 --- Patch looks great! Reviews applied: [31977] All tests passed. -

Re: Review Request 31977: Fixed the race in MasterTest.MasterFailoverLongLivedExecutor.

2015-03-12 Thread Michael Park
On March 12, 2015, 8:36 a.m., Adam B wrote: Looks like a solid fix. Is there a JIRA associated with this patch? I'm not sure, I searched for `MasterFailoverLongLivedExecutor` but couldn't seem to find it in JIRA. On March 12, 2015, 8:36 a.m., Adam B wrote: src/tests/master_tests.cpp,