---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/#review76607
---
I am getting a build error on Mac OS X (let's get this fixed first
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/
---
(Updated March 16, 2015, 7:16 p.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/#review76635
---
Patch looks great!
Reviews applied: [32008]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/#review76405
---
Blanket LDADD will fail rpm checks because it will link all deps
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/#review76398
---
LGTM
- Niklas Nielsen
On March 12, 2015, 5:10 p.m., Cody Maloney
On March 13, 2015, 9:31 p.m., Kapil Arya wrote:
Can we do similar thing to libprocess?
We don't currently ship libprocess as a .so / link against it ever, so it
doesn't come up. It is treated as part of libmesos, or linked into the binaries
of the tests directly ATM.
- Cody
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/#review76428
---
Patch looks great!
Reviews applied: [32008]
All tests passed.
-
On March 13, 2015, 9:31 p.m., Kapil Arya wrote:
Can we do similar thing to libprocess?
Cody Maloney wrote:
We don't currently ship libprocess as a .so / link against it ever, so it
doesn't come up. It is treated as part of libmesos, or linked into the
binaries of the tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/#review76416
---
Ship it!
Provided builds are clean, +1
- Timothy St. Clair
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/#review76438
---
Ship it!
Can we do similar thing to libprocess?
- Kapil Arya
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/#review76420
---
Ship it!
src/Makefile.am
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/
---
(Updated March 13, 2015, 7:55 p.m.)
Review request for mesos, Niklas Nielsen
On March 13, 2015, 5:31 p.m., Kapil Arya wrote:
Can we do similar thing to libprocess?
Cody Maloney wrote:
We don't currently ship libprocess as a .so / link against it ever, so it
doesn't come up. It is treated as part of libmesos, or linked into the
binaries of the tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/#review76458
---
Ship it!
LGTM, although you should s/--as-neede/--as-needed/ in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/
---
Review request for mesos, Niklas Nielsen and Timothy St. Clair.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/#review76316
---
Patch looks great!
Reviews applied: [32008]
All tests passed.
-
16 matches
Mail list logo