On March 24, 2015, 9:32 p.m., Michael Park wrote:
src/common/http.cpp, lines 179-187
https://reviews.apache.org/r/32419/diff/1/?file=903656#file903656line179
Just a suggestion for an alternative pattern here.
Rather than
```
{
JSON::Array
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32419/#review77657
---
src/common/http.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32419/#review77585
---
Looks good, but I would like to get some numbers especially on the
On March 24, 2015, 4:10 p.m., Alexander Rukletsov wrote:
src/master/http.cpp, line 470
https://reviews.apache.org/r/32419/diff/1/?file=903657#file903657line470
Are you sure the outer `object` is not shadowed? Even if it's not, let
us maybe leave the original naming to avoid name
On March 24, 2015, 4:10 p.m., Alexander Rukletsov wrote:
src/master/http.cpp, line 470
https://reviews.apache.org/r/32419/diff/1/?file=903657#file903657line470
Are you sure the outer `object` is not shadowed? Even if it's not, let
us maybe leave the original naming to avoid name
On March 24, 2015, 4:10 p.m., Alexander Rukletsov wrote:
src/master/http.cpp, line 470
https://reviews.apache.org/r/32419/diff/1/?file=903657#file903657line470
Are you sure the outer `object` is not shadowed? Even if it's not, let
us maybe leave the original naming to avoid name
On March 24, 2015, 4:10 p.m., Alexander Rukletsov wrote:
src/master/http.cpp, line 470
https://reviews.apache.org/r/32419/diff/1/?file=903657#file903657line470
Are you sure the outer `object` is not shadowed? Even if it's not, let
us maybe leave the original naming to avoid name
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32419/#review77499
---
Ship it!
LGTM!
- Jie Yu
On March 24, 2015, 12:27 a.m., Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32419/
---
Review request for mesos and Jie Yu.
Bugs: MESOS-2353
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32419/#review77513
---
Patch looks great!
Reviews applied: [32419]
All tests passed.
-
10 matches
Mail list logo
