Re: Review Request 14460: Add debian directory to create mesos packages

2013-10-04 Thread Damien Hardy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14460/ --- (Updated Oct. 4, 2013, 7:50 a.m.) Review request for mesos. Changes ---

Re: Review Request 14460: Add debian directory to create mesos packages

2013-10-04 Thread Damien Hardy
On Oct. 3, 2013, 7:01 p.m., Charles Reiss wrote: You seem to have made the diff in the wrong direction, so reviewboard isn't very helpful for it. Some nits: - localstatedir is (mis?)used for deploy script config files. Shouldn't this be overriden to /etc, not /usr/lib to comply

[jira] [Commented] (MESOS-719) missing-call-to-setgroups

2013-10-04 Thread Timothy St. Clair (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13786160#comment-13786160 ] Timothy St. Clair commented on MESOS-719: - according to rpmlint: if

Re: Review Request 14457: Added default constructor and ==, != operators for Result. (Stout)

2013-10-04 Thread Jiang Yan Xu
On Oct. 4, 2013, 5:45 p.m., Vinod Kone wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp, line 30 https://reviews.apache.org/r/14457/diff/1/?file=360811#file360811line30 Why did you need this? Without it for Result class variables I need to manually

Re: Review Request 13757: Fixed an issue where the Master unnecessarily sends a Framework failed over message when the scheduler driver retries an initial failover re-registration.

2013-10-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13757/ --- (Updated Oct. 4, 2013, 6:15 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 13757: Fixed an issue where the Master unnecessarily sends a Framework failed over message when the scheduler driver retries an initial failover re-registration.

2013-10-04 Thread Ben Mahler
On Sept. 16, 2013, 6:22 p.m., Vinod Kone wrote: src/master/master.cpp, line 1899 https://reviews.apache.org/r/13757/diff/1/?file=344097#file344097line1899 From MESOS-488 it sounded like we are in this situation when the reregister message is a duplicate. Are there other cases? If

[jira] [Commented] (MESOS-488) The Master incorrectly sends a Framework failed over message when the scheduler driver retries an initial failover re-registration.

2013-10-04 Thread Benjamin Mahler (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13786439#comment-13786439 ] Benjamin Mahler commented on MESOS-488: --- https://reviews.apache.org/r/13757/ The

Re: Review Request 13744: Fixed a case where Framework re-registration time was not being updated.

2013-10-04 Thread Ben Mahler
On Sept. 16, 2013, 6:38 p.m., Vinod Kone wrote: Consider writing a test in this review. If you would like to punt please create a ticket for the test to keep track. Ben Mahler wrote: I realized I could not spoof exited events so I was not able to create a test to trigger this,

Re: Review Request 13744: Fixed a case where Framework re-registration time was not being updated.

2013-10-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13744/ --- (Updated Oct. 4, 2013, 6:34 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 14434: Added timestamps to TaskInfo.

2013-10-04 Thread Brenden Matthews
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14434/ --- (Updated Oct. 4, 2013, 7:35 p.m.) Review request for mesos. Changes ---

Review Request 14507: Added put function to hashmap and fixed values() to return list.

2013-10-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14507/ --- Review request for mesos, Benjamin Hindman and Ben Mahler. Repository:

Re: Review Request 14292: Added authentication support to scheduler and master.

2013-10-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14292/ --- (Updated Oct. 5, 2013, 1:33 a.m.) Review request for mesos, Benjamin Hindman,

Review Request 14509: Updated all tests to do authentication.

2013-10-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14509/ --- Review request for mesos, Benjamin Hindman and Ben Mahler. Bugs: MESOS-704

Review Request 14510: Added authentication tests.

2013-10-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14510/ --- Review request for mesos, Benjamin Hindman and Ben Mahler. Bugs: MESOS-704