[jira] [Created] (MESOS-758) Incorrect memory statistics are reported under linux

2013-10-22 Thread Eric W. Biederman (JIRA)
Eric W. Biederman created MESOS-758: --- Summary: Incorrect memory statistics are reported under linux Key: MESOS-758 URL: https://issues.apache.org/jira/browse/MESOS-758 Project: Mesos Issue

Re: Review Request 14800: glog creates log files in /tmp

2013-10-22 Thread Yuval Pavel Zholkover
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14800/ --- (Updated Oct. 22, 2013, 8:28 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 14825: cgroup_isolator: Report the actual amount of memory used

2013-10-22 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14825/#review27286 --- src/slave/cgroups_isolator.cpp

Review Request 14848: Added a shared pointer abstraction which enforces const accesses.

2013-10-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14848/ --- Review request for mesos, Benjamin Hindman, Ben Mahler, Vinod Kone, and Jiang

Re: Review Request 14669: launchTasks on list of offers

2013-10-22 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14669/ --- (Updated Oct. 22, 2013, 5:37 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 14848: Added a shared pointer abstraction which enforces const accesses.

2013-10-22 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14848/#review27317 --- Ship it! Ship It! - Benjamin Hindman On Oct. 22, 2013, 5:55

Re: Review Request 14657: Removed unimplemented Dashboard page.

2013-10-22 Thread Ross Allen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14657/ --- (Updated Oct. 22, 2013, 6:16 p.m.) Review request for mesos. Changes ---

Re: Review Request 14800: glog creates log files in /tmp

2013-10-22 Thread Yuval Pavel Zholkover
On Oct. 22, 2013, 3:05 a.m., Benjamin Hindman wrote: src/logging/logging.cpp, lines 104-106 https://reviews.apache.org/r/14800/diff/1/?file=368956#file368956line104 I think we want to add an else if which turns logging to stderr back off: if (!flags.quiet) {

Re: Review Request 14847: Added --hostname flag to slave and removed webui_hostname.

2013-10-22 Thread Niklas Nielsen
On Oct. 22, 2013, 6:01 p.m., Brenden Matthews wrote: It may also be worth looking at these: https://reviews.apache.org/r/11108/ https://reviews.apache.org/r/11975/ This is how we accomplish the same thing. Hi Brenden, Thanks for the pointers! Was there any particular push-back

Re: Review Request 11975: Use hostname instead of IP for redirection.

2013-10-22 Thread Brenden Matthews
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11975/ --- (Updated Oct. 22, 2013, 7:03 p.m.) Review request for mesos. Changes ---

Re: Review Request 14847: Added --hostname flag to slave and removed webui_hostname.

2013-10-22 Thread Brenden Matthews
On Oct. 22, 2013, 6:01 p.m., Brenden Matthews wrote: It may also be worth looking at these: https://reviews.apache.org/r/11108/ https://reviews.apache.org/r/11975/ This is how we accomplish the same thing. Niklas Nielsen wrote: Hi Brenden, Thanks for the

Re: Review Request 11108: Simplified os::hostname() in libstout.

2013-10-22 Thread Brenden Matthews
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11108/ --- (Updated Oct. 22, 2013, 7:04 p.m.) Review request for mesos and Benjamin

[jira] [Created] (MESOS-760) Capture memory usage statistics before OOM

2013-10-22 Thread Vinod Kone (JIRA)
Vinod Kone created MESOS-760: Summary: Capture memory usage statistics before OOM Key: MESOS-760 URL: https://issues.apache.org/jira/browse/MESOS-760 Project: Mesos Issue Type: Improvement

Re: Review Request 14847: Added --hostname flag to slave and removed webui_hostname.

2013-10-22 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14847/#review27337 --- src/slave/slave.cpp

Re: Review Request 14859: Change Web UI to use /master/redirect for leader redirection.

2013-10-22 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14859/ --- (Updated Oct. 22, 2013, 10:30 p.m.) Review request for mesos and Benjamin

Re: Review Request 14825: cgroup_isolator: Report the actual amount of memory used

2013-10-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14825/#review27340 --- Ship it! We can also expose this as a new statistic

Re: Review Request 14847: Added --hostname flag to slave and removed webui_hostname.

2013-10-22 Thread Niklas Nielsen
On Oct. 22, 2013, 10:25 p.m., Benjamin Hindman wrote: src/slave/slave.cpp, line 226 https://reviews.apache.org/r/14847/diff/1/?file=369207#file369207line226 Can we check that this is a valid hostname? I.e., does this hostname resolve to one of the available IP addresses on this

Re: Review Request 14847: Added --hostname flag to slave and removed webui_hostname.

2013-10-22 Thread Benjamin Hindman
But does this check if the hostname resolves to one of the IPs addressable on this machine? I.e., an IP address we can bind to? On Tue, Oct 22, 2013 at 3:59 PM, Niklas Nielsen n...@qni.dk wrote: On Oct. 22, 2013, 10:25 p.m., Benjamin Hindman wrote: src/slave/slave.cpp, line 226

Re: Review Request 14847: Added --hostname flag to slave and removed webui_hostname.

2013-10-22 Thread Niklas Nielsen
On Oct. 22, 2013, 10:25 p.m., Benjamin Hindman wrote: src/slave/slave.cpp, line 226 https://reviews.apache.org/r/14847/diff/1/?file=369207#file369207line226 Can we check that this is a valid hostname? I.e., does this hostname resolve to one of the available IP addresses on this

Re: Review Request 14825: cgroup_isolator: Report the actual amount of memory used

2013-10-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14825/#review27352 --- Ship it! modulo benm's comments. - Vinod Kone On Oct. 22, 2013,

Re: Review Request 14825: cgroup_isolator: Report the actual amount of memory used

2013-10-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14825/#review27353 --- src/slave/cgroups_isolator.cpp

Re: Review Request 14825: cgroup_isolator: Report the actual amount of memory used

2013-10-22 Thread Vinod Kone
On Oct. 22, 2013, 10:44 p.m., Ben Mahler wrote: We can also expose this as a new statistic mem_usage_bytes, leaving mem_rss_bytes unchanged. Do you think differentiating the two would be beneficial or is rss not measured correctly? +1 - Vinod

[jira] [Created] (MESOS-761) Export all memory stats from memory.stat via CgroupsIsolator's usage()

2013-10-22 Thread Vinod Kone (JIRA)
Vinod Kone created MESOS-761: Summary: Export all memory stats from memory.stat via CgroupsIsolator's usage() Key: MESOS-761 URL: https://issues.apache.org/jira/browse/MESOS-761 Project: Mesos

Re: Review Request 14663: Fixed slave gc to use modification time for old directories.

2013-10-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14663/#review27357 --- src/slave/slave.cpp

[jira] [Created] (MESOS-762) Revert the use of the soft limit and memory threshold notifications.

2013-10-22 Thread Benjamin Mahler (JIRA)
Benjamin Mahler created MESOS-762: - Summary: Revert the use of the soft limit and memory threshold notifications. Key: MESOS-762 URL: https://issues.apache.org/jira/browse/MESOS-762 Project: Mesos

[jira] [Commented] (MESOS-750) Require compilers that support c++11

2013-10-22 Thread Benjamin Mahler (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13802520#comment-13802520 ] Benjamin Mahler commented on MESOS-750: --- We will need to investigate ABI

Review Request 14863: Revert Added memory threshold notifications for inducing OOMs.

2013-10-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14863/ --- Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-762

Review Request 14860: Revert Fixed ARG_MAX compilation issue on some POSIX systems.

2013-10-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14860/ --- Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-762

[jira] [Commented] (MESOS-762) Revert the use of the soft limit and memory threshold notifications.

2013-10-22 Thread Benjamin Mahler (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13802523#comment-13802523 ] Benjamin Mahler commented on MESOS-762: --- Reverts: