Re: Review Request 15487: Fixed a bug where Group::cancel can return a failed future if the membership is already cancelled

2013-11-13 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15487/#review28818 --- Ship it! Ship It! - Ben Mahler On Nov. 13, 2013, 6:14 p.m.,

[jira] [Commented] (MESOS-422) Master leader election should be more robust to stale ephemeral nodes

2013-11-13 Thread Benjamin Mahler (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13821632#comment-13821632 ] Benjamin Mahler commented on MESOS-422: --- [~xujyan] have you thought about how we

[jira] [Commented] (MESOS-422) Master leader election should be more robust to stale ephemeral nodes

2013-11-13 Thread Yan Xu (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13821642#comment-13821642 ] Yan Xu commented on MESOS-422: -- [~vinodkone] and I talked about storing protobuf blob with

[jira] [Commented] (MESOS-422) Master leader election should be more robust to stale ephemeral nodes

2013-11-13 Thread Bill Farner (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13821667#comment-13821667 ] Bill Farner commented on MESOS-422: --- Instead of generating your own UUID, can you instead

[jira] [Commented] (MESOS-422) Master leader election should be more robust to stale ephemeral nodes

2013-11-13 Thread Benjamin Mahler (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13821711#comment-13821711 ] Benjamin Mahler commented on MESOS-422: --- [~wfarner] I prefer that option since it

Re: Review Request 14946: Catch-up Replicated Log 3: added recover process.

2013-11-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14946/ --- (Updated Nov. 13, 2013, 8:40 p.m.) Review request for mesos and Benjamin

Re: Review Request 14902: Catch-up Replicated Log 2: libprocessify the coordinator.

2013-11-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14902/ --- (Updated Nov. 13, 2013, 8:41 p.m.) Review request for mesos and Benjamin

Re: Review Request 14631: Catch-up Replicated Log 1: decoupled coordinator logics and made them asynchronous.

2013-11-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14631/ --- (Updated Nov. 13, 2013, 8:41 p.m.) Review request for mesos and Benjamin

Re: Review Request 14434: Added list of TaskStatuses to Task message.

2013-11-13 Thread Brenden Matthews
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14434/ --- (Updated Nov. 13, 2013, 10:17 p.m.) Review request for mesos and Benjamin

Re: Review Request 14669: launchTasks on list of offers

2013-11-13 Thread Niklas Nielsen
On Nov. 4, 2013, 8:37 p.m., Ben Mahler wrote: Cool! Sorry for taking so long to look at this! We should dogfood our own API changes, can you send out a subsequent change for all of the test frameworks to update any calls to launchTasks? Thanks for the review Ben! You bet, I'll

Re: Review Request 14434: Added list of TaskStatuses to Task message.

2013-11-13 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14434/#review28844 --- Ship it! Ship It! - Niklas Nielsen On Nov. 13, 2013, 10:17

Re: Review Request 15215: Support displaying some charts in mesos webui

2013-11-13 Thread Ross Allen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15215/#review28843 --- src/webui/master/static/home.html

Re: Review Request 15215: Support displaying some charts in mesos webui

2013-11-13 Thread Ross Allen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15215/#review28846 --- src/webui/master/static/home.html

Review Request 15500:

2013-11-13 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15500/ --- Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos-git

Re: Review Request 15500:

2013-11-13 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15500/ --- (Updated Nov. 13, 2013, 11:04 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 15500: Hard tabs in monitor.cpp

2013-11-13 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15500/ --- (Updated Nov. 13, 2013, 11:03 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 15500:

2013-11-13 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15500/ --- (Updated Nov. 13, 2013, 11:03 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 15500: Hard tabs in monitor.cpp

2013-11-13 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15500/ --- (Updated Nov. 13, 2013, 11:04 p.m.) Review request for mesos, Ben Mahler and

[jira] [Commented] (MESOS-776) Sandbox browsing errors are not shown in the webui.

2013-11-13 Thread Ross Allen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13822028#comment-13822028 ] Ross Allen commented on MESOS-776: -- [~bmahler], can you give an example of when you would

[jira] [Assigned] (MESOS-776) Sandbox browsing errors are not shown in the webui.

2013-11-13 Thread Ross Allen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ross Allen reassigned MESOS-776: Assignee: Ross Allen Sandbox browsing errors are not shown in the webui.

[jira] [Updated] (MESOS-776) Sandbox browsing errors are not shown in the webui.

2013-11-13 Thread Ross Allen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ross Allen updated MESOS-776: - Assignee: Benjamin Mahler (was: Ross Allen) Sandbox browsing errors are not shown in the webui.

Re: Review Request 15500: Hard tabs in monitor.cpp

2013-11-13 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15500/#review28849 --- Ship it! Ship It! - Vinod Kone On Nov. 13, 2013, 11:04 p.m.,

Re: Review Request 14434: Added list of TaskStatuses to Task message.

2013-11-13 Thread Brenden Matthews
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14434/#review28850 --- I'll hold off on merging this until I hear from some of the others.

[jira] [Comment Edited] (MESOS-473) Freezer fails fatally when it is unable to write 'FROZEN' to freezer.state

2013-11-13 Thread Chi Zhang (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13822053#comment-13822053 ] Chi Zhang edited comment on MESOS-473 at 11/14/13 1:09 AM: --- The

[jira] [Commented] (MESOS-473) Freezer fails fatally when it is unable to write 'FROZEN' to freezer.state

2013-11-13 Thread Chi Zhang (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13822053#comment-13822053 ] Chi Zhang commented on MESOS-473: - The destroy code path does try to write FROZEN in every

[jira] [Updated] (MESOS-600) Rework Isolator abstraction

2013-11-13 Thread Chris Lambert (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lambert updated MESOS-600: Flagged: Impediment Rework Isolator abstraction ---

[jira] [Updated] (MESOS-600) Rework Isolator abstraction

2013-11-13 Thread Chris Lambert (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lambert updated MESOS-600: Flagged: (was: Impediment) Rework Isolator abstraction ---

Re: Review Request 15500: Hard tabs in monitor.cpp

2013-11-13 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15500/#review28852 --- Ship it! Ship It! - Ben Mahler On Nov. 13, 2013, 11:04 p.m.,

[jira] [Commented] (MESOS-776) Sandbox browsing errors are not shown in the webui.

2013-11-13 Thread Benjamin Mahler (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13822073#comment-13822073 ] Benjamin Mahler commented on MESOS-776: --- Ah yes, in this case there is no string.