Re: Review Request 15169: Expose git sha and branch in master and slave state.json

2013-11-26 Thread Niklas Nielsen
On Nov. 25, 2013, 2:30 a.m., Benjamin Hindman wrote: src/Makefile.am, line 261 https://reviews.apache.org/r/15169/diff/2/?file=376203#file376203line261 Cool! Is it easy to determine the tag too? That would save one extra git command for people trying to answer email questions and

[jira] [Created] (MESOS-846) FaultToleranceTest.ReregisterFrameworkExitedExecutor is flaky.

2013-11-26 Thread Jie Yu (JIRA)
Jie Yu created MESOS-846: Summary: FaultToleranceTest.ReregisterFrameworkExitedExecutor is flaky. Key: MESOS-846 URL: https://issues.apache.org/jira/browse/MESOS-846 Project: Mesos Issue Type: Bug

[jira] [Commented] (MESOS-846) FaultToleranceTest.ReregisterFrameworkExitedExecutor is flaky.

2013-11-26 Thread Jie Yu (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832852#comment-13832852 ] Jie Yu commented on MESOS-846: -- {noformat} tests/fault_tolerance_tests.cpp:1129: Failure Mock

[jira] [Created] (MESOS-847) Update Mesos webui favicon to use Mesos Logo

2013-11-26 Thread Zameer Manji (JIRA)
Zameer Manji created MESOS-847: -- Summary: Update Mesos webui favicon to use Mesos Logo Key: MESOS-847 URL: https://issues.apache.org/jira/browse/MESOS-847 Project: Mesos Issue Type: Improvement

[jira] [Closed] (MESOS-847) Update Mesos webui favicon to use Mesos Logo

2013-11-26 Thread Benjamin Mahler (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Mahler closed MESOS-847. - Resolution: Duplicate Update Mesos webui favicon to use Mesos Logo

[jira] [Created] (MESOS-848) Temp file leak in ZooKeeperTestServer

2013-11-26 Thread Jie Yu (JIRA)
Jie Yu created MESOS-848: Summary: Temp file leak in ZooKeeperTestServer Key: MESOS-848 URL: https://issues.apache.org/jira/browse/MESOS-848 Project: Mesos Issue Type: Bug Reporter: Jie

Re: Review Request 15653: Adds systemLoad() convenience method to stout

2013-11-26 Thread Niklas Nielsen
On Nov. 19, 2013, 11:33 p.m., Ben Mahler wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, lines 839-841 https://reviews.apache.org/r/15653/diff/2/?file=388562#file388562line839 Hey Nik, I see your gist here: https://gist.github.com/nqn/7493244 More

Re: Review Request 15653: Adds systemLoad() convenience method to stout

2013-11-26 Thread Ben Mahler
On Nov. 19, 2013, 11:33 p.m., Ben Mahler wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, lines 839-841 https://reviews.apache.org/r/15653/diff/2/?file=388562#file388562line839 Hey Nik, I see your gist here: https://gist.github.com/nqn/7493244 More

[jira] [Created] (MESOS-849) As a developer I should be able to set the AUTOMAKE and ACLOCAL environment variables for autoconf to pickup when using the bootstrap script.

2013-11-26 Thread Bernardo Gomez Palacio (JIRA)
Bernardo Gomez Palacio created MESOS-849: Summary: As a developer I should be able to set the AUTOMAKE and ACLOCAL environment variables for autoconf to pickup when using the bootstrap script. Key: MESOS-849

Re: Review Request 15653: Adds systemLoad() convenience method to stout

2013-11-26 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15653/ --- (Updated Nov. 26, 2013, 7:33 p.m.) Review request for mesos, Benjamin Hindman,

Review Request 15862: Enable AUTOMAKE and ACLOCAL env variables for bootstrap.

2013-11-26 Thread Bernardo Gomez Palacio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15862/ --- Review request for mesos. Repository: mesos-git Description ---

[jira] [Created] (MESOS-851) Scheduler Driver does not guarantee that abort() prevents further calls on the Scheduler.

2013-11-26 Thread Benjamin Mahler (JIRA)
Benjamin Mahler created MESOS-851: - Summary: Scheduler Driver does not guarantee that abort() prevents further calls on the Scheduler. Key: MESOS-851 URL: https://issues.apache.org/jira/browse/MESOS-851

Re: Review Request 15862: Enable AUTOMAKE and ACLOCAL env variables for bootstrap.

2013-11-26 Thread Bernardo Gomez Palacio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15862/ --- (Updated Nov. 26, 2013, 9:30 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 15745: Fixed some task reconciliation cases.

2013-11-26 Thread Brenden Matthews
On Nov. 22, 2013, 8:04 p.m., Niklas Nielsen wrote: Did we get to a conclusion regarding case 1)? and could we write a test which exercises the new scenarios? Brenden Matthews wrote: If I get some time, I'll write a test. I've been testing it in production for a few days though.

Re: Review Request 15169: Expose git sha and branch in master and slave state.json

2013-11-26 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15169/ --- (Updated Nov. 27, 2013, 12:33 a.m.) Review request for mesos, Benjamin

Re: Review Request 15169: Expose git sha and branch in master and slave state.json

2013-11-26 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15169/ --- (Updated Nov. 27, 2013, 12:36 a.m.) Review request for mesos, Benjamin

Review Request 15866: Supported process::Shared::release().

2013-11-26 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15866/ --- Review request for mesos and Benjamin Hindman. Repository: mesos-git

Re: Review Request 15169: Expose git sha and branch in master and slave state.json

2013-11-26 Thread Jason Dusek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15169/#review29467 --- src/Makefile.am https://reviews.apache.org/r/15169/#comment56696

Re: Review Request 15169: Expose git sha and branch in master and slave state.json

2013-11-26 Thread Jason Dusek
On Nov. 27, 2013, 1:07 a.m., Jason Dusek wrote: src/Makefile.am, line 269 https://reviews.apache.org/r/15169/diff/4/?file=391302#file391302line269 The shell expression passed to -c could be simplified. Instead of: SHA=`git log -n 1 --format=%H 2 /dev/null` if [ $?

Re: Review Request 15868: Fixed flaky test ZooKeeperMasterContenderDetectorTest.ContenderDetectorShutdownNetwork.

2013-11-26 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15868/#review29470 --- src/tests/master_contender_detector_tests.cpp

Re: Review Request 15285: toString() for flag values.

2013-11-26 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15285/ --- (Updated Nov. 27, 2013, 3:54 a.m.) Review request for mesos, Benjamin Hindman

[jira] [Assigned] (MESOS-851) Scheduler Driver does not guarantee that abort() prevents further calls on the Scheduler.

2013-11-26 Thread Benjamin Mahler (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Mahler reassigned MESOS-851: - Assignee: Benjamin Mahler Scheduler Driver does not guarantee that abort() prevents

Re: Review Request 15853: Fixed scheduler driver to minimize sending duplicate status updates to the scheduler.

2013-11-26 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15853/#review29473 --- I've sent out https://reviews.apache.org/r/15872 to address the

Re: Review Request 15169: Expose git sha and branch in master and slave state.json

2013-11-26 Thread Niklas Nielsen
On Nov. 27, 2013, 1:07 a.m., Jason Dusek wrote: src/Makefile.am, line 269 https://reviews.apache.org/r/15169/diff/4/?file=391302#file391302line269 The shell expression passed to -c could be simplified. Instead of: SHA=`git log -n 1 --format=%H 2 /dev/null` if [ $?

Re: Mesos conflicts with gevent?

2013-11-26 Thread Benjamin Hindman
Hey Paco, The semantics of Scheduler's and Executor's is that only one callback will be invoked at at time. So if you don't return from Executor.launchTask then you won't get any more callbacks, hence the use of threading. Feel free to use any other means of invoking the task, just as long as you

Re: Mesos conflicts with gevent?

2013-11-26 Thread Paco Nathan
Many thanks Ben - The problem may be a bit more complex. When a Python executor runs, there appears to be some conflict with gevent (based on libevent) if it's running elsewhere in the code. Even with an os.fork() within Executor.launchTask, then detaching the child process, use of gevent within

Re: Review Request 15868: Fixed flaky test ZooKeeperMasterContenderDetectorTest.ContenderDetectorShutdownNetwork.

2013-11-26 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15868/ --- (Updated Nov. 27, 2013, 7:47 a.m.) Review request for mesos, Benjamin Hindman,