[
https://issues.apache.org/jira/browse/MESOS-890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13914707#comment-13914707
]
Bill Farner commented on MESOS-890:
---
Ideally the approach we come up with doesn't require
[
https://issues.apache.org/jira/browse/MESOS-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothy St. Clair reassigned MESOS-1037:
Assignee: Timothy St. Clair
Exited child process status
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18386/#review35632
---
src/linux/fs.hpp
https://reviews.apache.org/r/18386/#comment66266
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18386/
---
(Updated Feb. 27, 2014, 9:12 a.m.)
Review request for mesos and Ben Mahler.
[
https://issues.apache.org/jira/browse/MESOS-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13914767#comment-13914767
]
Dominic Hamon commented on MESOS-750:
-
This means we will no longer be able to build
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18565/#review35641
---
Ship it!
Ship It!
- Ian Downes
On Feb. 27, 2014, 5:43 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18540/#review35642
---
Ship it!
Ship It!
- Benjamin Hindman
On Feb. 26, 2014, 10:14
On Feb. 26, 2014, 10:29 a.m., Ian Downes wrote:
I think we need to work on this a little. It seems that making the
launching state explicit and then cleaning up behavior (killTask) when in
this state is necessary.
Thanks for the prompt review! :)
On Feb. 26, 2014, 10:29 a.m., Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18307/#review35645
---
Ship it!
Ship It!
- Dominic Hamon
On Feb. 24, 2014, 7:13 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18426/#review35646
---
Ship it!
Ship It!
- Dominic Hamon
On Feb. 24, 2014, 8 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18307/
---
(Updated Feb. 27, 2014, 6:10 p.m.)
Review request for mesos and Vinod Kone.
[
https://issues.apache.org/jira/browse/MESOS-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13914811#comment-13914811
]
Dominic Hamon commented on MESOS-1030:
--
This also affects clang 3.4 installed on
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18426/#review35653
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 27, 2014, 6:18 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18426/
---
(Updated Feb. 27, 2014, 6:18 p.m.)
Review request for mesos and Vinod Kone.
On Feb. 27, 2014, 10:14 a.m., Niklas Nielsen wrote:
Ship It!
I can go ahead and commit this (if @vinodkone isn't already doing it? :)
- Niklas
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18307/#review35648
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 27, 2014, 6:10 p.m.,
On Nov. 22, 2013, 12:04 p.m., Niklas Nielsen wrote:
Did we get to a conclusion regarding case 1)? and could we write a test
which exercises the new scenarios?
Brenden Matthews wrote:
If I get some time, I'll write a test. I've been testing it in
production for a few days though.
[
https://issues.apache.org/jira/browse/MESOS-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13914836#comment-13914836
]
Benjamin Mahler commented on MESOS-750:
---
We definitely don't want to alienate
[
https://issues.apache.org/jira/browse/MESOS-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vinod Kone resolved MESOS-1030.
---
Resolution: Fixed
commit 162a7f5d84b3cc04e5f3a612e62bf76f1c1c25a4
Author: Bernd Mathiske
[
https://issues.apache.org/jira/browse/MESOS-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vinod Kone resolved MESOS-1029.
---
Resolution: Fixed
Fix Version/s: 0.19.0
commit 66155da331d54710121e92db45358ea91aaac15d
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18489/#review35662
---
Should we make the same update to Option in this patch, now that we
There's no release dates that I know of.
For debian, you can always get 'testing' repos included and then cherrypick
clang3.3+ or g++4.8+ from those repositories. It's a bit hairy but not
beyond the average developer. I think, as always, clear communication in
the ./configure step is key. Though
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18549/#review35651
---
Ship it!
With these abstractions now it seems like the guide will
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18550/#review35644
---
3rdparty/libprocess/include/process/check.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18549/
---
(Updated Feb. 27, 2014, 11:03 a.m.)
Review request for mesos and Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18386/#review35673
---
Hey Dominic, I found an issue applying these Option patches, looks
On Feb. 27, 2014, 6:37 p.m., Ben Mahler wrote:
Should we make the same update to Option in this patch, now that we pulled
it out of https://reviews.apache.org/r/18383/ ?
Dominic Hamon wrote:
Option doesn't have a method that returns a string.
:)
- Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18549/
---
(Updated Feb. 27, 2014, 11:08 a.m.)
Review request for mesos and Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18551/#review35671
---
src/exec/exec.cpp
https://reviews.apache.org/r/18551/#comment66345
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18550/
---
(Updated Feb. 27, 2014, 11:18 a.m.)
Review request for mesos and Benjamin
[
https://issues.apache.org/jira/browse/MESOS-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13914921#comment-13914921
]
Benjamin Mahler commented on MESOS-1037:
Ah yes, that would be because libev is
On Feb. 27, 2014, 11:03 a.m., Benjamin Hindman wrote:
3rdparty/libprocess/include/process/subprocess.hpp, lines 151-152
https://reviews.apache.org/r/18550/diff/1/?file=505253#file505253line151
The 'strings::join' is likely not async signal safe since it does
allocation. If you'd
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18551/
---
(Updated Feb. 27, 2014, 11:23 a.m.)
Review request for mesos and Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18584/
---
Review request for mesos, Benjamin Hindman and Ben Mahler.
Bugs: MESOS-984
[
https://issues.apache.org/jira/browse/MESOS-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13914951#comment-13914951
]
Timothy St. Clair commented on MESOS-1037:
--
Ahh, that makes perfect sense then.
Hi all,
The vote for Mesos 0.17.0 (rc2) has passed with the
following votes.
+1 (Binding)
--
Benjamin Mahler
Niklas Nielsen
Vinod Kone
There were no 0 or -1 votes.
Please find the release at:
https://dist.apache.org/repos/dist/release/mesos/0.17.0
It is recommended
[
https://issues.apache.org/jira/browse/MESOS-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13914990#comment-13914990
]
Bernd Mathiske commented on MESOS-1030:
---
Thanks for committing all my submitted
On Feb. 21, 2014, 12:12 a.m., Benjamin Hindman wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp, line 107
https://reviews.apache.org/r/18093/diff/5/?file=499572#file499572line107
IMHO, providing element iteration can be sneaky and cause unintended
performance
On Feb. 27, 2014, 4:33 a.m., Vinod Kone wrote:
This is causing our Jenkins builds to be flaky. Ian, can you update the
review after addressing benm's comments? I'll get this committed.
I'm fixing this test right now but this shouldn't be on master or being built?
- Ian
On Feb. 21, 2014, 12:13 a.m., Ben Mahler wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp, lines 99-104
https://reviews.apache.org/r/18093/diff/5/?file=499572#file499572line99
Is this useful outside of testing..?
Jie Yu wrote:
It's only used in testing.
On Jan. 27, 2014, 10:44 p.m., Vinod Kone wrote:
src/slave/slave.cpp, lines 725-728
https://reviews.apache.org/r/16724/diff/3/?file=425219#file425219line725
I think you've brought this up before but did you figure out why a
completed executor has terminated tasks?
Adam B wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16724/
---
(Updated Feb. 27, 2014, 8:28 p.m.)
Review request for mesos and Benjamin
On Jan. 29, 2014, 4:58 p.m., Vinod Kone wrote:
src/slave/slave.cpp, line 712
https://reviews.apache.org/r/16724/diff/4/?file=454079#file454079line712
why the different log level?
s/2/1/?
Adam B wrote:
I figured that the different log levels could be used for
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18276/
---
(Updated Feb. 27, 2014, 8:31 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18577/#review35699
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 27, 2014, 6:43 p.m.,
[
https://issues.apache.org/jira/browse/MESOS-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ian Downes resolved MESOS-348.
--
Resolution: Fixed
Fix Version/s: 0.18.0
Local runs now create a containerizer according to Flags
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18311/
---
(Updated Feb. 27, 2014, 8:39 p.m.)
Review request for mesos and Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18289/#review35701
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 19, 2014, 8:19 p.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17476/#review35697
---
Ship it!
Looks great! Mostly I'm just wondering if we can make
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18311/
---
(Updated Feb. 27, 2014, 9:11 p.m.)
Review request for mesos and Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18311/#review35707
---
Ship it!
Ship It!
- Adam B
On Feb. 27, 2014, 1:11 p.m., Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18295/
---
(Updated Feb. 27, 2014, 1:32 p.m.)
Review request for mesos, Benjamin Hindman,
Till Toenshoff created MESOS-1046:
-
Summary: Use of leading underscore in names (global symbols and
defines)
Key: MESOS-1046
URL: https://issues.apache.org/jira/browse/MESOS-1046
Project: Mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18339/
---
(Updated Feb. 27, 2014, 1:40 p.m.)
Review request for mesos, Ben Mahler and
On Feb. 27, 2014, 11:09 a.m., Ben Mahler wrote:
Hey Dominic, I found an issue applying these Option patches, looks like
slave.cpp:3001 (
https://github.com/apache/mesos/blob/20a6993e1b50bf46089cd5e059634ac446b08ac2/src/slave/slave.cpp#L3001
) is problematic:
struct ExecutorState
[
https://issues.apache.org/jira/browse/MESOS-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ian Downes reopened MESOS-348:
--
[~bmahler] raised the issue that multiple containerizers could stomp on each
other.
This will occur
On Nov. 22, 2013, 8:04 p.m., Niklas Nielsen wrote:
Did we get to a conclusion regarding case 1)? and could we write a test
which exercises the new scenarios?
Brenden Matthews wrote:
If I get some time, I'll write a test. I've been testing it in
production for a few days though.
On Nov. 22, 2013, 8:04 p.m., Niklas Nielsen wrote:
Did we get to a conclusion regarding case 1)? and could we write a test
which exercises the new scenarios?
Brenden Matthews wrote:
If I get some time, I'll write a test. I've been testing it in
production for a few days though.
On Feb. 27, 2014, 7:09 p.m., Ben Mahler wrote:
Hey Dominic, I found an issue applying these Option patches, looks like
slave.cpp:3001 (
https://github.com/apache/mesos/blob/20a6993e1b50bf46089cd5e059634ac446b08ac2/src/slave/slave.cpp#L3001
) is problematic:
struct ExecutorState
On Thu, Feb 27, 2014 at 1:53 PM, Ben Mahler benjamin.mah...@gmail.comwrote:
On Feb. 27, 2014, 7:09 p.m., Ben Mahler wrote:
Hey Dominic, I found an issue applying these Option patches, looks
like slave.cpp:3001 (
On Feb. 27, 2014, 7:09 p.m., Ben Mahler wrote:
Hey Dominic, I found an issue applying these Option patches, looks like
slave.cpp:3001 (
https://github.com/apache/mesos/blob/20a6993e1b50bf46089cd5e059634ac446b08ac2/src/slave/slave.cpp#L3001
) is problematic:
struct ExecutorState
On Thu, Feb 27, 2014 at 2:02 PM, Ben Mahler benjamin.mah...@gmail.comwrote:
On Feb. 27, 2014, 7:09 p.m., Ben Mahler wrote:
Hey Dominic, I found an issue applying these Option patches, looks
like slave.cpp:3001 (
Well, why would they be extending the lifetime of a temporary if they don't
understand the semantics in the first place? :)
They should understand the difference between:
const T t = foo(); // Returns T.
const T t = option.get(); // Ok.
const T t = (temporaryOption()).get(); // Bad!
This
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18488/#review35717
---
Ship it!
src/log/coordinator.cpp
On Feb. 27, 2014, 12:26 p.m., Benjamin Hindman wrote:
src/tests/fault_tolerance_tests.cpp, line 665
https://reviews.apache.org/r/16724/diff/7/?file=497356#file497356line665
Please move '{' to newline and use const for parameters (and did you
really want to return a 'const
[
https://issues.apache.org/jira/browse/MESOS-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915134#comment-13915134
]
Dominic Hamon commented on MESOS-750:
-
[~vinodkone] and I looked into this a bit. Right
[
https://issues.apache.org/jira/browse/MESOS-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915142#comment-13915142
]
Dominic Hamon commented on MESOS-1044:
--
As per my comment on MESOS-750, we actually
[
https://issues.apache.org/jira/browse/MESOS-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915144#comment-13915144
]
Dominic Hamon commented on MESOS-750:
-
4.5 has 'new wording' for lambdas. the project
[
https://issues.apache.org/jira/browse/MESOS-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915144#comment-13915144
]
Dominic Hamon edited comment on MESOS-750 at 2/27/14 10:55 PM:
[
https://issues.apache.org/jira/browse/MESOS-181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam B updated MESOS-181:
-
Labels: virtualiza virtualiztion (was: virtualiztion)
Virtual Machine Isolation Module
[
https://issues.apache.org/jira/browse/MESOS-181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam B updated MESOS-181:
-
Labels: virtualiztion (was: virtualiza virtualiztion)
Virtual Machine Isolation Module
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18276/#review35727
---
Ship it!
src/tests/isolator_tests.cpp
On Feb. 27, 2014, 11:05 a.m., Vinod Kone wrote:
src/common/attributes.cpp, line 18
https://reviews.apache.org/r/18295/diff/1/?file=498397#file498397line18
new line.
pull this after 3rd party includes.
the google-style (that we say we follow) is to have the matching
On Feb. 27, 2014, 2:28 p.m., Benjamin Hindman wrote:
include/mesos/executor.hpp, line 26
https://reviews.apache.org/r/18295/diff/2/?file=506458#file506458line26
We've used for headers that may get installed. AFAICT, this is
pretty standard (Boost, etc), but definitely not
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18594/
---
Review request for mesos.
Repository: mesos-git
Description
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18597/
---
Review request for mesos.
Bugs: MESOS-1031
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18595/
---
Review request for mesos.
Repository: mesos-git
Description
---
New
[
https://issues.apache.org/jira/browse/MESOS-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915285#comment-13915285
]
Niklas Quarfot Nielsen commented on MESOS-1031:
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18599/
---
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18599/#review35733
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 28, 2014, 12:50 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18595/
---
(Updated Feb. 27, 2014, 4:54 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18594/
---
(Updated Feb. 27, 2014, 4:55 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18600/
---
Review request for mesos, Benjamin Hindman and Ben Mahler.
Bugs: MESOS-984
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18597/#review35739
---
src/launcher/executor.cpp
On Feb. 27, 2014, 5:16 p.m., Vinod Kone wrote:
src/launcher/executor.cpp, lines 230-236
https://reviews.apache.org/r/18597/diff/1/?file=506548#file506548line230
Since the slave is already doing the signal escalation, what is the
benefit of doing it here?
If we can change the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17567/
---
(Updated Feb. 28, 2014, 1:23 a.m.)
Review request for mesos, Adam B, Benjamin
On Feb. 18, 2014, 5:32 p.m., Dominic Hamon wrote:
src/slave/containerizer/pluggable_containerizer.cpp, line 68
https://reviews.apache.org/r/17567/diff/6/?file=496485#file496485line68
you have a 'using std::string' so you don't need the std:: prefices
throughout.
Oops, that
On Feb. 28, 2014, 1:16 a.m., Vinod Kone wrote:
src/launcher/executor.cpp, lines 230-236
https://reviews.apache.org/r/18597/diff/1/?file=506548#file506548line230
Since the slave is already doing the signal escalation, what is the
benefit of doing it here?
Niklas Nielsen
[
https://issues.apache.org/jira/browse/MESOS-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dave Lester reassigned MESOS-1011:
--
Assignee: Tobi Knaup (was: Jake Farrell)
Relative links are broken within documentation
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/1653/changes
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/1926/changes
Changes:
[vinod] Fixed incorrect stderr to stdout pipe routing in configuration phase.
--
[...truncated 27331 lines...]
2014-02-28
On Feb. 28, 2014, 12:18 a.m., Vinod Kone wrote:
src/tests/isolator_tests.cpp, line 385
https://reviews.apache.org/r/18276/diff/1-3/?file=497920#file497920line385
What about just killing this?
i'll commit this as is. Will revisit if this causes issues.
- Vinod
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/1928/changes
Changes:
[vinod] Added a test for CFS cpu limits in the cpu isolator.
--
[...truncated 9124 lines...]
I0228 07:46:11.592021 3630
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/1655/changes
Changes:
[vinod] Added a test for CFS cpu limits in the cpu isolator.
--
[...truncated 10515 lines...]
I0228 07:50:04.739220 4856 exec.cpp:217]
94 matches
Mail list logo
