Mesos 0.20.1 release status

2014-09-16 Thread Bhuvan Arumugam
We are targetting 17 tickets. It include improvements and bug fixes. 4 of them are still in progress. http://s.apache.org/mesos-0.20.1-unresolved-issues I'll cut the tag for RC1 and send for voting, once these issues are reviewed/submitted or 9/15 @6pm PDT, whichever comes first! The open

Re: Review Request 25566: Minor cleanups to the Master code.

2014-09-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25566/#review53449 --- Ship it! src/master/master.cpp

Re: Review Request 25567: Hold on to unacknowledged terminal tasks in the Master.

2014-09-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25567/#review53450 --- Ship it! src/master/master.hpp

Re: Mesos 0.20.1 release status

2014-09-16 Thread Timothy Chen
It's already past 9/16 6 pm PDT? Tim On Tue, Sep 16, 2014 at 2:19 AM, Bhuvan Arumugam bhu...@apache.org wrote: We are targetting 17 tickets. It include improvements and bug fixes. 4 of them are still in progress. http://s.apache.org/mesos-0.20.1-unresolved-issues I'll cut the tag for RC1

Re: Review Request 25568: Added tests for terminal unacknowledged tasks in the Master.

2014-09-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25568/#review53484 --- src/tests/master_tests.cpp

Re: Mesos 0.20.1 release status

2014-09-16 Thread Vinod Kone
On Mon, Sep 15, 2014 at 11:19 PM, Bhuvan Arumugam bhu...@apache.org wrote: I'll cut the tag for RC1 and send for voting, once these issues are reviewed/submitted or 9/15 @6pm PDT, whichever comes first! The open issues (if any) will be moved to next release, at that point in time. You want

Re: Mesos 0.20.1 release status

2014-09-16 Thread Jie Yu
Bhuvan, Thanks a ton! Are you going to do a cut, or cherry-pick on top of 0.20.0? - Jie On Mon, Sep 15, 2014 at 11:19 PM, Bhuvan Arumugam bhu...@apache.org wrote: We are targetting 17 tickets. It include improvements and bug fixes. 4 of them are still in progress.

Re: Review Request 25569: Refactor test environment validations

2014-09-16 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25569/ --- (Updated Sept. 16, 2014, 7:07 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 25569: Refactor test environment validations

2014-09-16 Thread Timothy Chen
On Sept. 12, 2014, 11:39 p.m., Ben Mahler wrote: Thanks for following up! Not your fault, but the current design of enable() seems a bit unfortunate, because we will print things excessively unless we use static variables as you've done here. What about the following instead?

Re: Review Request 25569: Refactor test environment validations

2014-09-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25569/#review53491 --- Bad patch! Reviews applied: [25569] Failed command:

Re: Review Request 25250: Mark running tasks killed during framework shutdown.

2014-09-16 Thread Alexander Rukletsov
On Sept. 15, 2014, 4:38 p.m., Benjamin Hindman wrote: src/master/master.cpp, line 4010 https://reviews.apache.org/r/25250/diff/4/?file=682254#file682254line4010 I suggest we use TASK_LOST here instead. We definitely want a terminal state like TASK_KILLED, but we've reserved

Review Request 25695: Update to enable systemd control of mesos services

2014-09-16 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25695/ --- Review request for mesos, Jie Yu and Vinod Kone. Bugs: MESOS-1195

Re: Review Request 25523: Add Docker pull to docker abstraction

2014-09-16 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25523/#review53528 --- src/docker/docker.hpp

Re: Review Request 25270: Enable bridge network in Mesos

2014-09-16 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/#review53531 --- Ship it! src/tests/docker_containerizer_tests.cpp

Re: Review Request 25403: Override entrypoint when shell enabled in Docker

2014-09-16 Thread Benjamin Hindman
On Sept. 9, 2014, 6:50 p.m., Benjamin Hindman wrote: src/docker/docker.cpp, line 337 https://reviews.apache.org/r/25403/diff/1/?file=680701#file680701line337 Why not move this up above as well? Timothy Chen wrote: The Docker cli --entrypoint only allows you to put in a

Re: Review Request 25695: Update to enable systemd control of mesos services

2014-09-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25695/#review53534 --- Bad patch! Reviews applied: [25695] Failed command: ./configure

Re: Review Request 25403: Override entrypoint when shell enabled in Docker

2014-09-16 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25403/#review53533 --- Ship it! But I re-opened the '-c' issue so that you can add a

Re: Review Request 24776: Add docker containerizer destroy tests

2014-09-16 Thread Benjamin Hindman
On Sept. 9, 2014, 6:15 p.m., Benjamin Hindman wrote: Why did you need to mock DockerContainerizerProcess in order to write these tests? Couldn't you have just used the existing MockDockerContainerizer? Timothy Chen wrote: I wanted to simulate having destroy called in a

Re: Review Request 25569: Refactor test environment validations

2014-09-16 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25569/#review53541 --- src/tests/environment.cpp

Re: Completed tasks remains in TASK_RUNNING when framework is disconnected

2014-09-16 Thread Niklas Nielsen
Okay - that only solves half of the problem for us: users will still see their frameworks as running even though they completed but it is a first step. Let's continue the discussion in a JIRA ticket; I'll create one shortly. Thanks for helping out! Niklas On 15 September 2014 18:17, Benjamin

Re: Review Request 25695: Update to enable systemd control of mesos services

2014-09-16 Thread Timothy St. Clair
On Sept. 16, 2014, 3:38 p.m., Mesos ReviewBot wrote: Bad patch! Reviews applied: [25695] Failed command: ./configure Error: checking build system type... x86_64-unknown-linux-gnu checking host system type... x86_64-unknown-linux-gnu checking target system type...

Re: Review Request 25597: Added a version checker class to stout.

2014-09-16 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25597/#review53553 --- Looking much better, thanks Kapil!!

Re: Review Request 25695: Update to enable systemd control of mesos services

2014-09-16 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25695/ --- (Updated Sept. 16, 2014, 6:19 p.m.) Review request for mesos, Jie Yu and Vinod

Re: Review Request 25663: MESOS-1392: MasterDetector now returns a None when it cannot read the content of the ZNode it has detected.

2014-09-16 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25663/#review53558 --- src/master/detector.cpp

Re: Review Request 25597: Added a version checker class to stout.

2014-09-16 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25597/ --- (Updated Sept. 16, 2014, 2:48 p.m.) Review request for mesos, Adam B and

Re: Review Request 25597: Added a version checker class to stout.

2014-09-16 Thread Ben Mahler
On Sept. 15, 2014, 6:46 p.m., Ben Mahler wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp, lines 32-34 https://reviews.apache.org/r/25597/diff/3/?file=688423#file688423line32 The program will crash if the split is non-numeric, because you'll call .get() on a

Re: Review Request 25695: Update to enable systemd control of mesos services

2014-09-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25695/#review53571 --- Patch looks great! Reviews applied: [25695] All tests passed. -

Re: Review Request 25597: Added a version checker class to stout.

2014-09-16 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25597/#review53569 --- Almost there!! I think we can get away with not needing to expose

Re: Review Request 25597: Added a version checker class to stout.

2014-09-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25597/#review53572 --- Bad patch! Reviews applied: [25597] Failed command:

Hadoop on Mesos

2014-09-16 Thread Tom Arnfeld
Hey everyone, I've been working on a potential extension to Hadoop on Mesos which allows the framework to potentially release allocated (but idle) TaskTracker slots if they are doing nothing. This helps release resources hadoop is allocated but not using, to increase overall cluster utilisation

Re: Review Request 25597: Added a version checker class to stout.

2014-09-16 Thread Kapil Arya
On Sept. 15, 2014, 2:46 p.m., Ben Mahler wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp, lines 32-34 https://reviews.apache.org/r/25597/diff/3/?file=688423#file688423line32 The program will crash if the split is non-numeric, because you'll call .get() on a

Re: Review Request 25597: Added a version checker class to stout.

2014-09-16 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25597/ --- (Updated Sept. 16, 2014, 4:39 p.m.) Review request for mesos, Adam B and

Re: Review Request 25597: Added a version checker class to stout.

2014-09-16 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25597/ --- (Updated Sept. 16, 2014, 4:40 p.m.) Review request for mesos, Adam B and

Re: Review Request 25597: Added a version checker class to stout.

2014-09-16 Thread Ben Mahler
On Sept. 15, 2014, 6:46 p.m., Ben Mahler wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp, lines 32-34 https://reviews.apache.org/r/25597/diff/3/?file=688423#file688423line32 The program will crash if the split is non-numeric, because you'll call .get() on a

Re: Review Request 25035: Fix for MESOS-1688

2014-09-16 Thread Martin Weindel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25035/ --- (Updated Sept. 16, 2014, 9:05 nachm.) Review request for mesos and Vinod Kone.

Re: Review Request 25597: Added a version checker class to stout.

2014-09-16 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25597/#review53595 --- Ship it! Thanks Kapil, looks great! I will get this committed for

Re: Review Request 25035: Fix for MESOS-1688

2014-09-16 Thread Martin Weindel
On Sept. 15, 2014, 9:02 nachm., Vinod Kone wrote: CHANGELOG, lines 1-9 https://reviews.apache.org/r/25035/diff/7/?file=688718#file688718line1 Thinking a bit more about this and talking to others. Adding deprecations in a bug fix release is bit weird. 2 options.

Re: Review Request 25597: Added a version checker class to stout.

2014-09-16 Thread Ben Mahler
On Sept. 16, 2014, 9:05 p.m., Ben Mahler wrote: Thanks Kapil, looks great! I will get this committed for you shortly, I'll just add a TODO per your comments on more than 3 version components and I'll remove the single quotes per my comment below. Committed! - Ben

Re: Review Request 25035: Fix for MESOS-1688

2014-09-16 Thread Timothy St. Clair
On Sept. 15, 2014, 3:23 p.m., Timothy St. Clair wrote: src/master/hierarchical_allocator_process.hpp, line 837 https://reviews.apache.org/r/25035/diff/7/?file=688721#file688721line837 What happens in the case where all CPUs are taken but memory is available? It looks like it

Re: Review Request 25035: Fix for MESOS-1688

2014-09-16 Thread Martin Weindel
On Sept. 15, 2014, 3:23 nachm., Timothy St. Clair wrote: src/master/hierarchical_allocator_process.hpp, line 837 https://reviews.apache.org/r/25035/diff/7/?file=688721#file688721line837 What happens in the case where all CPUs are taken but memory is available? It looks like it

Re: Mesos 0.20.1 release status

2014-09-16 Thread Bhuvan Arumugam
Tim, sorry. I meant today, 9/16 @6pm PDT. Vinod, yes, Adam is helping me to push CHANGELOG. I'll work with him to create tag, mvn push, etc. Jie, i'm hoping to go with tags. I'll create a tag for 0.20.1-rc1. For new RC builds (if any), i'll create new tag from previous RC and cherry-pick the bug

Re: Review Request 25597: Added a version checker class to stout.

2014-09-16 Thread Kapil Arya
On Sept. 16, 2014, 5:05 p.m., Ben Mahler wrote: Thanks Kapil, looks great! I will get this committed for you shortly, I'll just add a TODO per your comments on more than 3 version components and I'll remove the single quotes per my comment below. Ben Mahler wrote: Committed!

Re: Review Request 25035: Fix for MESOS-1688

2014-09-16 Thread Ben Mahler
On Sept. 15, 2014, 3:23 p.m., Timothy St. Clair wrote: src/master/hierarchical_allocator_process.hpp, line 837 https://reviews.apache.org/r/25035/diff/7/?file=688721#file688721line837 What happens in the case where all CPUs are taken but memory is available? It looks like it

Re: Review Request 25549: Basic filesystem isolator for Linux.

2014-09-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549/#review53402 --- A few style issues. I'll let Vinod to give a final ship it.

Re: Review Request 25597: Added a version checker class to stout.

2014-09-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25597/#review53608 --- Patch looks great! Reviews applied: [25597] All tests passed. -

Re: Review Request 25569: Refactor test environment validations

2014-09-16 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25569/ --- (Updated Sept. 16, 2014, 10:35 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 25403: Override entrypoint when shell enabled in Docker

2014-09-16 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25403/ --- (Updated Sept. 16, 2014, 10:37 p.m.) Review request for mesos, Benjamin

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2374

2014-09-16 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2374/changes Changes: [bmahler] Added a Version class to stout. -- [...truncated 58686 lines...] I0916 23:01:05.386067 21051 replica.cpp:676]

Re: Review Request 25035: Fix for MESOS-1688

2014-09-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25035/#review53621 --- Patch looks great! Reviews applied: [25035] All tests passed. -

Re: Review Request 25270: Enable bridge network in Mesos

2014-09-16 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/ --- (Updated Sept. 16, 2014, 11:04 p.m.) Review request for drill, Benjamin

Re: Review Request 25270: Enable bridge network in Mesos

2014-09-16 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/ --- (Updated Sept. 16, 2014, 11:04 p.m.) Review request for mesos, Benjamin

Build failed in Jenkins: mesos-reviewbot #1587

2014-09-16 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/1587/changes Changes: [bmahler] Added a Version class to stout. -- [...truncated 5517 lines...] Removing 3rdparty/libprocess/config.status Removing 3rdparty/libprocess/config.sub Removing

Re: Review Request 25569: Refactor test environment validations

2014-09-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25569/#review53627 --- Patch looks great! Reviews applied: [25569] All tests passed. -

Jenkins build is back to normal : mesos-reviewbot #1588

2014-09-16 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/1588/

Re: Review Request 25695: Update to enable systemd control of mesos services

2014-09-16 Thread Vinod Kone
On Sept. 16, 2014, 7:27 p.m., Mesos ReviewBot wrote: Patch looks great! Reviews applied: [25695] All tests passed. I'll let @jieyu comment shepherd this, but I think we should not rush this into 0.20.1 because this is not a bug in 0.20.0. - Vinod

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2374

2014-09-16 Thread Benjamin Mahler
+Tim Chen Can you take a look at the health check failure? https://issues.apache.org/jira/browse/MESOS-1802 I'll take a look at the Registrar test: https://issues.apache.org/jira/browse/MESOS-1803 On Tue, Sep 16, 2014 at 4:01 PM, Apache Jenkins Server jenk...@builds.apache.org wrote: See

Re: Review Request 25523: Add Docker pull to docker abstraction

2014-09-16 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25523/ --- (Updated Sept. 17, 2014, 1:06 a.m.) Review request for drill and Benjamin

Re: Review Request 25523: Add Docker pull to docker abstraction

2014-09-16 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25523/ --- (Updated Sept. 17, 2014, 1:07 a.m.) Review request for mesos and Benjamin

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2374

2014-09-16 Thread Timothy Chen
Hi Ben, Sounds good, I'll take a look sometime tonight or tomorrow. Tim On Tue, Sep 16, 2014 at 8:34 PM, Benjamin Mahler benjamin.mah...@gmail.com wrote: +Tim Chen Can you take a look at the health check failure? https://issues.apache.org/jira/browse/MESOS-1802 I'll take a look at the

Re: Review Request 25403: Override entrypoint when shell enabled in Docker

2014-09-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25403/#review53637 --- Patch looks great! Reviews applied: [25403] All tests passed. -

Re: Mesos 0.20.1 release status

2014-09-16 Thread Bhuvan Arumugam
Release update: We have finalized the issue/commits that will make it for this release. We are waiting to merge these 2 patches, before we cut 0.20.1 RC1: https://reviews.apache.org/r/25403/ https://reviews.apache.org/r/25523/ On Tue, Sep 16, 2014 at 2:14 PM, Bhuvan Arumugam bhu...@apache.org

Build failed in Jenkins: mesos-reviewbot #1590

2014-09-16 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/1590/changes Changes: [vinodkone] Enabled bridge network for Docker Containerizer. -- [...truncated 3883 lines...] make check-am make[3]: Entering directory

Build failed in Jenkins: mesos-reviewbot #1591

2014-09-16 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/1591/ -- [...truncated 3870 lines...] make[6]: Leaving directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/3rdparty/libprocess' make[5]: Leaving directory

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2106

2014-09-16 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2106/changes Changes: [vinodkone] Enabled bridge network for Docker Containerizer. -- [...truncated 3121 lines...] byte-compiling

Build failed in Jenkins: Mesos-Ubuntu-distcheck #334

2014-09-16 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/334/changes Changes: [vinodkone] Enabled bridge network for Docker Containerizer. -- [...truncated 3865 lines...] libtool: link: g++ -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -o tests