+1 to growing the list of use cases for 'auto' organically.
I agree with Cody that using 'auto' for return type deduction should also
be included, especially since we're already using it in libprocess.
On Mon, Sep 22, 2014 at 10:50 AM, Cody Maloney c...@mesosphere.io wrote:
There are some
On Sept. 22, 2014, 7:19 p.m., Ben Mahler wrote:
docs/mesos-c++-style-guide.md, lines 96-99
https://reviews.apache.org/r/25622/diff/3/?file=699636#file699636line96
Why would the iterator be called `containerizer`?
s/containerizer/iterator/ ?
Dominic Hamon wrote:
On Sept. 22, 2014, 7:19 p.m., Ben Mahler wrote:
docs/mesos-c++-style-guide.md, lines 96-99
https://reviews.apache.org/r/25622/diff/3/?file=699636#file699636line96
Why would the iterator be called `containerizer`?
s/containerizer/iterator/ ?
Dominic Hamon wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25622/
---
(Updated Sept. 25, 2014, 11:47 a.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25622/#review54532
---
Patch looks great!
Reviews applied: [25622]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/
---
(Updated Sept. 25, 2014, 5:10 p.m.)
Review request for mesos and Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/#review54549
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25864/#review54553
---
Ship it!
src/linux/cgroups.cpp
On Sept. 22, 2014, 7:19 p.m., Ben Mahler wrote:
docs/mesos-c++-style-guide.md, lines 96-99
https://reviews.apache.org/r/25622/diff/3/?file=699636#file699636line96
Why would the iterator be called `containerizer`?
s/containerizer/iterator/ ?
Dominic Hamon wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/
---
(Updated Sept. 25, 2014, 6:25 p.m.)
Review request for mesos and Benjamin
On Sept. 5, 2014, 9 p.m., Dominic Hamon wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/unreachable.hpp, line 21
https://reviews.apache.org/r/25191/diff/1/?file=672334#file672334line21
can we use __builtin_unreachable instead?
we should probably check for it
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25945/#review54571
---
This seems like a good approach, I'm curious if there's any room
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25191/
---
(Updated Sept. 25, 2014, 12:34 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26052/
---
Review request for mesos and Niklas Nielsen.
Repository: mesos-git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26052/
---
(Updated Sept. 25, 2014, 7:37 p.m.)
Review request for mesos and Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26052/#review54585
---
Ship it!
Ship It!
- Niklas Nielsen
On Sept. 25, 2014, 12:37
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25868/#review54588
---
Ship it!
Ship It!
- Niklas Nielsen
On Sept. 22, 2014, 6:18
On Sept. 24, 2014, 11:39 p.m., Ben Mahler wrote:
src/master/master.cpp, lines 743-744
https://reviews.apache.org/r/25866/diff/3/?file=700961#file700961line743
Why do we check slave-connected before calling disconnect below, but
we don't check framework-connected here?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25867/
---
(Updated Sept. 25, 2014, 8:41 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26052/#review54592
---
Patch looks great!
Reviews applied: [26052]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25191/#review54593
---
Ship it!
The whole chain looks good to me, can you reach out to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26056/
---
Review request for mesos and Niklas Nielsen.
Repository: mesos-git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26056/#review54596
---
3rdparty/libprocess/src/synchronized.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25986/#review54597
---
Ship it!
Great, didn't realize this was all that's needed for
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25986/
---
(Updated Sept. 25, 2014, 9:09 p.m.)
Review request for mesos and Ben Mahler.
On Sept. 25, 2014, 2:08 p.m., Ben Mahler wrote:
Great, didn't realize this was all that's needed for MESOS-1461, I'll
assign that to you.
Can you link the ticket into this review?
Yeah - wired everything up but the last step :-P
We should wire task reconciliation up in the test
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25191/#review54600
---
3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25945/
---
(Updated Sept. 25, 2014, 2:42 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26056/#review54606
---
Patch looks great!
Reviews applied: [26056]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26060/
---
Review request for mesos and Niklas Nielsen.
Repository: mesos-git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26060/#review54612
---
3rdparty/libprocess/src/event_manager.hpp
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2125/changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26060/#review54616
---
Bad patch!
Reviews applied: [26060]
Failed command: make -j3
See https://builds.apache.org/job/mesos-reviewbot/1723/changes
Changes:
[niklas] Added reconcileTasks to python scheduler.
--
[...truncated 7953 lines...]
warning: failed to remove mesos-0.21.0/m4/lt~obsolete.m4
warning: failed to remove
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24177/#review54618
---
Ship it!
src/tests/isolator_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26056/
---
(Updated Sept. 25, 2014, 11:04 p.m.)
Review request for mesos and Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25861/#review54619
---
lgtm, modulo comments. i'll let jie give the final shipit.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26056/#review54625
---
Ship it!
Ship It!
- Niklas Nielsen
On Sept. 25, 2014, 4:04
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26056/#review54626
---
3rdparty/libprocess/src/net.hpp
On Sept. 25, 2014, 4:35 p.m., Niklas Nielsen wrote:
3rdparty/libprocess/src/net.hpp, line 232
https://reviews.apache.org/r/26056/diff/2/?file=705786#file705786line232
Missed this one s/HH/HPP/
Fixed it when committing - thanks!
- Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25622/#review54629
---
Could you do a drive-by fix here to make the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25549/#review54627
---
src/slave/containerizer/isolators/filesystem/shared.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25863/#review54630
---
Ship it!
Ship It!
- Vinod Kone
On Sept. 23, 2014, 11:39 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25965/#review54632
---
Ship it!
Ship It!
- Vinod Kone
On Sept. 24, 2014, 6:13 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25964/#review54631
---
Ship it!
Ship It!
- Vinod Kone
On Sept. 24, 2014, 6:14 p.m.,
See https://builds.apache.org/job/mesos-reviewbot/1724/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/
---
(Updated Sept. 25, 2014, 8:45 p.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25865/#review54637
---
src/slave/containerizer/isolators/namespaces/pid.hpp
On Sept. 26, 2014, 1:17 a.m., Vinod Kone wrote:
Can you attach the bug. Also, need documentation.
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25865/#review54637
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/
---
(Updated Sept. 25, 2014, 9:27 p.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25966/#review54641
---
src/slave/containerizer/linux_launcher.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25864/#review54643
---
Ship it!
lgtm modulo comments.
- Vinod Kone
On Sept. 23, 2014,
On Sept. 25, 2014, 11:56 p.m., Vinod Kone wrote:
Mind adding documentation for this?
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25549/#review54627
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/#review54646
---
Patch looks great!
Reviews applied: [25848]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/
---
Review request for mesos, Benjamin Hindman, Cody Maloney, Dominic Hamon, and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26071/
---
Review request for mesos, Bernd Mathiske and Niklas Nielsen.
Bugs: MESOS-1384
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/
---
(Updated Sept. 26, 2014, 5:56 a.m.)
Review request for mesos, Benjamin
57 matches
Mail list logo
