Header include order

2015-11-10 Thread Jan Schlicht
Currently there is no consensus on the order of includes. I'm currently working on MESOS-2275 and would suggest, that we follow the rules from the Google C++ Style Guide ( https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes) as much as possible but also follow the current

Re: Header include order

2015-11-10 Thread Jörg Schad
We posted a fix for the inconsistent include order of and < gmock/gmock.h> making it consistent with the Google Styleguide ( https://google.github.io/styleguide/cppguide .html#Names_and_Order_of_Includes). Check the Jira/Review Request for details:

Re: Website update frequency

2015-11-10 Thread Vinod Kone
That said, this can be automated as a step in apply-reviews script. For example, the script can check if something in site/ (or docs/ ?) is being committed and if yes, also do an svn update. @artem do you want to take this on as you revamp the apply-reviews script? On Tue, Nov 10, 2015 at 1:23

Re: Better error reporting in Mesos

2015-11-10 Thread Michael Hopcroft
There have been a lot of great suggestions on this thread. My recommendation is that I do an experiment to uncover any hidden issues with the macro approach outlined in my original email. I will try to design the API of the ErrorImpl class so that it would be, not only possible, but easy to add

Fetcher refactor proposal

2015-11-10 Thread Jie Yu
Hi, Fetcher was originally designed to fetch CommandInfo::URIs (e.g., executor binary) for executors/tasks. A recent refactor (MESOS-336 ) added caching support to the fetcher. The recent work on filesystem isolation/unified containerizer (

Website update frequency

2015-11-10 Thread Neil Conway
Does anyone know how frequently the docs at mesos.apache.org are updated? I notice that some docs changes from > 1 week ago aren't reflected on the current site. Neil

Re: Website update frequency

2015-11-10 Thread Adam Bordelon
Since it's still a manual process, the website is usually only updated a) when we have a new release to announce, or b) when some other blog-worthy content arises (e.g. MesosCon). On Tue, Nov 10, 2015 at 1:06 AM, Jonathon Rossi wrote: > It is currently a manual process

Re: Website update frequency

2015-11-10 Thread Jonathon Rossi
It is currently a manual process performed by a committer, however there are plans to make it automated. See this thread for the recent discussion: http://www.mail-archive.com/dev@mesos.apache.org/msg33541.html On Tue, Nov 10, 2015 at 6:56 PM, Neil Conway wrote: > Does

Re: Fetcher refactor proposal

2015-11-10 Thread Tom Arnfeld
This looks like a great change, btw! I have a quick question, how does this change affect things like the executable/extract bits that are available in the existing fetcher? Would that logic move outside of the fetcher itself, or would it live on the URI? I’m not sure if I’ve missed something

Re: Website update frequency

2015-11-10 Thread haosdent
I think we could consider generate the document realtime. Like http://netty.io/wiki/index.html Loading the markdown from their github wiki repo and generate html in browser. I write some simple javascript to implement this several months ago.

Re: Website update frequency

2015-11-10 Thread Jonathon Rossi
You are obviously free to implement this as you wish, however one of the things we realised is that the hosted API docs on the web site are also very out of date, and by doing it this way would mean they stay out of date. Doing it this way means you would really have to update on every commit, or

Re: Website update frequency

2015-11-10 Thread Jonathon Rossi
We've also still got this one open that I intended would take us right through to the automatic site build: https://issues.apache.org/jira/browse/MESOS-3687 On Wed, Nov 11, 2015 at 5:00 PM, Artem Harutyunyan wrote: > Hey Vinod, > > Here is the JIRA

Re: Fetcher refactor proposal

2015-11-10 Thread Gilbert Song
+1. Depending on one of unified container issue MESOS-2970 , We need to support cache for container image as our next step. It would be perfect if we can reuse some parts of fetcher cache. It may also be helpful to many other issues related to

Re: Fetcher refactor proposal

2015-11-10 Thread Jie Yu
Tom, I don't have immediate plan to replace CommandInfo::URI (with executable/extract bits) with URI (in the doc), at least for now. The existing Fetcher will still perform extraction, chown, etc. for now (eventually, though I think those logics should be moved to slave/containerizer). The

Re: Website update frequency

2015-11-10 Thread Artem Harutyunyan
Hey Vinod, Here is the JIRA https://issues.apache.org/jira/browse/MESOS-3883. I don't mean to hijack this thread, and I apologize for the off-topic, but do you think it would make sense to have another script for committers that will use apply-reviews.py? At some point you also mentioned that it

Re: Website update frequency

2015-11-10 Thread Jonathon Rossi
The JavaDoc on the Netty page looks like static HTML. However I see the other docs loading from the wiki. Loading the Mesos markdown files looks pretty nice and simple using marked, however I assume that'll lock Google Search out of content and change all the URLs? On Wed, Nov 11, 2015 at 12:43

Re: Website update frequency

2015-11-10 Thread haosdent
google crawlers support execute javascript. Netty.io looks generate in server side now. On Wed, Nov 11, 2015 at 11:36 AM, Jonathon Rossi wrote: > The JavaDoc on the Netty page looks like static HTML. However I see the > other docs loading from the wiki. > > Loading the Mesos

Re: Website update frequency

2015-11-10 Thread Jonathon Rossi
After a quick google search you are definitely right, I knew google did but they've definitely innovated in the last few years. Is there any tools to do the same for Doxygen and javadoc? On Wed, Nov 11, 2015 at 1:49 PM, haosdent wrote: > google crawlers support execute