Re: Order of includes

2016-12-18 Thread Yan Xu
The example is helpful. Thanks! I have no objection to sticking to the new rule then. But the we have to: - For contributors and committers, start using the new style when creating new files today. - Fix the existing include order hopefully with the help of tools like clang-tidy and have it

Metrics collection affected when libprocess queue builds up

2016-12-18 Thread Zhitao Li
Hi all, While I was debugging an allocator message queue build up issue on master (which I plan to share another thread), I noticed that `/metrics/snapshot` is also badly affected. For example, when the allocator queue has ~3k dispatches in it (revealed by the

Re: Welcome Guangya Liu as Mesos Committer and PMC member!

2016-12-18 Thread Yan Xu
Congrats! --- Jiang Yan Xu | @xujyan On Mon, Dec 19, 2016 at 1:31 AM, haosdent wrote: > Congrats Guangya! > > On Sun, Dec 18, 2016 at 10:02 PM, Klaus Ma wrote: > >> Congratulations!! >> >> On Sat, Dec 17,

Re: Map support in proto2

2016-12-18 Thread Neil Conway
I believe `oneof` is supported in protobuf 2.6.1 [1], so we wouldn't need to upgrade to make use of it. But I agree that upgrading to protobuf 3 (while continuing to use the proto2 language version) is worth doing at some point. Neil [1]

Re: Map support in proto2

2016-12-18 Thread Michael Park
According to this thread https://groups.google.com/forum/m/#!topic/protobuf/p4WxcplrlA4, It would involve us upgrading proto to 3.0.0 (which does not mean proto3). It seems like we would also get `oneof` which would also be very useful for us. On Sun, Dec 18, 2016 at 11:00 AM Jie Yu

Map support in proto2

2016-12-18 Thread Jie Yu
Looks like Map is already supported in proto2: https://developers.google.com/protocol-buffers/docs/reference/cpp-generated#map-fields It'll greatly simply our json parsing in a few cases (e.g., converting from OCI image configuration to a protobuf definition for key->value json object):

Re: Welcome Guangya Liu as Mesos Committer and PMC member!

2016-12-18 Thread haosdent
Congrats Guangya! On Sun, Dec 18, 2016 at 10:02 PM, Klaus Ma wrote: > Congratulations!! > > On Sat, Dec 17, 2016 at 1:23 PM Dharmesh Kakadia > wrote: > >> Congrats Guangya ! >> >> Thanks, >> Dharmesh >> >> On Fri, Dec 16, 2016 at 5:03 PM, Dario

Re: Welcome Guangya Liu as Mesos Committer and PMC member!

2016-12-18 Thread Klaus Ma
Congratulations!! On Sat, Dec 17, 2016 at 1:23 PM Dharmesh Kakadia wrote: > Congrats Guangya ! > > Thanks, > Dharmesh > > On Fri, Dec 16, 2016 at 5:03 PM, Dario Rexin wrote: > > Congrats! > > > On Dec 16, 2016, at 4:27 PM, Vinod Kone