Re: Authorization Logging

authorization based on ideas from BenH https://reviews.apache.org/r/65311/ <https://reviews.apache.org/r/65311/> . Reviews/comments always welcomed Alexander Rojas alexander.ro...@gmail.com > On 28. Feb 2018, at 23:52, Benjamin Mahler <bmah...@apache.org> wrote: > > When

Re: [Proposal] Use jemalloc as default memory allocator for Mesos

of gperftools, so I would like to have a whole picture of the advantages and disadvantages of both options. Alexander Rojas alexan...@mesosphere.io > On 18. Aug 2017, at 12:49, Benno Evers <bev...@mesosphere.com> wrote: > > Hi all, > > I would like to propose bundling jemallo

Re: [VOTE] Release Apache Mesos 1.2.2 (rc1)

+1 (binding) Ran manual tests in Fedora 25 and Ubuntu 17.04 Alexander Rojas alexan...@mesosphere.io > On 5. Aug 2017, at 02:12, Adam Bordelon <a...@mesosphere.io> wrote: > > Hello Mesos community, > > Please vote on releasing the following candidate as Apache Me

Mesos 1.2.2 Release

me know. For any backport patches, please update the CHANGELOG accordingly. Best, Alexander Rojas alexan...@mesosphere.io

Re: Easing the Pain of Code Formatting in Mesos

+1 It is always frustrating to rely in clang format to realize it generate the wrong style, even for old Mesos contributors Alexander Rojas alexan...@mesosphere.io > On 15. Jun 2017, at 04:32, Michael Park <mp...@apache.org> wrote: > > I'm increasingly hearing that many c

Use of ACLs.RegisterAgent.agent

will try to push for a rename without going through any deprecation cycle. The big question is if any of you are using this particular ACL in production right now? Alexander Rojas alexan...@mesosphere.io

Re: Custom Authentication

ator_module.cpp> Alexander Rojas alexan...@mesosphere.io > On 20 Mar 2017, at 18:11, Joao Costa <labremoted...@gmail.com> wrote: > > Hello, > > I'm trying to create a custom authentication and I was wondering if anyone > could give me some help. > > Is there any ki

Re: Proposal for Mesos Build Improvements

indirectly end up including almost every header in the project. Alexander Rojas alexan...@mesosphere.io > On 15 Feb 2017, at 20:12, Neil Conway <neil.con...@gmail.com> wrote: > > On Tue, Feb 14, 2017 at 11:28 AM, Jeff Coffler > <jeff.coff...@microsoft.com.invalid> wrote: &g

Re: [VOTE] Release Apache Mesos 1.1.0 (rc1)

+1 (non-biding) Ubuntu 16.04 ../configure --enable-ssl --enable-libevent && sudo make check On Mon, Oct 24, 2016 at 3:41 PM, Gastón Kleiman wrote: > +1 (non-binding), "make check' and also Marathon's integration tests pass > on OS X. > > -Gastón > > On Tue, Oct 18, 2016

Re: Separate Compilation of Tests

The workaround I use is to go to the folder of the makefile root directory, so for Mesos, and then use the specific target, for example: For mesos-tests cd ${MESOS_SRC_ROOT}/build/src make -j4 mesos-tests && ./mesos-tests for libprocess cd ${MESOS_SRC_ROOT}/build/3rdparty/libprocess make -j4

Re: Lambdas: caveats, do's and don'ts

Now that you touch the topic, I think that we need to expand our style guide concerning lambdas. The rules do not cover all the cases, e.g. ``` auto lambda = [a, long, number, of, captures](a, long, number, of, parameters) -> ExplicitReturnType { } ``` so far, the formatting has been done

Re: [Tech-debt] Introduce regex into Mesos

That was discussed in the past. The main issue is Mesos only bundles header only libraries and regex is a binary one. > On 05 Jul 2016, at 19:53, haosdent wrote: > >> As Joseph said, regex works well in llvm 7.3 & gcc 5.3, but does not work > in gcc 4.8.4; also try "" in gc

Re: WebUI authentication in 1.0.0-rc1

I think we should also think more thoroughly about the expected behaviour when we introduce new authorizable actions (and we most certainly will). Since things may break particularly if users set the `permissive` ACL field to false. Perhaps initially, if no ACL is given for the new action we

Re: mesos git commit: Added documentation for access_sandboxes and access_mesos_logs acls.

Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/53b5164b >>> Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/53b5164b >>> Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/53b5164b >>> >>> Branch: refs/heads/mast

Re: Line length in docs

+1 (Actually more like +10) But I think your reasons are not the main problem in solving this issue. For me, when we have whole paragraphs in one line, and I want to see the changes in the document, even adding a comma renders the whole paragraph as changed, which makes the tracking of changes

Re: Should "read-only" HTTP endpoints allow other request methods than "GET"?

I like the idea of using HTTP GET only, or at least a way to verify the method as early as possible. When discussing authorization, something that occur to me is that authorization is a potentially expensive call, so if we can discard the request as early as possible because the method doesn’t

[Proposal] Authorization support for task sandboxes

As part of our work towards better security in Mesos, we have been working on a proposal to protect the sandboxes of the launched tasks. Here [1] we propose a mechanism used to achieve such goal. We welcome any comments and suggestions on it. Looking forward to your feedback. [1]

Re: Design Doc for Qemu/KVM containerizer

Hi Haosdent, Till had an accident and will be out for a while, your reviews may take a while or otherwise you may consider getting help from a second shepherd. > On 07 Apr 2016, at 17:00, haosdent wrote: > > Hi, @Abhishek Thanks your nice design document. I just take a

Re: Typed Error Handling in Mesos

+1 What I like is that it allows from some kind of type safety into the error management beyond trying to parse error strings. > On 05 Apr 2016, at 03:48, Michael Park wrote: > > Contrary to standard C++ practices, Mesos uses return values as the > mechanism > for error

Re: Compile failure

Hi Walter, I once had the same problem. The solution is to move to subversion 1.8, so as super user try: # Change version in the repository sed -i "s/1.9/1.8/g" /etc/yum.repos.d/wandisco-svn.repo # Remove cache files rm -rf /var/cache/yum/x86_64/7Server/WANdiscoSVN/* # Rebuild the cache yum

Re: Executors no longer inherit environment variables from the agent

Not that I know a lot about this project, but I think for the command executor we can use the `Environment` message. Perhaps we can extend the container info to have something similar? > On 10 Mar 2016, at 12:50, Alex Rukletsov wrote: > > I have two questions. > >

Re: Negative durations

IMO durations should not be negative. The problem with having them define an infinite period is the following: Lets say you want to compute the duration between two durations A and B: C = A-B; if A < B, C is negative and it will be infinite. I one want’s to check for the case mentioned in [1]

Re: Making 'curl' a prerequisite for installing Mesos

I also have my doubts about this idea. Given that we support some legacy systems and the user interface tends to be less stable than an API (though comparing the flags between curl 7.38.0 in Debian 8 and curl 7.19.7 in CentOS 6.7, I don’t see a lot of differences in the important ones). So I

[proposal] Generalized Authorizer Interface

Hey guys, After many discussions and back and forth, it was decided to revived the already deprecated design [1] for the internal authorizer interface. Sorry for asking you again to review this document but any comment will be gladly welcome. Best, Alexander Rojas [1] https

Re: On implicit construction of objects whose constructor takes multiple parameters

>> In your example case with the braced initializer, the type isn't stated. I >> agree that the explicit construction should be required. >> >> On Mon, Feb 29, 2016 at 3:14 PM, Alexander Rojas <alexan...@mesosphere.io> >> wrote: >> >>> Hi Guys

On implicit construction of objects whose constructor takes multiple parameters

Hi Guys, Today I was making a code review and I came across the following snippet: ``` metrics.allocated.put( name, {strings::join("/", "allocator/allocated", name), process::defer(self(), [this, name]() { double result = 0; foreachvalue (const Slave& slave,

Re: [proposal] Generalized Authorized Interface

Hi Guys, After addressing the issues you presented about the authorizer interface, we updated the design [1]. Please comment on it. Best, Alexander Rojas [1] https://docs.google.com/document/d/1gCR6fpD_1wKbVUtj6iP2sqsARtMfgTz5YJpJ1nd7zBA/ > On 22 Feb 2016, at 10:48, Alexander Rojas <

[proposal] Generalized Authorized Interface

Hey guys, After some extra thought, we came to what we think is a nice interface for the Mesos authorizer [1] which will allow users of Mesos to use to your custom backends in a nice way. Please share your thoughts with us in case we missed something or there are improvements we can make to

Re: Enable compiler optimization by default?

+1 Since the old days users are used to run ``` configure make sudo make install ``` and things just work. With the model we have, we are just encouraging users to run their data centers with unoptimized versions of Mesos, which just hurts their performance. > On 17 Feb 2016, at 16:24, Neil

Re: Inconsistent naming of support scripts

+1 for consistency, +1 for executables. I do enough finger yoga while using emacs! running `find /usr/local/bin -name "*-*" | wc -l` returned 142 while `find /usr/local/bin -name "*_*" | wc -l` was only 17. So I feel using hyphen for executables is more standard. > On 11 Feb 2016, at 14:58,

Re: Reorganize 3rdparty directory

+1 I am one who is totally in for that change. It is not only the directories problem, but the structure which has led that the stout tests (which do need to be compiled) are actually managed in the libprocess Makefile, on top of all the things you have already mentioned. > On 09 Feb 2016, at

Re: Precision of scalar resources

+1 Strong initial first step to remove a huge headache. > On 12 Feb 2016, at 14:25, Neil Conway wrote: > > Additional precision in resource values will be discarded > (via rounding).

Re: Version numbers in docs

I actually like the idea to have version specific documentation, since it is kind of the standard way of going about things. +1 to that. > On 03 Feb 2016, at 01:53, Neil Conway wrote: > > I agree we should remove this text after some period of time has > passed since

Re: .gitignore-template

It certainly is not unwittingly unless you are one of those who do `git yolo` and we should really discourage such dangerous way of writing patches. Once you do git status you will notice there is something wrong with the template. That being said, +1 to add this to the documentation. These

Re: JIRA Shepherds

My grain of sand here. It is true that committers are a scare resource and it might be hard to get shepherds nowadays. However we do have a bunch of seasoned contributors, which while not being committers are active and know some of the innards of Mesos very well. How about having these guys as

Re: [VOTE] Release Apache Mesos 0.27.0 (rc1)

-1 (non binding) Test on Debian 8 under a VirtualBox debian machine. While doing `configure && sudo make -j4 check` and then: `sudo ./bin/mesos-tests.sh --gtest_filter=“-*.ROOT_CGROUPS_Listen:*.ROOT_IncreaseRSS" --gtest_repeat=10 --gtest_break_on_failure` I got failures on

Re: Install some 3rdparty packages needed for building Mesos modules

While valid, I feel that is a very un-unix way of doing this. There are a couple of ideas from me here. 1. We should separate between a dev release and a normal release. The dev release will include headers for people who want to build modules and other mesos stuff, and the normal release only

Re: Contribution Request

Hey guys, There is already a flag called `authenticate_frameworks` which was added as early as April 2015, it also includes a TODO pointing to the mentioned JIRA (MESOS-4386). So I think enough time has passed to simply remove the flag. Best, Alexander > On 15 Jan 2016, at 19:15, Vinod Kone

Re: Mesos build & testing environment instructions

+1 This would be really helpful > On 17 Dec 2015, at 21:38, Greg Mann wrote: > > reparation for the 0.26.0 release. Since I started contributing > to the project, my Source of Truth for "how to prepare a given platform to > compile and run Mesos" has been the Getting Started

Re: Change minimum supported version for GCC to 4.8.1

+1 > On 05 Jan 2016, at 00:06, Anand Mazumdar wrote: > > I would like to propose that we bump our minimum supported version for gcc > from 4.8.0 to 4.8.1. The main motivation behind this is that there are at > least 2 outstanding reviews on RB that want to use

Re: `F()` vs `F(void)`

+1 > On 13 Dec 2015, at 19:46, Michael Park wrote: > > Hello, > > In the C++ world, the *void* parameter is considered to be only there for C > compatibility reasons. > > We do a good job of not using *void *parameters in function declarations, > e.g., *void F();*. On the

Re: Can anyone help me understand the Mesos release model

have diverged. When you’re satisfied with your rc, you push the tag but don’t push the branch (though implicitly it does, the becomes effectively an anonymous branch in the git main repository). Repeat the procedure for the next releases. Best, Alexander Rojas > On 09 Dec 2015, at 11

Configuration file?

Hey guys, Over the time I’ve been involved in Mesos I’ve seen that we went from a handful of flags to around 42 supported flags in the master. At this point I’m wondering if perhaps we should support a configuration file in conjunction (or instead of) with all the command flags. My intuition

Re: Add JIRA ticket# to `TODO`s in comments

+1 This also provides a way of removing TODO’s since they are traceable. If you look in the code, there are TODO’s which are no relevant anymore or probably cannot be understood from their actual context. > On 08 Nov 2015, at 05:50, Kapil Arya wrote: > > Folks, > > I

Re: Header include order

I remember discussing this issue a while ago on the mailing list [1]. There were two votes in favor from Benjamin Hindman and Benjamin Mahler, and no votes against it. There’s also an accepted Jira entry MESOS-2673 to add the ordering into our style guide. [1]

Re: Fetcher refactor proposal

+1 > On 11 Nov 2015, at 00:45, Jie Yu wrote: > > Hi, > > Fetcher was originally designed to fetch CommandInfo::URIs (e.g., executor > binary) for executors/tasks. A recent refactor (MESOS-336 > ) added caching support to >

Re: [jira] [Comment Edited] (MESOS-2079) IO.Write test is flaky on OS X 10.10.

I have multiple questions here 1. Why do we use pipes at all? or is SIGPIPE raised also when writing into sockets? which leads me to: 2. Do we use it only in test cases or is there something actively using pipes? SIGPIPE itself is a weird signal, since a failed call to `write` returns -1 and

Re: Backticks in comments

+1 for backticks! > On 02 Nov 2015, at 19:32, Greg Mann wrote: > > Hey folks! > I wanted to bring up a style issue that I noticed recently. In some > comments in the codebase, backticks are used to quote code excerpts and > object names, while in other comments, single

Re: Better error reporting in Mesos

I also like the idea of having better error reports. On that side, I always liked the design of boost system_error where one has categories of errors with a set of error codes (integer) where each of them have a specific string associated and which can be complemented with extra text. > On 06

Re: Mesos Style Guideline Adjustments

n Sat, Aug 8, 2015 at 3:25 PM, Joris Van Remoortere < >>>>>>>> jo...@mesosphere.io> >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> I will volunteer to update all the comme

Re: Proposal: move towards #pragma and away from #include guards

While I’m all in on the proposal, we did have this discussion almost a year ago [1] at the end I think, the decision was not to use them, though I don’t remember the exact reason. In any case, I vote +1 non-binding. [1]

Re: Proposal: move towards #pragma and away from #include guards

nonconsensus, and the review was discarded, with the cited > reason being nonconsensus. > > Hopefully this clarifies these issues. > > On Thu, Nov 5, 2015 at 8:32 AM, Alexander Rojas <alexan...@mesosphere.io> > wrote: >> While I’m all in on the proposal, we did hav

Re: Welcome Kapil as Mesos committer and PMC member!

Congrats Kapil. This is really worth to be celebrated. > On 05 Nov 2015, at 11:02, Till Toenshoff wrote: > > I'm happy to announce that Kapil Arya has been voted a Mesos committer and > PMC member! > > Welcome Kapil, and thanks for all of your great contributions to the

Re: More Project Structure in JIRA

+1 Yes please! > On 15 Oct 2015, at 10:11, Bernd Mathiske wrote: > > Proposal: in extension of today’s limited two-level (epic, task) approach, > make full use of expressive power already available in JIRA to provide more > structure for larger projects to facilitate

Re: Community Sync Interval

+1 bi-weekly (and I as bernd have been assuming rotating times) > On 15 Oct 2015, at 19:19, Michael Park wrote: > > We discussed whether the community syncs should be weekly or bi-weekly > (once every 2 weeks). > > There were differing opinions on the subject during the

Re: RFC convert documentation to Sphinx

I would vote -1. There’s some cost associated with having to learn yet another documentation syntax, while almost all the tools we use easily support markdown. This feels a little like asking to use mercurial instead of git, sure it might be better at some stuff, but we will definitely find

Re: Introducing a CMake-based build system for Mesos

Automation is always nice, but I think this is one of those cases where there’s not solution beyond updating guidelines and trusting the reviewers. I recently faced another case of modifying a Makefile.am which didn’t need to update a CMakeLists.txt. If you add a stout test file, it needs to be

Re: [VOTE] Release Apache Mesos 0.23.1 (rc1)

+1 (non binding) Tested Ubuntu 14.04, OSX > On 22 Sep 2015, at 03:06, Adam Bordelon wrote: > > Hi friends, > > Please vote on releasing the following candidate as Apache Mesos 0.23.1. > > 0.23.1 is a bug fix release and includes the following: >

Re: [proposal] Generalized Authorizer Interface

. Thanks, Alexander Rojas On 06 Jul 2015, at 15:42, Alexander Rojas alexan...@mesosphere.io wrote: Hi everyone, The current mesos::Authorizer API has one method for each of the actions supported (Register Framework, Launch Task and Shutdown Framework), and each of these actions define

Re: Mesos Contribution Request

Hey Timothy, Great to hear you are jumping into the ship. As Vinod pointed out, we are working already in an new HTTP based authentication design for Mesos. You can help us out be reading it and point out anything we had miss. On 05 Aug 2015, at 20:56, Timothy Anderegg

HTTP Authentication Doc V1

Hey Guys, Lately the we have been working hard on figuring out the best way to provide HTTP Authentication to Mesos. I would like to share the design doc [1] in order to gather community feedback early enough so we can address issues that might have scape us. The design doc is still a work in

Re: Mesos Style Guideline Adjustments

I also vote up for that! I rather change our guidelines a little bit than waiting for months to get our changes into the clang-format source without any security that it will actually land. On 31 Jul 2015, at 09:31, Alex Rukletsov a...@mesosphere.com wrote: I think automation is very

[proposal] Generalized Authorizer Interface

! Thanks, Alexander Rojas

Style guide for std::move

Hey guys, there have been questions on how to deal with std::move in the code. Right now our style guide says nothing about it, but there is no consensus in the reviews. The problem with std::move is that for all standard library functions that accept rvalue references as parameters are

Re: Mesos Jira workflow

Hey Marco, Thanks for doing this! +1 removing “closed” +1 to go back from “Reviewable” to “In Progress” +1 to go from “In Progress” to “Accepted” instead of “Open” +1 Removing “Reopened On 09 Jun 2015, at 23:26, Marco Massenzio ma...@mesosphere.io wrote: Folks, Please take a look at

Re: On Locales

libraries we can't force users to set process global flags like SIG_IGN. So I guess we should fix (or at least mark as FIXME) all locale related cases like we did with SIGPIPE. On Wed, May 20, 2015, 10:31 Alexander Rojas alexan...@mesosphere.io wrote: Hey guys, I just got a review pointing

On Locales

Hey guys, I just got a review pointing out that ‘strftime’ is dependent on the locale used. This not only affects my patch but code already in Mesos: process/time.hpp and encoder.hpp both make use of fields which are locale specific. The question here is, how to deal with it? Locales tend to

Re: [VOTE] Release Apache Mesos 0.22.1 (rc6)

+1 non binding (Tested in OSX and 3 VM’s cluster running Ubuntu 12.10) On 30 Apr 2015, at 00:48, Adam Bordelon a...@mesosphere.io wrote: Hi all, Please vote on releasing the following candidate as Apache Mesos 0.22.1. 0.22.1 is a bug fix release and includes the following:

Re: Using boost filesystem

: Is it header only? On Wed, Apr 22, 2015 at 2:31 AM, Alexander Rojas alexan...@mesosphere.io wrote: Hey guys, I was checking one of my reviews which call for using some unimplemented functionality in stout path. Since that class has no methods, attributes or anything apart from

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

97ac09fd10b767bc46387abc3657d005a00830c8 3rdparty/libprocess/src/tests/process_tests.cpp eb38edce2c483ba7f963a826893a15a075238618 Diff: https://reviews.apache.org/r/33295/diff/ Testing --- make check Thanks, Alexander Rojas

Re: statusUpdate always RUNNING even after job has finished

Hey Zack, Which value are you for the setting implicitAknowledge parameter in the SchedulerDriver constructor? if it is set to false, you will have to manually knowledge every statusUpdate, otherwise the executor will try to retry. Are you using the python bindings? It seems that the default

Re: Review Request 33358: Moved implementation of StatusUpdateStream to a compilation unit.

(updated) - src/slave/status_update_manager.hpp b4d91b22b515195fdb69c89af9c2864e469e7e54 src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4 Diff: https://reviews.apache.org/r/33358/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 32163: Added a function which checks if a json object is contained within another.

. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32163/#review80854 --- On April 20, 2015, 6:28 p.m., Alexander Rojas wrote

Re: Review Request 33296: Added a flag which controls libprocess firewall initialzation.

tests. Thanks, Alexander Rojas

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

://reviews.apache.org/r/33295/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

b1093bb867eb8624740f3d094cef2c23405a18b6 src/tests/master_tests.cpp 32b1e9bb58d8046e5363fafe2ab8f662b6c9a666 Diff: https://reviews.apache.org/r/30612/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 32198: Added a not equal operator for json objects.

f60d1bbe60f2e2b6460c06bba98e8b85ebb6a3f9 Diff: https://reviews.apache.org/r/32198/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 32163: Added a function which checks if a json object is contained within another.

334c898906018be6e663f53815abbe047806b95c 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp f60d1bbe60f2e2b6460c06bba98e8b85ebb6a3f9 Diff: https://reviews.apache.org/r/32163/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 33358: Moved implementation of StatusUpdateStream to a compilation unit.

/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4 Diff: https://reviews.apache.org/r/33358/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 33358: Moved implementation of StatusUpdateStream to a compilation unit.

- src/slave/status_update_manager.hpp b4d91b22b515195fdb69c89af9c2864e469e7e54 src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4 Diff: https://reviews.apache.org/r/33358/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

, visit: https://reviews.apache.org/r/30612/#review80865 --- On April 20, 2015, 6:27 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

://reviews.apache.org/r/30032/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 33331: Added file headers section to the C++ style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review80707 --- Ship it! Ship It! - Alexander Rojas On April 18, 2015, 3:34 a.m

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

: https://reviews.apache.org/r/30032/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

like ``` #include ctime #include climits #include cstdio ``` and so on. Could you please create a cleanup newbie JIRA for this? Alexander Rojas wrote: Not very sure about that, what it does by using the c… versions of the headers is to put its

Re: Review Request 32198: Added a not equal operator for json objects.

://reviews.apache.org/r/32198/#review80559 --- On April 20, 2015, 5:19 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32198

Re: Review Request 32163: Added a function which checks if a json object is contained within another.

/libprocess/3rdparty/stout/tests/json_tests.cpp f60d1bbe60f2e2b6460c06bba98e8b85ebb6a3f9 Diff: https://reviews.apache.org/r/32163/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 32198: Added a not equal operator for json objects.

/r/32198/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

e30b951eda2b3b0d5b2a80716f0b32c6bbe041bc src/tests/master_tests.cpp 32b1e9bb58d8046e5363fafe2ab8f662b6c9a666 Diff: https://reviews.apache.org/r/30612/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 33154: Added reason metrics for slave removals.

`. 2. The parameter is a const ref, last thing I expected is that it would change later on. Can you add a comment explaining the semantics of reason, and if possible, getting rid of the const ref? - Alexander Rojas On April 14, 2015, 3:46 a.m., Ben Mahler wrote

Re: Review Request 33155: Added commented-out tests for slave removal metrics.

/#comment130363 +1 - Alexander Rojas On April 14, 2015, 3:46 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33155

Re: Review Request 33263: Extended SlaveTest.ShutdownUnregisteredExecutor test with a reason check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33263/#review80451 --- Ship it! Ship It! - Alexander Rojas On April 16, 2015, 4:31 p.m

Re: Review Request 33152: Moved the slave shutdown test into slave_tests.cpp.

/tests/slave_tests.cpp https://reviews.apache.org/r/33152/#comment130359 One line break too many. - Alexander Rojas On April 14, 2015, 3:46 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 33153: Moved a partition test into partition_tests.cpp.

. I also would like to understand why the move is needed (though I might see it later). - Alexander Rojas On April 14, 2015, 3:46 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 31985: Mesos container ID available to the executor through an environment variable.

information. Do you know if there is any other use case to know the container id? Alexander Rojas wrote: 1. I am not aware of any other use case. However I asked benh about this and he mentioned it was ok to have this as extra info on the update, as long as it was no docker

Re: Inlined code

:01 AM, Alexander Rojas alexan...@mesosphere.io wrote: I agree with the fact that stout is headers only, but this is code in mess itself. On 10 Apr 2015, at 13:15, Alex Rukletsov a...@mesosphere.com wrote: wherever possible, but we are not going to m

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

like ``` #include ctime #include climits #include cstdio ``` and so on. Could you please create a cleanup newbie JIRA for this? Alexander Rojas wrote: Not very sure about that, what it does by using the c… versions of the headers is to put its

Re: Review Request 31676: Added documentation about the use of the LIBPROCESS_DISABLED_ENDPOINTS environment variable.

`LIBPROCESS_DISABLED_ENDPOINTS`. Diffs (updated) - docs/configuration.md 54c4e31ed6dfed3c23d492c19a301ce119a0519b Diff: https://reviews.apache.org/r/31676/diff/ Testing --- Thanks, Alexander Rojas

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

like ``` #include ctime #include climits #include cstdio ``` and so on. Could you please create a cleanup newbie JIRA for this? Alexander Rojas wrote: Not very sure about that, what it does by using the c… versions of the headers is to put its

Re: Review Request 31228: Added a mechanism for disabling http endpoints.

/process_tests.cpp eb38edce2c483ba7f963a826893a15a075238618 Diff: https://reviews.apache.org/r/31228/diff/ Testing (updated) --- make check Thanks, Alexander Rojas

  1   2   3   >