Re: Enable compiler optimization by default?

I won't -1 but please see below before proceeding. This was the original behavior and this will bring it full circle :) See the thread here, and the additional links: http://markmail.org/thread/ylqbxezgz6rtb7v2 https://reviews.apache.org/r/26426/#comment_rc96919-56878

Re: Enable compiler optimization by default?

+1 (binding) with the condition that we fix the flag mixing problem between CXXFLAGS and --enable-optimize --enable-debug, even if it is to disallow it for now. I want to avoid surprising behavior with implicit flags such as optimize: passing irrelevant CXXFLAGS magically turns it into a debug

Re: Enable compiler optimization by default?

Great! I created https://issues.apache.org/jira/browse/MESOS-4709 to track this issue. Neil On Thu, Feb 18, 2016 at 12:43 AM, Jan Schlicht wrote: > +1 > > On Thu, Feb 18, 2016 at 2:34 AM, Klaus Ma wrote: > >> +1; >> >> So our CI will also update to

Re: Enable compiler optimization by default?

+1 On Thu, Feb 18, 2016 at 2:34 AM, Klaus Ma wrote: > +1; > > So our CI will also update to use optimisation flags, right? We need to > highlight this in upgrade document to our user; I used to meet so strange > behaviour after changing -O level. > > On Thu, Feb 18,

Re: Enable compiler optimization by default?

+1; So our CI will also update to use optimisation flags, right? We need to highlight this in upgrade document to our user; I used to meet so strange behaviour after changing -O level. On Thu, Feb 18, 2016 at 8:51 AM James DeFelice wrote: > +1 > On Feb 17, 2016 7:24

Re: Enable compiler optimization by default?

+1 Since most of our debugging is using logs rather than GDB, don't see the point of not having these optimization flags turned on by default. On Wed, Feb 17, 2016 at 4:56 PM, Alexander Rojas wrote: > +1 > > Since the old days users are used to run > > ``` > configure

Re: Enable compiler optimization by default?

On Wed, Feb 17, 2016 at 5:07 PM, Zameer Manji wrote: > Can't this problem also be solved by distributing packages that have > optimized binaries? The individuals/organizations that build packaged versions of Mesos should ensure that compiler optimizations are enabled -- but I

Re: Enable compiler optimization by default?

+1 Can't this problem also be solved by distributing packages that have optimized binaries? On Wed, Feb 17, 2016 at 4:56 PM, Alexander Rojas wrote: > +1 > > Since the old days users are used to run > > ``` > configure > make > sudo make install > ``` > > and things

Re: Enable compiler optimization by default?

+1 Since the old days users are used to run ``` configure make sudo make install ``` and things just work. With the model we have, we are just encouraging users to run their data centers with unoptimized versions of Mesos, which just hurts their performance. > On 17 Feb 2016, at 16:24, Neil

Re: Enable compiler optimization by default?

+1 On Feb 17, 2016 7:24 PM, "Neil Conway" wrote: > Hi folks, > > At present, Mesos defaults to compiling with "-O0"; to enable compiler > optimizations, the user needs to specify "--enable-optimize". > > I'd like to propose we change the default, for a few reasons: > > (1)

Re: Enable compiler optimization by default?

+1 On Wed, Feb 17, 2016 at 4:24 PM, Neil Conway wrote: > Hi folks, > > At present, Mesos defaults to compiling with "-O0"; to enable compiler > optimizations, the user needs to specify "--enable-optimize". > > I'd like to propose we change the default, for a few reasons: >

Enable compiler optimization by default?

Hi folks, At present, Mesos defaults to compiling with "-O0"; to enable compiler optimizations, the user needs to specify "--enable-optimize". I'd like to propose we change the default, for a few reasons: (1) The autoconf default for CFLAGS/CXXFLAGS is "-O2 -g". Anecdotally, I think most