Re: Recent changes to MesosTest helpers

2016-03-19 Thread Joseph Wu
We tried to reduce segfaults of this particular pattern (de-referencing out-of-scope stack variables), as much as possible. This means the test suite shouldn't crash due to flaky tests anymore. And the test suite should run to completion each time. (I also replaced a bunch of CHECK_* statements

Re: Recent changes to MesosTest helpers

2016-03-19 Thread haosdent
Got it, thank you for explanation. On Thu, Mar 17, 2016 at 12:51 AM, Joseph Wu wrote: > We tried to reduce segfaults of this particular pattern (de-referencing > out-of-scope stack variables), as much as possible. This means the test > suite shouldn't crash due to flaky

Re: Recent changes to MesosTest helpers

2016-03-19 Thread haosdent
Does it exit like segment when CHECK_xxx failed? Or exit until finish all test cases? On Mar 16, 2016 11:03 PM, "Joseph Wu" wrote: > Hello Devs & Contributors, > > We recently committed a refactor of the MesosTest suite and underlying > "Cluster" abstraction. This affects

Re: Recent changes to MesosTest helpers

2016-03-19 Thread Vinod Kone
This is awesome! Thanks for working on this. On Wed, Mar 16, 2016 at 9:53 AM, haosdent wrote: > Got it, thank you for explanation. > > On Thu, Mar 17, 2016 at 12:51 AM, Joseph Wu wrote: > > > We tried to reduce segfaults of this particular pattern

Recent changes to MesosTest helpers

2016-03-18 Thread Joseph Wu
Hello Devs & Contributors, We recently committed a refactor of the MesosTest suite and underlying "Cluster" abstraction. This affects almost every existing test and future test, so here's a summary of what has changed and what you should be aware of: - The purpose of the refactor is to make