Re: Review Request 14164: Fixed build breakage from 37e946683f1bb6a.

2013-09-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14164/#review26161 --- configure.ac https://reviews.apache.org/r/14164/#comment51119

Re: Review Request 14164: Fixed build breakage from 37e946683f1bb6a.

2013-09-16 Thread Vinod Kone
On Sept. 17, 2013, 12:55 a.m., Vinod Kone wrote: configure.ac, line 217 https://reviews.apache.org/r/14164/diff/1/?file=352499#file352499line217 This is missing a ;; here. Also confirmed that the patch works with gcc 4.2 on osx and linux (after the semicolons fix ofcourse :)). -

Re: Review Request 14164: Fixed build breakage from 37e946683f1bb6a.

2013-09-16 Thread Brenden Matthews
On Sept. 17, 2013, 12:55 a.m., Vinod Kone wrote: configure.ac, line 217 https://reviews.apache.org/r/14164/diff/1/?file=352499#file352499line217 This is missing a ;; here. Vinod Kone wrote: Also confirmed that the patch works with gcc 4.2 on osx and linux (after the

Re: Review Request 14164: Fixed build breakage from 37e946683f1bb6a.

2013-09-16 Thread Brenden Matthews
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14164/ --- (Updated Sept. 17, 2013, 3:10 a.m.) Review request for mesos. Changes

Re: Review Request 14164: Fixed build breakage from 37e946683f1bb6a.

2013-09-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14164/#review26166 --- Ship it! Ship It! - Vinod Kone On Sept. 17, 2013, 3:10 a.m.,

Re: Review Request 14164: Fixed build breakage from 37e946683f1bb6a.

2013-09-16 Thread Brenden Matthews
On Sept. 17, 2013, 3:48 a.m., Vinod Kone wrote: Ship It! I can't commit this right now. If it can't wait until the morning, I'll need somebody to do it for me. - Brenden --- This is an automatically generated e-mail. To reply,